Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Jun 9, 2025

Proposed changes (including videos or screenshots)

Important

This change is under feature preview

Screenshot 2025-06-09 at 16 01 19

Issue(s)

Steps to test or reproduce

Further comments

SIDE2-9
SIDE2-13

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 9, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2025

⚠️ No Changeset found

Latest commit: b3e524e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris force-pushed the feat/sidepanel-item branch from cc9631d to b3e524e Compare June 9, 2025 19:10
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36187/

Built to branch gh-pages at 2025-06-09 19:22 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 10.89109% with 90 lines in your changes missing coverage. Please review.

Project coverage is 63.82%. Comparing base (2ca459a) to head (b3e524e).
Report is 1 commits behind head on feat/sidebar-filters.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##           feat/sidebar-filters   #36187      +/-   ##
========================================================
- Coverage                 63.87%   63.82%   -0.05%     
========================================================
  Files                      3120     3128       +8     
  Lines                     98208    98285      +77     
  Branches                  18636    18666      +30     
========================================================
+ Hits                      62729    62730       +1     
- Misses                    32749    32818      +69     
- Partials                   2730     2737       +7     
Flag Coverage Δ
e2e 55.18% <10.89%> (-0.11%) ⬇️
unit 69.96% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dougfabris dougfabris marked this pull request as ready for review June 9, 2025 20:53
@dougfabris dougfabris requested a review from a team as a code owner June 9, 2025 20:53
@dougfabris dougfabris merged commit a0b70be into feat/sidebar-filters Jun 10, 2025
79 of 81 checks passed
@dougfabris dougfabris deleted the feat/sidepanel-item branch June 10, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants