chore: Remove references to EE code from the app bridges - #31757
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31757 +/- ##
===========================================
+ Coverage 54.44% 54.47% +0.03%
===========================================
Files 2275 2277 +2
Lines 50143 50146 +3
Branches 10228 10233 +5
===========================================
+ Hits 27298 27315 +17
+ Misses 20366 20346 -20
- Partials 2479 2485 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
pierre-lehnen-rc
left a comment
pierre-lehnen-rc
left a comment
Contributor
Author
There was a problem hiding this comment.
Commenting some stuff that are probably bugs in the current implementation
ggazzo
approved these changes
Mar 4, 2024
gabriellsh
added a commit
that referenced
this pull request
Mar 6, 2024
…tMarkdown * 'develop' of github.com:RocketChat/Rocket.Chat: chore: improve useJumpToMessage (#31907) feat: Add `link` action to composer toolbar (#31679) chore: replace `PaletteStyleTag` in favor of fuselage component (#31839) fix: presence for mobiles with duplicated connections (#31895) fix: New users are not automatically inserted in auto-join rooms inside default teams (#31720) fix: livechat agent status set to available after reactivation (#31651) chore: Deprecate `insertOrUpdateUser` method (#31884) chore: update ts version on recently merged package (#31885) chore: move utilitary functions out of ee folder (#31207) chore: Remove references to EE code from the app bridges (#31757) fix: Room import doesn't honor the specified owner (#31803) fix: message parser emphasis black hole (#31868) chore: remove hardcoded position for message date (#31866) feat: show date on message's scroll (#31572) chore: `RoomHeader` keyboard navigability (#31837) fix: Login page breaking when handling not expected errors (#31804)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
With the new converter type definitions, several type errors were detected - fixing them would require a breaking change on the apps-engine, so for now I added typecasts to keep the current behavior in place. I added a comment with the
#AppsEngineTypestag to all of those typecasts.To minimize the potential risk of those typecasts, I typed everything in two steps: First I assign things to a typed constant using the correct types, then I do a typecast to the type that is currently expected. For example:
This way, if the
getUserfunction signature is modified the typecast will not suppress any new type errors.