Skip to content

chore: Remove references to EE code from the app events - #31775

Merged
ggazzo merged 12 commits into
developfrom
foss/app-events
Mar 7, 2024
Merged

chore: Remove references to EE code from the app events#31775
ggazzo merged 12 commits into
developfrom
foss/app-events

Conversation

@pierre-lehnen-rc

@pierre-lehnen-rc pierre-lehnen-rc commented Feb 16, 2024

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Coded on top of #31757

@changeset-bot

changeset-bot Bot commented Feb 16, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ba8c0a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Feb 16, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 14.28571% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 54.53%. Comparing base (a011734) to head (ba8c0a4).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31775      +/-   ##
===========================================
- Coverage    54.55%   54.53%   -0.02%     
===========================================
  Files         2283     2274       -9     
  Lines        50279    50156     -123     
  Branches     10255    10236      -19     
===========================================
- Hits         27431    27355      -76     
+ Misses       20356    20317      -39     
+ Partials      2492     2484       -8     
Flag Coverage Δ
e2e 53.47% <ø> (-0.06%) ⬇️
e2e-api 40.01% <14.28%> (+0.02%) ⬆️
unit 76.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pierre-lehnen-rc
pierre-lehnen-rc marked this pull request as ready for review February 21, 2024 19:42
@pierre-lehnen-rc
pierre-lehnen-rc requested review from a team as code owners February 21, 2024 19:42
Base automatically changed from foss/apps-engine to develop March 4, 2024 17:30
@ggazzo
ggazzo requested a review from a team as a code owner March 4, 2024 17:30
@ggazzo
ggazzo merged commit a6802ca into develop Mar 7, 2024
@ggazzo
ggazzo deleted the foss/app-events branch March 7, 2024 03:50
ggazzo added a commit that referenced this pull request Mar 7, 2024
@ggazzo
ggazzo restored the foss/app-events branch March 7, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants