Skip to content

chore: remove client references to the service configurations collection - #31452

Merged
pierre-lehnen-rc merged 7 commits into
chore/refresh-oauth-servicesfrom
chore/remove-login-services-collection
Jan 18, 2024
Merged

chore: remove client references to the service configurations collection #31452
pierre-lehnen-rc merged 7 commits into
chore/refresh-oauth-servicesfrom
chore/remove-login-services-collection

Conversation

@pierre-lehnen-rc

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot

changeset-bot Bot commented Jan 15, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 951b966

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Jan 15, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 93 lines in your changes are missing coverage. Please review.

Comparison is base (bb29f64) 49.61% compared to head (208f3ef) 49.54%.

❗ Current head 208f3ef differs from pull request most recent head 951b966. Consider uploading reports for the commit 951b966 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                        @@
##           chore/refresh-oauth-services   #31452      +/-   ##
================================================================
- Coverage                         49.61%   49.54%   -0.07%     
================================================================
  Files                              3325     3329       +4     
  Lines                             81538    81661     +123     
  Branches                          16760    16789      +29     
================================================================
+ Hits                              40455    40459       +4     
- Misses                            36370    36486     +116     
- Partials                           4713     4716       +3     
Flag Coverage Δ
e2e 53.10% <32.11%> (-0.24%) ⬇️
e2e-api 40.67% <ø> (-0.01%) ⬇️
unit 76.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pierre-lehnen-rc
pierre-lehnen-rc marked this pull request as ready for review January 18, 2024 21:26
@pierre-lehnen-rc
pierre-lehnen-rc requested a review from a team as a code owner January 18, 2024 21:26
@pierre-lehnen-rc
pierre-lehnen-rc merged commit d3a59a2 into chore/refresh-oauth-services Jan 18, 2024
@pierre-lehnen-rc
pierre-lehnen-rc deleted the chore/remove-login-services-collection branch January 18, 2024 21:27
@casalsgh casalsgh added this to the 6.6 milestone Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants