Skip to content

chore: remove client references to the service configurations collection - #31515

Merged
ggazzo merged 6 commits into
developfrom
chore/login-services
Jan 23, 2024
Merged

chore: remove client references to the service configurations collection#31515
ggazzo merged 6 commits into
developfrom
chore/login-services

Conversation

@pierre-lehnen-rc

@pierre-lehnen-rc pierre-lehnen-rc commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

I'm splitting #31385 into multiple smaller PRs. This one:

  • Removes references to the ServiceConfiguration collection on the client
  • Adds a loginServices which loads the login services from the server and makes it available to the whole web client
  • Replaces OAuth code from the meteor framework with custom implementations that use the loginServices object instead of the ServiceConfiguration collection.

@changeset-bot

changeset-bot Bot commented Jan 22, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: db096a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Jan 22, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 95 lines in your changes are missing coverage. Please review.

Comparison is base (7c6198f) 49.56% compared to head (db096a9) 59.76%.
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #31515       +/-   ##
============================================
+ Coverage    49.56%   59.76%   +10.19%     
============================================
  Files         3317     1798     -1519     
  Lines        81505    35060    -46445     
  Branches     16736     7301     -9435     
============================================
- Hits         40402    20954    -19448     
+ Misses       36403    12497    -23906     
+ Partials      4700     1609     -3091     
Flag Coverage Δ
e2e 53.10% <32.62%> (-0.12%) ⬇️
e2e-api ?
unit 76.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pierre-lehnen-rc
pierre-lehnen-rc marked this pull request as ready for review January 22, 2024 18:25
@pierre-lehnen-rc
pierre-lehnen-rc requested a review from a team as a code owner January 22, 2024 18:25
Base automatically changed from chore/auth-provider to develop January 22, 2024 19:31
@ggazzo
ggazzo merged commit 0c94ea3 into develop Jan 23, 2024
@ggazzo
ggazzo deleted the chore/login-services branch January 23, 2024 16:57
@casalsgh casalsgh added this to the 6.6 milestone Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants