Skip to content

fix: SDK login methods not saving token - #31278

Merged
ggazzo merged 2 commits into
release-6.5.1from
fix/sdkAccount
Dec 19, 2023
Merged

fix: SDK login methods not saving token#31278
ggazzo merged 2 commits into
release-6.5.1from
fix/sdkAccount

Conversation

@gabriellsh

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot

changeset-bot Bot commented Dec 19, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ebdef7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/ddp-client Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/meteor Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Dec 19, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (6ba8bcc) 52.20% compared to head (1500cb5) 52.15%.

❗ Current head 1500cb5 differs from pull request most recent head ebdef7e. Consider uploading reports for the commit ebdef7e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.5.1   #31278      +/-   ##
=================================================
- Coverage          52.20%   52.15%   -0.06%     
=================================================
  Files                812      812              
  Lines              15186    15190       +4     
  Branches            2857     2857              
=================================================
- Hits                7928     7922       -6     
- Misses              6821     6829       +8     
- Partials             437      439       +2     
Flag Coverage Δ
e2e 48.64% <ø> (-0.05%) ⬇️
unit 69.61% <10.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo
ggazzo changed the base branch from develop to release-6.5.1 December 19, 2023 19:58
@ggazzo
ggazzo marked this pull request as ready for review December 19, 2023 20:01
@ggazzo
ggazzo merged commit f6a525a into release-6.5.1 Dec 19, 2023
@ggazzo
ggazzo deleted the fix/sdkAccount branch December 19, 2023 22:01
gabriellsh added a commit that referenced this pull request Dec 21, 2023
…o develop

* 'release-6.5.1' of github.com:RocketChat/Rocket.Chat:
  fix: Fix wrong callback usage on after/before user actions (#31264)
  fix: SDK login methods not saving token (#31278)
  fix: account verify email (#31227)
  fix: stop refetching banner data (#31235)
  chore: fix date operation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants