fix: Fix wrong callback usage on after/before user actions - #31264
Merged
Conversation
🦋 Changeset detectedLatest commit: ab16ded The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.5.1 #31264 +/- ##
=================================================
- Coverage 52.11% 52.10% -0.02%
=================================================
Files 812 811 -1
Lines 15190 15186 -4
Branches 2857 2857
=================================================
- Hits 7916 7912 -4
+ Misses 6835 6834 -1
- Partials 439 440 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
lmauromb
previously approved these changes
Dec 18, 2023
dionisio-bot
Bot
added
stat: ready to merge
KevLehman
marked this pull request as ready for review
December 20, 2023 13:46
dionisio-bot
Bot
added
stat: ready to merge
Member
|
please rebase to 6.5.1 branch |
KevLehman
marked this pull request as draft
December 20, 2023 14:02
KevLehman
force-pushed
the
fix/bad-after-user-callbacks
branch
from
December 20, 2023 14:11
07c1b40 to
4bed2b7
Compare
dionisio-bot
Bot
added
stat: ready to merge
dionisio-bot
Bot
added
stat: ready to merge
KevLehman
marked this pull request as ready for review
December 20, 2023 14:14
Member
Author
|
@ggazzo , there you go |
lmauromb
approved these changes
Dec 20, 2023
gabriellsh
added a commit
that referenced
this pull request
Dec 21, 2023
…o develop * 'release-6.5.1' of github.com:RocketChat/Rocket.Chat: fix: Fix wrong callback usage on after/before user actions (#31264) fix: SDK login methods not saving token (#31278) fix: account verify email (#31227) fix: stop refetching banner data (#31235) chore: fix date operation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUP-436
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments