fix: account verify email - #31227
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 938ce27 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5.1 #31227 +/- ##
=================================================
+ Coverage 46.05% 52.13% +6.08%
=================================================
Files 764 812 +48
Lines 14538 15186 +648
Branches 2762 2857 +95
=================================================
+ Hits 6695 7917 +1222
+ Misses 7457 6830 -627
- Partials 386 439 +53
Flags with carried forward coverage won't be shown. Click here to find out more. |
tassoevan
approved these changes
Dec 14, 2023
dionisio-bot
Bot
added
the
stat: ready to merge
dionisio-bot
Bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Dec 21, 2023
…o develop * 'release-6.5.1' of github.com:RocketChat/Rocket.Chat: fix: Fix wrong callback usage on after/before user actions (#31264) fix: SDK login methods not saving token (#31278) fix: account verify email (#31227) fix: stop refetching banner data (#31235) chore: fix date operation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The
Accounts.onEmailVerificationLinkandAccounts.verifyEmailwas not working as expected.The
Accounts.onEmailVerificationLinkneeds to be called in the top level of the application, but instead, it was being called thought a dynamic import.I changed to a static import and changed the behavior after the verification, now the user is being logged in after the email is verified.
Expected Behavior
The email of the newly registered user should be verified since the verification link was clicked.
Actual Behavior
The user’s email is still not verified and requires the admin to manually verify the email address from the User’s profile.
Issue(s)
fix #30890
fix #30811
fix #30668
Steps to test or reproduce
Further comments
https://rocketchat.atlassian.net/browse/SUP-414