Skip to content

fix: stop refetching banner data - #31235

Merged
ggazzo merged 2 commits into
release-6.5.1from
fix/banner-calls
Dec 14, 2023
Merged

fix: stop refetching banner data#31235
ggazzo merged 2 commits into
release-6.5.1from
fix/banner-calls

Conversation

@ggazzo

@ggazzo ggazzo commented Dec 13, 2023

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot

changeset-bot Bot commented Dec 13, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 26ca8dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ggazzo
ggazzo marked this pull request as ready for review December 13, 2023 20:40
@ggazzo
ggazzo requested a review from a team as a code owner December 13, 2023 20:40
@codecov

codecov Bot commented Dec 13, 2023

Copy link
Copy Markdown

Codecov Report

Merging #31235 (59a3fbc) into release-6.5.1 (a4c3760) will increase coverage by 0.02%.
Report is 3 commits behind head on release-6.5.1.
The diff coverage is n/a.

❗ Current head 59a3fbc differs from pull request most recent head 26ca8dc. Consider uploading reports for the commit 26ca8dc to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.5.1   #31235      +/-   ##
=================================================
+ Coverage          52.13%   52.16%   +0.02%     
=================================================
  Files                808      808              
  Lines              15169    15169              
  Branches            2852     2852              
=================================================
+ Hits                7909     7913       +4     
+ Misses              6823     6819       -4     
  Partials             437      437              
Flag Coverage Δ
e2e 48.63% <ø> (+0.03%) ⬆️
unit 69.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

tassoevan
tassoevan previously approved these changes Dec 14, 2023

@sampaiodiego sampaiodiego left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no changeset?

@ggazzo
ggazzo merged commit 68ff7e5 into release-6.5.1 Dec 14, 2023
@ggazzo
ggazzo deleted the fix/banner-calls branch December 14, 2023 20:22
@casalsgh casalsgh added this to the 6.6 milestone Dec 18, 2023
gabriellsh added a commit that referenced this pull request Dec 21, 2023
…o develop

* 'release-6.5.1' of github.com:RocketChat/Rocket.Chat:
  fix: Fix wrong callback usage on after/before user actions (#31264)
  fix: SDK login methods not saving token (#31278)
  fix: account verify email (#31227)
  fix: stop refetching banner data (#31235)
  chore: fix date operation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants