Skip to content

Conversation

@juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Sep 26, 2023

DSAR-290

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2023

⚠️ No Changeset found

Latest commit: eb49f3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #30503 (eb49f3f) into develop (8e89b5a) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30503      +/-   ##
===========================================
- Coverage    50.87%   50.77%   -0.11%     
===========================================
  Files          809      803       -6     
  Lines        15020    15014       -6     
  Branches      2729     2733       +4     
===========================================
- Hits          7642     7623      -19     
+ Misses        6969     6968       -1     
- Partials       409      423      +14     
Flag Coverage Δ
e2e 48.49% <ø> (-0.07%) ⬇️
unit 62.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti marked this pull request as ready for review September 26, 2023 23:36
@juliajforesti juliajforesti requested a review from a team as a code owner September 26, 2023 23:36
@juliajforesti juliajforesti changed the title fix: update mentions upsell modal content chore: update mentions upsell modal content Oct 4, 2023
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 4, 2023
@dougfabris dougfabris added this to the 6.5.0 milestone Oct 4, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 4, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 4, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 4, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 4, 2023
@kodiakhq kodiakhq bot merged commit 9aee190 into develop Oct 4, 2023
@kodiakhq kodiakhq bot deleted the fix/mentions-upsell-modal branch October 4, 2023 22:51
gabriellsh added a commit that referenced this pull request Oct 6, 2023
…t into improve/ui-caching

* 'improve/ui-caching' of github.com:RocketChat/Rocket.Chat: (40 commits)
  Update .changeset/wicked-humans-hang.md
  feat: Save visitor's activity on agent's interaction (#30222)
  chore: update mentions upsell modal content (#30503)
  fix: font-disabled color (#30569)
  chore: anchor text-decoration rules (#30485)
  chore: `AccessibilityPage` hide Enterprise tag when is EE (#30486)
  chore: Replace `Field.[SUBCOMPONENT]` in favor of named imports (#30501)
  fix: Check for room scoped permissions for creating discussions (#30497)
  ci: fix Docker image build for production (#30562)
  chore: Fix triggers flaky tests (#30530)
  chore: get translations from CDN (#30331)
  feat: new `licenses.info` endpoint (#30473)
  ci: run tests from forks (#30556)
  regression: unmarked dangling promise on license validation (#30557)
  regression: fix initializing startup order (#30555)
  feat: push notification statistics (#30269)
  chore: do not focus messagebox on mobile devices (#30553)
  chore: add the new endpoints to sync with cloud (#30546)
  fix: in forward search field, user cannot be found by name (Full Name) (#29663)
  chore: set license public key v3 with v2 (#30548)
  ...
gabriellsh added a commit that referenced this pull request Oct 9, 2023
…/mentionBot

* 'develop' of github.com:RocketChat/Rocket.Chat: (68 commits)
  fix: don't save the filter value on offlineMessageChannelName (#30576)
  feat: New permission to kick users (#30535)
  chore: improve message link focus (#30578)
  chore: Add required visual indication on `EditRoom` name input (#30589)
  fix: user dropdown menu position on RTL layout (#30490)
  chore: add missing `_id` field to `AtLeast` (#30592)
  test: Improve tests for legacy omnichannel analytics  (#30379)
  fix: Remove monitors query restrictions on update (#30550)
  chore: license v3 invalidation (#30585)
  chore: `CreateDirectMessage` a11y form improvements (#30581)
  chore: `CreateDiscussion` a11y improvements (#30583)
  chore: License v3 - behavior and limited reached triggers (#30561)
  chore: Improve `groups.create` endpoint for large amounts of members (#30499)
  feat: Monitors able to forward chats without joining (#30549)
  feat: Deployment Fingerprint (#30411)
  chore: fix flaky agents & custom fields tables tests (#30580)
  feat: Save visitor's activity on agent's interaction (#30222)
  chore: update mentions upsell modal content (#30503)
  fix: font-disabled color (#30569)
  chore: anchor text-decoration rules (#30485)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants