Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Oct 5, 2023

Proposed changes (including videos or screenshots)

It also replaces useEndpointAction in favor of useQuery on DefaultParentRoomField

Issue(s)

Steps to test or reproduce

Further comments

DSAR-278

@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2023

⚠️ No Changeset found

Latest commit: f1ae41d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 6.5.0 milestone Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #30583 (f1ae41d) into develop (9aee190) will increase coverage by 0.09%.
Report is 24 commits behind head on develop.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30583      +/-   ##
===========================================
+ Coverage    50.87%   50.97%   +0.09%     
===========================================
  Files          809      803       -6     
  Lines        15020    15004      -16     
  Branches      2729     2731       +2     
===========================================
+ Hits          7642     7648       +6     
+ Misses        6969     6933      -36     
- Partials       409      423      +14     
Flag Coverage Δ
e2e 48.69% <ø> (+0.13%) ⬆️
unit 62.78% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review October 6, 2023 00:11
@dougfabris dougfabris requested a review from a team as a code owner October 6, 2023 00:11
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 6, 2023
@ggazzo ggazzo changed the title chore: CreateDiscussion a11y improves chore: CreateDiscussion a11y improvements Oct 6, 2023
@ggazzo ggazzo merged commit 0a33551 into develop Oct 6, 2023
@ggazzo ggazzo deleted the chore/discussion-improves branch October 6, 2023 16:24
gabriellsh added a commit that referenced this pull request Oct 6, 2023
…ove/ui-caching

* 'develop' of github.com:RocketChat/Rocket.Chat:
  fix: Remove monitors query restrictions on update (#30550)
  chore: license v3 invalidation (#30585)
  chore: `CreateDirectMessage` a11y form improvements (#30581)
  chore: `CreateDiscussion` a11y improvements (#30583)
  chore: License v3 - behavior and limited reached triggers (#30561)
  chore: Improve `groups.create` endpoint for large amounts of members (#30499)
  feat: Monitors able to forward chats without joining (#30549)
  feat: Deployment Fingerprint (#30411)
  chore: fix flaky agents & custom fields tables tests (#30580)
gabriellsh added a commit that referenced this pull request Oct 9, 2023
…/mentionBot

* 'develop' of github.com:RocketChat/Rocket.Chat: (68 commits)
  fix: don't save the filter value on offlineMessageChannelName (#30576)
  feat: New permission to kick users (#30535)
  chore: improve message link focus (#30578)
  chore: Add required visual indication on `EditRoom` name input (#30589)
  fix: user dropdown menu position on RTL layout (#30490)
  chore: add missing `_id` field to `AtLeast` (#30592)
  test: Improve tests for legacy omnichannel analytics  (#30379)
  fix: Remove monitors query restrictions on update (#30550)
  chore: license v3 invalidation (#30585)
  chore: `CreateDirectMessage` a11y form improvements (#30581)
  chore: `CreateDiscussion` a11y improvements (#30583)
  chore: License v3 - behavior and limited reached triggers (#30561)
  chore: Improve `groups.create` endpoint for large amounts of members (#30499)
  feat: Monitors able to forward chats without joining (#30549)
  feat: Deployment Fingerprint (#30411)
  chore: fix flaky agents & custom fields tables tests (#30580)
  feat: Save visitor's activity on agent's interaction (#30222)
  chore: update mentions upsell modal content (#30503)
  fix: font-disabled color (#30569)
  chore: anchor text-decoration rules (#30485)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants