-
Notifications
You must be signed in to change notification settings - Fork 13.1k
chore: Replace Field.[SUBCOMPONENT] in favor of named imports
#30501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov Report
@@ Coverage Diff @@
## develop #30501 +/- ##
===========================================
- Coverage 50.87% 50.71% -0.16%
===========================================
Files 809 803 -6
Lines 15020 15014 -6
Branches 2729 2733 +4
===========================================
- Hits 7642 7615 -27
- Misses 6969 6977 +8
- Partials 409 422 +13
Flags with carried forward coverage won't be shown. Click here to find out more. |
Field.[SUBCOMPONENT] in favor of named importsField.[SUBCOMPONENT] in favor of named imports
Field.[SUBCOMPONENT] in favor of named importsField.[SUBCOMPONENT] in favor of named imports
dougfabris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…t into improve/ui-caching * 'improve/ui-caching' of github.com:RocketChat/Rocket.Chat: (40 commits) Update .changeset/wicked-humans-hang.md feat: Save visitor's activity on agent's interaction (#30222) chore: update mentions upsell modal content (#30503) fix: font-disabled color (#30569) chore: anchor text-decoration rules (#30485) chore: `AccessibilityPage` hide Enterprise tag when is EE (#30486) chore: Replace `Field.[SUBCOMPONENT]` in favor of named imports (#30501) fix: Check for room scoped permissions for creating discussions (#30497) ci: fix Docker image build for production (#30562) chore: Fix triggers flaky tests (#30530) chore: get translations from CDN (#30331) feat: new `licenses.info` endpoint (#30473) ci: run tests from forks (#30556) regression: unmarked dangling promise on license validation (#30557) regression: fix initializing startup order (#30555) feat: push notification statistics (#30269) chore: do not focus messagebox on mobile devices (#30553) chore: add the new endpoints to sync with cloud (#30546) fix: in forward search field, user cannot be found by name (Full Name) (#29663) chore: set license public key v3 with v2 (#30548) ...
Proposed changes (including videos or screenshots)
replace deprecated Field assigned subcomponents:
Field.Group->FieldGroupField.Hint->FieldHintField.Label->FieldLabelField.Row->FieldRowIssue(s)
Steps to test or reproduce
Further comments