-
Notifications
You must be signed in to change notification settings - Fork 13.1k
feat: push notification statistics #30269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 2677e27 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #30269 +/- ##
===========================================
- Coverage 50.92% 50.76% -0.17%
===========================================
Files 809 808 -1
Lines 15005 15031 +26
Branches 2723 2733 +10
===========================================
- Hits 7642 7631 -11
- Misses 6954 6978 +24
- Partials 409 422 +13
Flags with carried forward coverage won't be shown. Click here to find out more. |
sampaiodiego
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regarding the reasoning behind the need to have this information added to the statistics, I do think it makes more sense to track Push_enable_gateway than if the gateway was changed or not.. because usually people will either use our apps with our gateway or change do not use our gateway with their own mobile apps.
and since we've been adding too much information to the statistics recently, I'd like to encourage some thinking on how to improve it.. for example, if we're tracking many different push related settings, maybe we can use a binary value? like:
we want to track 3 different settings, each one of them receives receives a bit:
1 1 1
| | |
| | +- push enabled = 0b1 =
| +--- push gateway enabled = 0b10 = 2
+----- push gateway changed = 0b100 = 4
this way we could have a single value sent to the statistics using bitwise operators, like this:
const pushEnabled = settings.get('Push_enable') ? 1 : 0;
const pushGatewayEnabled = settings.get('Push_enable_gateway') ? 2 : 0;
const gatewayChanged = hasGatewayChanged() ? 4 : 0;
statistics.push = pushEnabled | pushGatewayEnabled | gatewayChanged;just an idea I think we should consider =)
…t into improve/ui-caching * 'improve/ui-caching' of github.com:RocketChat/Rocket.Chat: (40 commits) Update .changeset/wicked-humans-hang.md feat: Save visitor's activity on agent's interaction (#30222) chore: update mentions upsell modal content (#30503) fix: font-disabled color (#30569) chore: anchor text-decoration rules (#30485) chore: `AccessibilityPage` hide Enterprise tag when is EE (#30486) chore: Replace `Field.[SUBCOMPONENT]` in favor of named imports (#30501) fix: Check for room scoped permissions for creating discussions (#30497) ci: fix Docker image build for production (#30562) chore: Fix triggers flaky tests (#30530) chore: get translations from CDN (#30331) feat: new `licenses.info` endpoint (#30473) ci: run tests from forks (#30556) regression: unmarked dangling promise on license validation (#30557) regression: fix initializing startup order (#30555) feat: push notification statistics (#30269) chore: do not focus messagebox on mobile devices (#30553) chore: add the new endpoints to sync with cloud (#30546) fix: in forward search field, user cannot be found by name (Full Name) (#29663) chore: set license public key v3 with v2 (#30548) ...
Co-authored-by: Matheus Barbosa Silva <[email protected]>
Proposed changes (including videos or screenshots)
Added statistic
push, which is a number (int) with three bits representing booleans, following the structure:Issue(s)
Steps to test or reproduce
Further comments
TC-875