Skip to content

[IMPROVE] Request user presence on demand #16348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sampaiodiego merged 13 commits into from
Feb 4, 2020
Merged

[IMPROVE] Request user presence on demand #16348

sampaiodiego merged 13 commits into from
Feb 4, 2020

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Jan 28, 2020

No description provided.

@ggazzo ggazzo added this to the 3.0.0 milestone Jan 28, 2020
ggazzo and others added 3 commits January 29, 2020 09:58
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into user…
9f2c8b3 
…-presence-lazy

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Role tags missing - Description field explanation (#16356)
  Regression: Rate limiter was not working due to Meteor internal changes (#16361)
  [FIX] Invite links usage by channel owners/moderators (#16176)
  Fix assets download on CI (#16352)
  Regression: Fix set name to alias validation (#16347)
  Send build artifacts to S3 (#16237)
  [NEW] Create a user for the Apps during installation (#15896)
@ggazzo
handle reconnect
873f72a
@sampaiodiego
Merge branch 'develop' into user-presence-lazy
06a380a
sampaiodiego
sampaiodiego requested changes Feb 3, 2020
View reviewed changes
@ggazzo ggazzo changed the title [WIP] Get presence on demand [IMPROVE] Get presence on demand Feb 3, 2020
ggazzo and others added 6 commits February 3, 2020 20:05
@ggazzo
lint
d6f7d74
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into user…
03fe860 
…-presence-lazy

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Fix sending a message not scrolling to bottom (#16451)
  LingoHub based on develop (#16450)
  [IMPROVE] Changes App user's status when the app was enabled/disabled (#16392)
  [IMPROVE] Log as info level when Method Rate Limiters are reached (#16446)
  Use GitHub Actions to store builds (#16443)
  [NEW] Sort the Omnichannel Chat list according to the user preferences (#16437)
  Regression: recent opened rooms being marked as read (#16442)
  [FIX] Option to make a channel default  (#16433)
  [NEW] Setting to only send plain text emails (#16065)
  fix group
  Regression: Fix status bar margins (#16438)
  [NEW] Check the Omnichannel service status per Department (#16425)
  [IMPROVE] Show more information related to the Omnichannel room closing data (#16414)
  Fix index creation for apps_logs collection (#16401)
  Revert message properties validation (#16395)
  [FIX] Rooms not being marked as read sometimes (#16397)
  Update apps engine to 1.12.0-beta.2496 (#16398)
  [FIX] Container heights (#16388)
  fix group messages
@ggazzo
try to fix reconection
58e5470
@sampaiodiego
Merge remote-tracking branch 'origin/develop' into user-presence-lazy
adfbaf7
@sampaiodiego
Reset observers after reconnection
d55f3d4
@sampaiodiego
Fix user searches
3379bab
@sampaiodiego sampaiodiego changed the title [IMPROVE] Get presence on demand [IMPROVE] Request user presence on demand Feb 4, 2020
@sampaiodiego sampaiodiego merged commit ebda5ea into develop Feb 4, 2020
@sampaiodiego sampaiodiego deleted the user-presence-lazy branch February 4, 2020 21:13
gabriellsh added a commit that referenced this pull request Feb 5, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
5623364 
…default-favorite-channels

* 'develop' of github.com:RocketChat/Rocket.Chat: (27 commits)
  [FIX] Missing edited icon in newly created messages (#16484)
  Regression: allow private channels to hide system messages  (#16483)
  Regression: Fix uikit modal closing on click (#16475)
  Regression: Fix undefined presence after reconnect (#16477)
  [FIX] Read Message after receive a message and the room is opened (#16473)
  [FIX] Send message with pending messages (#16474)
  Fix tests (#16469)
  Bump version to 3.0.0-develop
  [NEW] Button to download admin server info (#16059)
  Revert importer streamed uploads (#16465)
  [NEW] UiKit - Interactive UI elements for Rocket.Chat Apps (#16048)
  [FIX] Result of get avatar from url can be null (#16123)
  [IMPROVE] Request user presence on demand (#16348)
  [IMPROVE] Major overhaul on data importers (#16279)
  [BREAK] Filter System messages per room (#16369)
  Regression: Fix app user status change for non-existing user (#16458)
  [FIX] `stdout` streamer infinite loop (#16452)
  Regression: Fix sending a message not scrolling to bottom (#16451)
  LingoHub based on develop (#16450)
  [IMPROVE] Changes App user's status when the app was enabled/disabled (#16392)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Feb 15, 2020
Merged
@ankar84
Copy link

ankar84 commented Feb 28, 2020

I learned about such an important innovation only from the YouTube video (so thankful for that!)
I am sure that such extremely important changes require descriptions that are as detailed as possible.
Thanks a lot, anyway!

@ankar84 ankar84 mentioned this pull request Mar 17, 2020
Closed
@EionRobb
Copy link

EionRobb commented Mar 20, 2020

Is there any way a client can subscribe to status changes after this change, or is it now completely polling-only?

@emikolajczak
Copy link

emikolajczak commented Apr 2, 2020

Hi
I have a question about parameter DISABLE_PRESENCE_MONITOR and this change in presence monitor.
Will statuses show correctly when I set DISABLE_PRESENCE_MONITOR on true.
I am asking beacues set DISABLE_PRESENCE_MONITOR on true cause lower CPU load and better performance of Rocket.Chat.

@sampaiodiego
Copy link
Member

sampaiodiego commented Apr 2, 2020

they're not entirely related.. DISABLE_PRESENCE_MONITOR will prevent rocket.chat instances from monitoring (an updating) users's presence status.. while this PR just change how the client requests users' status from server.

in other words, if you use DISABLE_PRESENCE_MONITOR on all rocket.chat instances, all your users will appear as offline.

@ggazzo
Copy link
Member Author

ggazzo commented Apr 14, 2020

Is there any way a client can subscribe to status changes after this change, or is it now completely polling-only?

the realtime data still arrives from stream-notify-logged "eventName":"user-status" we just changed how much info we loaded by the first time

@codeneno
Copy link

codeneno commented Jun 19, 2020

@ggazzo does this work on 2.4.12?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@ggazzo @ankar84 @EionRobb @emikolajczak @sampaiodiego @codeneno