[FIX] Invite links usage by channel owners/moderators #16176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigok
requested changes
Jan 10, 2020
| // If the user already has an username, then join the invite room, | ||
| // If no username is set yet, then the the join will happen on the setUsername method | ||
| if (user.username) { | ||
| addUserToRoom(room._id, user); |
Member
There was a problem hiding this comment.
Only need to save the token in the user (or add a list of rooms to join as my previous suggestion) on else here.
Contributor
Author
There was a problem hiding this comment.
We thought this could be useful information for statistics at some point, so I'm storing the token to every registered user.
sampaiodiego
requested changes
Jan 14, 2020
Co-Authored-By: Diego Sampaio <[email protected]>
|
This pull request introduces 1 alert when merging 6d78012 into b577095 - view on LGTM.com new alerts:
|
sampaiodiego
changed the title
8 tasks
sampaiodiego
approved these changes
Jan 28, 2020
sampaiodiego
pushed a commit
that referenced
this pull request
Jan 28, 2020
Merged
ggazzo
added a commit
that referenced
this pull request
Jan 29, 2020
…-system-messages * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] Role tags missing - Description field explanation (#16356) Regression: Rate limiter was not working due to Meteor internal changes (#16361) [FIX] Invite links usage by channel owners/moderators (#16176) Fix assets download on CI (#16352) Regression: Fix set name to alias validation (#16347) Send build artifacts to S3 (#16237) [NEW] Create a user for the Apps during installation (#15896) Add missing translations (#16150) fix slack cvs user importer (#16253) [FIX] The "click to load" text is hard-coded and not translated. (#16142) [FIX] Integrations list without pagination and outgoing integration creation (#16233)
ggazzo
added a commit
that referenced
this pull request
Jan 29, 2020
…-presence-lazy * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] Role tags missing - Description field explanation (#16356) Regression: Rate limiter was not working due to Meteor internal changes (#16361) [FIX] Invite links usage by channel owners/moderators (#16176) Fix assets download on CI (#16352) Regression: Fix set name to alias validation (#16347) Send build artifacts to S3 (#16237) [NEW] Create a user for the Apps during installation (#15896)
ggazzo
added a commit
that referenced
this pull request
Jan 30, 2020
…it.2.0-turbo * 'develop' of github.com:RocketChat/Rocket.Chat: [BREAK] Hide system messages (#16243) [IMPROVE] Prevent "App user" from being deleted by the admin (#16373) [FIX] Adding 'lang' tag (#16375) Lint: Resolve complexity warnings (#16114) Fix Preview Docker image (#16379) [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252) [FIX] App removal was moving logs to the trash collection (#16362) [FIX] Role tags missing - Description field explanation (#16356) Regression: Rate limiter was not working due to Meteor internal changes (#16361) [FIX] Invite links usage by channel owners/moderators (#16176) Fix assets download on CI (#16352) Regression: Fix set name to alias validation (#16347) Send build artifacts to S3 (#16237) [NEW] Create a user for the Apps during installation (#15896) Add missing translations (#16150) fix slack cvs user importer (#16253) [FIX] The "click to load" text is hard-coded and not translated. (#16142)
gabriellsh
added a commit
that referenced
this pull request
Jan 31, 2020
…email-validation-message * 'develop' of github.com:RocketChat/Rocket.Chat: (22 commits) [IMPROVE] Update katex version (#16393) [FIX] Mail Msg Cancel button not closing the flexbar (#16263) [FIX] Highlight freezing the UI (#16378) [BREAK] Hide system messages (#16243) [IMPROVE] Prevent "App user" from being deleted by the admin (#16373) [FIX] Adding 'lang' tag (#16375) Lint: Resolve complexity warnings (#16114) Fix Preview Docker image (#16379) [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252) [FIX] App removal was moving logs to the trash collection (#16362) [FIX] Role tags missing - Description field explanation (#16356) Regression: Rate limiter was not working due to Meteor internal changes (#16361) [FIX] Invite links usage by channel owners/moderators (#16176) Fix assets download on CI (#16352) Regression: Fix set name to alias validation (#16347) Send build artifacts to S3 (#16237) [NEW] Create a user for the Apps during installation (#15896) Add missing translations (#16150) fix slack cvs user importer (#16253) [FIX] The "click to load" text is hard-coded and not translated. (#16142) ...
gabriellsh
added a commit
that referenced
this pull request
Jan 31, 2020
…pinned_messages_collapse * 'develop' of github.com:RocketChat/Rocket.Chat: [IMPROVE] Update katex version (#16393) [FIX] Mail Msg Cancel button not closing the flexbar (#16263) [FIX] Highlight freezing the UI (#16378) [BREAK] Hide system messages (#16243) [IMPROVE] Prevent "App user" from being deleted by the admin (#16373) [FIX] Adding 'lang' tag (#16375) Lint: Resolve complexity warnings (#16114) Fix Preview Docker image (#16379) [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252) [FIX] App removal was moving logs to the trash collection (#16362) [FIX] Role tags missing - Description field explanation (#16356) Regression: Rate limiter was not working due to Meteor internal changes (#16361) [FIX] Invite links usage by channel owners/moderators (#16176) Fix assets download on CI (#16352) Regression: Fix set name to alias validation (#16347) Send build artifacts to S3 (#16237) [NEW] Create a user for the Apps during installation (#15896) Add missing translations (#16150) fix slack cvs user importer (#16253)
ggazzo
added a commit
that referenced
this pull request
Feb 3, 2020
…nto system-messages * 'system-messages' of github.com:RocketChat/Rocket.Chat: [BREAK] Hide system messages (#16243) [IMPROVE] Prevent "App user" from being deleted by the admin (#16373) [FIX] Adding 'lang' tag (#16375) Lint: Resolve complexity warnings (#16114) Fix Preview Docker image (#16379) [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252) [FIX] App removal was moving logs to the trash collection (#16362) [FIX] Role tags missing - Description field explanation (#16356) Regression: Rate limiter was not working due to Meteor internal changes (#16361) [FIX] Invite links usage by channel owners/moderators (#16176) Fix assets download on CI (#16352)
igit-cn
added a commit
to igit-cn/Rocket.Chat
that referenced
this pull request
Mar 20, 2020
Invite links usage by channel owners/moderators (RocketChat#16176)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #16242 (comment)