[NEW] Check the Omnichannel service status per Department #16425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
Hi! @renatobecker I've modified the bridge method and created a PR on apps-engine side. Let me know if there is something to improve, thanks! |
sampaiodiego
added
the
documentation: needed
sampaiodiego
approved these changes
Feb 3, 2020
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
@renatobecker can you please update the documentation?
Contributor
Author
@sampaiodiego, sure thing! |
gabriellsh
added a commit
that referenced
this pull request
Feb 3, 2020
…exact_search * 'develop' of github.com:RocketChat/Rocket.Chat: [NEW] Check the Omnichannel service status per Department (#16425) [IMPROVE] Show more information related to the Omnichannel room closing data (#16414) Fix index creation for apps_logs collection (#16401) Revert message properties validation (#16395) [FIX] Rooms not being marked as read sometimes (#16397) Update apps engine to 1.12.0-beta.2496 (#16398) [FIX] Container heights (#16388) Regression: App deletion wasn’t returning the correct information (#16360) [BREAK] Remove deprecated publications (#16351) [IMPROVE] Update katex version (#16393) [FIX] Mail Msg Cancel button not closing the flexbar (#16263) [FIX] Highlight freezing the UI (#16378)
gabriellsh
added a commit
that referenced
this pull request
Feb 3, 2020
…pinned_messages_collapse * 'develop' of github.com:RocketChat/Rocket.Chat: [NEW] Check the Omnichannel service status per Department (#16425) [IMPROVE] Show more information related to the Omnichannel room closing data (#16414) Fix index creation for apps_logs collection (#16401) Revert message properties validation (#16395) [FIX] Rooms not being marked as read sometimes (#16397) Update apps engine to 1.12.0-beta.2496 (#16398) [FIX] Container heights (#16388) Regression: App deletion wasn’t returning the correct information (#16360) [BREAK] Remove deprecated publications (#16351)
sampaiodiego
pushed a commit
that referenced
this pull request
Feb 3, 2020
* Allow to check the service status per department. * update livechat bridge method isOnline Co-authored-by: Shiqi Mei <[email protected]>
ggazzo
added a commit
that referenced
this pull request
Feb 3, 2020
…readmessages * 'develop' of github.com:RocketChat/Rocket.Chat: [NEW] Setting to only send plain text emails (#16065) Regression: Fix status bar margins (#16438) [NEW] Check the Omnichannel service status per Department (#16425) [IMPROVE] Show more information related to the Omnichannel room closing data (#16414) Fix index creation for apps_logs collection (#16401) Revert message properties validation (#16395) [FIX] Rooms not being marked as read sometimes (#16397) Update apps engine to 1.12.0-beta.2496 (#16398) [FIX] Container heights (#16388) Regression: App deletion wasn’t returning the correct information (#16360)
gabriellsh
added a commit
that referenced
this pull request
Feb 3, 2020
…default-favorite-channels * 'develop' of github.com:RocketChat/Rocket.Chat: (46 commits) Regression: Fix status bar margins (#16438) [NEW] Check the Omnichannel service status per Department (#16425) [IMPROVE] Show more information related to the Omnichannel room closing data (#16414) Fix index creation for apps_logs collection (#16401) Revert message properties validation (#16395) [FIX] Rooms not being marked as read sometimes (#16397) Update apps engine to 1.12.0-beta.2496 (#16398) [FIX] Container heights (#16388) Regression: App deletion wasn’t returning the correct information (#16360) [BREAK] Remove deprecated publications (#16351) [IMPROVE] Update katex version (#16393) [FIX] Mail Msg Cancel button not closing the flexbar (#16263) [FIX] Highlight freezing the UI (#16378) [BREAK] Hide system messages (#16243) [IMPROVE] Prevent "App user" from being deleted by the admin (#16373) [FIX] Adding 'lang' tag (#16375) Lint: Resolve complexity warnings (#16114) Fix Preview Docker image (#16379) [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252) [FIX] App removal was moving logs to the trash collection (#16362) ...
d-gubert
pushed a commit
that referenced
this pull request
Feb 4, 2020
* Allow to check the service status per department. * update livechat bridge method isOnline Co-authored-by: Shiqi Mei <[email protected]>
ggazzo
added a commit
that referenced
this pull request
Feb 4, 2020
…-presence-lazy * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Fix sending a message not scrolling to bottom (#16451) LingoHub based on develop (#16450) [IMPROVE] Changes App user's status when the app was enabled/disabled (#16392) [IMPROVE] Log as info level when Method Rate Limiters are reached (#16446) Use GitHub Actions to store builds (#16443) [NEW] Sort the Omnichannel Chat list according to the user preferences (#16437) Regression: recent opened rooms being marked as read (#16442) [FIX] Option to make a channel default (#16433) [NEW] Setting to only send plain text emails (#16065) fix group Regression: Fix status bar margins (#16438) [NEW] Check the Omnichannel service status per Department (#16425) [IMPROVE] Show more information related to the Omnichannel room closing data (#16414) Fix index creation for apps_logs collection (#16401) Revert message properties validation (#16395) [FIX] Rooms not being marked as read sometimes (#16397) Update apps engine to 1.12.0-beta.2496 (#16398) [FIX] Container heights (#16388) fix group messages
ggazzo
added a commit
that referenced
this pull request
Feb 4, 2020
…into ui-kit.2.0-turbo * 'ui-kit.2.0-turbo' of github.com:RocketChat/Rocket.Chat: Remove npm Update with error messages [IMPROVE] Log as info level when Method Rate Limiters are reached (#16446) Use GitHub Actions to store builds (#16443) [NEW] Sort the Omnichannel Chat list according to the user preferences (#16437) Regression: recent opened rooms being marked as read (#16442) [FIX] Option to make a channel default (#16433) [NEW] Setting to only send plain text emails (#16065) Regression: Fix status bar margins (#16438) [NEW] Check the Omnichannel service status per Department (#16425) [IMPROVE] Show more information related to the Omnichannel room closing data (#16414) fix close modals Update action trigger format typo
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows checking the Omnichannel service status(online/offline) per Department.
Currently, the
Livechat.online()method doesn't allow to pass any department to check the status of the service, so it's possible to start a new conversation associated with a specific Department that has no online agents, which provides a very bad user experience.This change will also have an impact on Apps-Engine, we need to change it to be able to check the status of the Omnichannel service through an App too.
In addition: I have created an issue on the
Apps-Enginerepo, describing this case.