[IMPROVE] Changes App user's status when the app was enabled/disabled #16392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaiodiego
requested changes
Jan 31, 2020
* add Users.findOneByAppId * add Users.updateStatusById It's always a good practice to move all db operations/query into models.
Contributor
Author
|
@sampaiodiego Thanks! |
sampaiodiego
requested changes
Jan 31, 2020
Co-Authored-By: Diego Sampaio <[email protected]>
sampaiodiego
approved these changes
Feb 3, 2020
ggazzo
added a commit
that referenced
this pull request
Feb 4, 2020
…-presence-lazy * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Fix sending a message not scrolling to bottom (#16451) LingoHub based on develop (#16450) [IMPROVE] Changes App user's status when the app was enabled/disabled (#16392) [IMPROVE] Log as info level when Method Rate Limiters are reached (#16446) Use GitHub Actions to store builds (#16443) [NEW] Sort the Omnichannel Chat list according to the user preferences (#16437) Regression: recent opened rooms being marked as read (#16442) [FIX] Option to make a channel default (#16433) [NEW] Setting to only send plain text emails (#16065) fix group Regression: Fix status bar margins (#16438) [NEW] Check the Omnichannel service status per Department (#16425) [IMPROVE] Show more information related to the Omnichannel room closing data (#16414) Fix index creation for apps_logs collection (#16401) Revert message properties validation (#16395) [FIX] Rooms not being marked as read sometimes (#16397) Update apps engine to 1.12.0-beta.2496 (#16398) [FIX] Container heights (#16388) fix group messages
gabriellsh
added a commit
that referenced
this pull request
Feb 4, 2020
…pinned_messages_collapse * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] `stdout` streamer infinite loop (#16452) Regression: Fix sending a message not scrolling to bottom (#16451) LingoHub based on develop (#16450) [IMPROVE] Changes App user's status when the app was enabled/disabled (#16392) [IMPROVE] Log as info level when Method Rate Limiters are reached (#16446) Use GitHub Actions to store builds (#16443) [NEW] Sort the Omnichannel Chat list according to the user preferences (#16437) Regression: recent opened rooms being marked as read (#16442) [FIX] Option to make a channel default (#16433) [NEW] Setting to only send plain text emails (#16065) fix group Regression: Fix status bar margins (#16438) fix group messages
ggazzo
added a commit
that referenced
this pull request
Feb 4, 2020
…it.2.0-turbo * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Fix app user status change for non-existing user (#16458) [FIX] `stdout` streamer infinite loop (#16452) Regression: Fix sending a message not scrolling to bottom (#16451) LingoHub based on develop (#16450) [IMPROVE] Changes App user's status when the app was enabled/disabled (#16392) [IMPROVE] Log as info level when Method Rate Limiters are reached (#16446) Use GitHub Actions to store builds (#16443) [NEW] Sort the Omnichannel Chat list according to the user preferences (#16437) Regression: recent opened rooms being marked as read (#16442) [FIX] Option to make a channel default (#16433) [NEW] Setting to only send plain text emails (#16065) Regression: Fix status bar margins (#16438)
gabriellsh
added a commit
that referenced
this pull request
Feb 5, 2020
…default-favorite-channels * 'develop' of github.com:RocketChat/Rocket.Chat: (27 commits) [FIX] Missing edited icon in newly created messages (#16484) Regression: allow private channels to hide system messages (#16483) Regression: Fix uikit modal closing on click (#16475) Regression: Fix undefined presence after reconnect (#16477) [FIX] Read Message after receive a message and the room is opened (#16473) [FIX] Send message with pending messages (#16474) Fix tests (#16469) Bump version to 3.0.0-develop [NEW] Button to download admin server info (#16059) Revert importer streamed uploads (#16465) [NEW] UiKit - Interactive UI elements for Rocket.Chat Apps (#16048) [FIX] Result of get avatar from url can be null (#16123) [IMPROVE] Request user presence on demand (#16348) [IMPROVE] Major overhaul on data importers (#16279) [BREAK] Filter System messages per room (#16369) Regression: Fix app user status change for non-existing user (#16458) [FIX] `stdout` streamer infinite loop (#16452) Regression: Fix sending a message not scrolling to bottom (#16451) LingoHub based on develop (#16450) [IMPROVE] Changes App user's status when the app was enabled/disabled (#16392) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to make the app user's status sync with its app's status ( '*_enabled' -> 'online'; other status -> 'offline').