Skip to content

Conversation

@dudizilla
Copy link
Contributor

@dudizilla dudizilla commented Jan 28, 2020

Closes #16350

image

Adding an alert that explains 'if you let the description field blank, the role will not be shown

@ggazzo ggazzo requested a review from mar-v January 28, 2020 16:47
@ggazzo ggazzo added this to the 3.0.0 milestone Jan 28, 2020
@ggazzo ggazzo added the area: ui Touches the code on client side label Jan 28, 2020
@ggazzo ggazzo changed the title [FIX] Role tags missing [FIX] Role tags missing - Description field explanation Jan 29, 2020
@ggazzo ggazzo merged commit 0ddecc7 into develop Jan 29, 2020
ggazzo added a commit that referenced this pull request Jan 29, 2020
…-system-messages

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Role tags missing - Description field explanation (#16356)
  Regression: Rate limiter was not working due to Meteor internal changes (#16361)
  [FIX] Invite links usage by channel owners/moderators (#16176)
  Fix assets download on CI (#16352)
  Regression: Fix set name to alias validation (#16347)
  Send build artifacts to S3 (#16237)
  [NEW] Create a user for the Apps during installation (#15896)
  Add missing translations (#16150)
  fix slack cvs user importer (#16253)
  [FIX] The "click to load" text is hard-coded and not translated. (#16142)
  [FIX] Integrations list without pagination and outgoing integration creation (#16233)
ggazzo added a commit that referenced this pull request Jan 29, 2020
…-presence-lazy

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Role tags missing - Description field explanation (#16356)
  Regression: Rate limiter was not working due to Meteor internal changes (#16361)
  [FIX] Invite links usage by channel owners/moderators (#16176)
  Fix assets download on CI (#16352)
  Regression: Fix set name to alias validation (#16347)
  Send build artifacts to S3 (#16237)
  [NEW] Create a user for the Apps during installation (#15896)
ggazzo added a commit that referenced this pull request Jan 30, 2020
…it.2.0-turbo

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [BREAK] Hide system messages (#16243)
  [IMPROVE] Prevent "App user" from being deleted by the admin (#16373)
  [FIX] Adding 'lang' tag (#16375)
  Lint: Resolve complexity warnings (#16114)
  Fix Preview Docker image (#16379)
  [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252)
  [FIX] App removal was moving logs to the trash collection (#16362)
  [FIX] Role tags missing - Description field explanation (#16356)
  Regression: Rate limiter was not working due to Meteor internal changes (#16361)
  [FIX] Invite links usage by channel owners/moderators (#16176)
  Fix assets download on CI (#16352)
  Regression: Fix set name to alias validation (#16347)
  Send build artifacts to S3 (#16237)
  [NEW] Create a user for the Apps during installation (#15896)
  Add missing translations (#16150)
  fix slack cvs user importer (#16253)
  [FIX] The "click to load" text is hard-coded and not translated. (#16142)
gabriellsh added a commit that referenced this pull request Jan 31, 2020
…email-validation-message

* 'develop' of github.com:RocketChat/Rocket.Chat: (22 commits)
  [IMPROVE] Update katex version  (#16393)
  [FIX] Mail Msg Cancel button not closing the flexbar (#16263)
  [FIX] Highlight freezing the UI (#16378)
  [BREAK] Hide system messages (#16243)
  [IMPROVE] Prevent "App user" from being deleted by the admin (#16373)
  [FIX] Adding 'lang' tag (#16375)
  Lint: Resolve complexity warnings (#16114)
  Fix Preview Docker image (#16379)
  [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252)
  [FIX] App removal was moving logs to the trash collection (#16362)
  [FIX] Role tags missing - Description field explanation (#16356)
  Regression: Rate limiter was not working due to Meteor internal changes (#16361)
  [FIX] Invite links usage by channel owners/moderators (#16176)
  Fix assets download on CI (#16352)
  Regression: Fix set name to alias validation (#16347)
  Send build artifacts to S3 (#16237)
  [NEW] Create a user for the Apps during installation (#15896)
  Add missing translations (#16150)
  fix slack cvs user importer (#16253)
  [FIX] The "click to load" text is hard-coded and not translated. (#16142)
  ...
gabriellsh added a commit that referenced this pull request Jan 31, 2020
…pinned_messages_collapse

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [IMPROVE] Update katex version  (#16393)
  [FIX] Mail Msg Cancel button not closing the flexbar (#16263)
  [FIX] Highlight freezing the UI (#16378)
  [BREAK] Hide system messages (#16243)
  [IMPROVE] Prevent "App user" from being deleted by the admin (#16373)
  [FIX] Adding 'lang' tag (#16375)
  Lint: Resolve complexity warnings (#16114)
  Fix Preview Docker image (#16379)
  [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252)
  [FIX] App removal was moving logs to the trash collection (#16362)
  [FIX] Role tags missing - Description field explanation (#16356)
  Regression: Rate limiter was not working due to Meteor internal changes (#16361)
  [FIX] Invite links usage by channel owners/moderators (#16176)
  Fix assets download on CI (#16352)
  Regression: Fix set name to alias validation (#16347)
  Send build artifacts to S3 (#16237)
  [NEW] Create a user for the Apps during installation (#15896)
  Add missing translations (#16150)
  fix slack cvs user importer (#16253)
ggazzo added a commit that referenced this pull request Jan 31, 2020
* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Container heights (#16388)
  Regression: App deletion wasn’t returning the correct information (#16360)
  [BREAK] Remove deprecated publications (#16351)
  [IMPROVE] Update katex version  (#16393)
  [FIX] Mail Msg Cancel button not closing the flexbar (#16263)
  [FIX] Highlight freezing the UI (#16378)
  [BREAK] Hide system messages (#16243)
  [IMPROVE] Prevent "App user" from being deleted by the admin (#16373)
  [FIX] Adding 'lang' tag (#16375)
  Lint: Resolve complexity warnings (#16114)
  Fix Preview Docker image (#16379)
  [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252)
  [FIX] App removal was moving logs to the trash collection (#16362)
  [FIX] Role tags missing - Description field explanation (#16356)
ggazzo added a commit that referenced this pull request Feb 3, 2020
…nto system-messages

* 'system-messages' of github.com:RocketChat/Rocket.Chat:
  [BREAK] Hide system messages (#16243)
  [IMPROVE] Prevent "App user" from being deleted by the admin (#16373)
  [FIX] Adding 'lang' tag (#16375)
  Lint: Resolve complexity warnings (#16114)
  Fix Preview Docker image (#16379)
  [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252)
  [FIX] App removal was moving logs to the trash collection (#16362)
  [FIX] Role tags missing - Description field explanation (#16356)
  Regression: Rate limiter was not working due to Meteor internal changes (#16361)
  [FIX] Invite links usage by channel owners/moderators (#16176)
  Fix assets download on CI (#16352)
@sampaiodiego sampaiodiego mentioned this pull request Feb 15, 2020
@sampaiodiego sampaiodiego deleted the role-tags-missing branch February 21, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui Touches the code on client side

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recent role tags are missing

3 participants