Remove linkstatic boilerplate.

[david-german-tri]

Follows up on #5155.

Fixes #5104.

---

This change is 

[jwnimmer-tri]

Reviewed 16 of 39 files at r1.
Review status: 16 of 39 files reviewed at latest revision, 1 unresolved discussion.

---

drake/lcmtypes/BUILD, line 12 at r1 (raw file):

    lcm_package = "drake",
    lcm_srcs = ["lcmt_body_acceleration.lcm"],
    linkstatic = 1,

Meta the lcm_cc_library does not use drake_cc_library so is missing the new default. I think that's the correct call graph (because we don't want Drake warnings in generated code), but this PR ends up removing linkstatic = 1 on these libraries, which is perhaps not intended?

---

Comments from Reviewable

[jwnimmer-tri]

Reviewed 23 of 39 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[david-german-tri]

Review status: 39 of 40 files reviewed at latest revision, 1 unresolved discussion.

---

drake/lcmtypes/BUILD, line 12 at r1 (raw file):

Previously, jwnimmer-tri (Jeremy Nimmer) wrote…

Meta the lcm_cc_library does not use drake_cc_library so is missing the new default. I think that's the correct call graph (because we don't want Drake warnings in generated code), but this PR ends up removing linkstatic = 1 on these libraries, which is perhaps not intended?

Done.

---

Comments from Reviewable

[jwnimmer-tri]

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[jwnimmer-tri]

Review status: all files reviewed at latest revision, all discussions resolved.

---

drake/lcmtypes/BUILD, line 12 at r1 (raw file):

Previously, david-german-tri (David German) wrote…

Done.

Hmm, should tools/bot_core_lcmtypes.BUILD should drop its linkstatic = 1 now, since its just repeating the default?

---

Comments from Reviewable

[jwnimmer-tri]

Review status: all files reviewed at latest revision, all discussions resolved.

---

drake/lcmtypes/BUILD, line 12 at r1 (raw file):

Previously, jwnimmer-tri (Jeremy Nimmer) wrote…

Hmm, should tools/bot_core_lcmtypes.BUILD should drop its linkstatic = 1 now, since its just repeating the default?

Ditto for tools/robotlocomotion_lcmtypes.BUILD.

---

Comments from Reviewable

[jwnimmer-tri]

---

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[david-german-tri]

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

drake/lcmtypes/BUILD, line 12 at r1 (raw file):

Previously, jwnimmer-tri (Jeremy Nimmer) wrote…

Ditto for tools/robotlocomotion_lcmtypes.BUILD.

Maybe. That boilerplate is far less contagious, so I'm inclined to leave it for a followup (if at all). I think it's a good thing this PR doesn't touch tools/ at all, since many of the linkstatic in there remain necessary.

---

Comments from Reviewable

[jwnimmer-tri]

Review status: all files reviewed at latest revision, all discussions resolved.

---

drake/lcmtypes/BUILD, line 12 at r1 (raw file):

Previously, david-german-tri (David German) wrote…

Maybe. That boilerplate is far less contagious, so I'm inclined to leave it for a followup (if at all). I think it's a good thing this PR doesn't touch tools/ at all, since many of the linkstatic in there remain necessary.

Find by me. If we ever change lcm.bzl to choose a different library type, we'll have to correct those two files also, but we'll probably remember and/or catch it in PR review.

---

Comments from Reviewable