Use linkstatic=1 by default in binaries and libraries. #5155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed 1 of 1 files at r1. tools/drake.bzl, line 66 at r1 (raw file):
FYI Ah, this was already the Bazel default. I hadn't previously realized that. (I am fine re-defaulting it here as in this PR; I think mentioning it here will help future readers.) Comments from Reviewable |
|
Bazel builds pass. Override-merging. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
david-german-tri
added a commit
to david-german-tri/drake
that referenced
this pull request
Feb 13, 2017
Follows up on RobotLocomotion#5155. Fixes RobotLocomotion#5104.
david-german-tri
added a commit
to david-german-tri/drake
that referenced
this pull request
Feb 13, 2017
Follows up on RobotLocomotion#5155. Fixes RobotLocomotion#5104.
This was referenced Feb 13, 2017
kunimatsu-tri
pushed a commit
to kunimatsu-tri/drake
that referenced
this pull request
Mar 1, 2017
Follows up on RobotLocomotion#5155. Fixes RobotLocomotion#5104.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #5104.
Supersedes #5153.
This change is