Repository navigation
SWDEV-546351 : Added test cases for hipGetDriverEntryPoint api - #525
Merged
Merged
Conversation
ywang103-amd
pushed a commit
that referenced
this pull request
Aug 19, 2025
Co-authored-by: Jonathan Luu <jonatluu@amd.com> [ROCm/clr commit: a2dafbe]
SwRaw
pushed a commit
that referenced
this pull request
Aug 19, 2025
Co-authored-by: Jonathan Luu <jonatluu@amd.com>
SwRaw
pushed a commit
that referenced
this pull request
Aug 19, 2025
- Fixes compilation error for rocJPEG test app - SWDEV-544094 [ROCm/rocprofiler-sdk commit: 5f422c1]
Contributor
|
!verify |
Contributor
|
/AzurePipelines run rocm-ci-caller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lttamd
approved these changes
Sep 2, 2025
cjatin
reviewed
Sep 3, 2025
|
|
||
| int count; | ||
| HIP_CHECK(hipGetDeviceCount(&count)); | ||
| REQUIRE(countFuncPtr == count); |
Contributor
There was a problem hiding this comment.
Can we add one non zero check as well?
For some reason if it fails, they both will compare against failed values and it will pass.
Something like REQUIRE(count > 0) should help us.
venkatesh-amd
force-pushed
the
import/develop/ROCm_hip-tests/pr-487
branch
from
September 3, 2025 09:23
6757671 to
fc8b536
Compare
Contributor
|
/AzurePipelines run rocm-ci-caller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/AzurePipelines run rocm-ci-caller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
venkatesh-amd
force-pushed
the
import/develop/ROCm_hip-tests/pr-487
branch
from
September 4, 2025 08:12
fc8b536 to
f9b01b0
Compare
chrispaquot
approved these changes
Sep 9, 2025
chrispaquot
requested changes
Sep 9, 2025
chrispaquot
left a comment
Contributor
There was a problem hiding this comment.
please address Jatin's comments
venkatesh-amd
force-pushed
the
import/develop/ROCm_hip-tests/pr-487
branch
from
September 9, 2025 17:29
20a4f35 to
ae6ee5a
Compare
Contributor
|
/AzurePipelines run rocm-ci-caller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
addressed the Jatin's comments. Please review. Thanks. |
jharryma
pushed a commit
that referenced
this pull request
Sep 12, 2025
- Fixes compilation error for rocJPEG test app - SWDEV-544094
chrispaquot
approved these changes
Sep 19, 2025
venkatesh-amd
force-pushed
the
import/develop/ROCm_hip-tests/pr-487
branch
from
September 22, 2025 03:58
ae6ee5a to
fc01b36
Compare
rakesroy
added a commit
that referenced
this pull request
Sep 25, 2025
systems-assistant Bot
pushed a commit
to ROCm/hip-tests
that referenced
this pull request
Oct 3, 2025
api (#525) * SWDEV-546351 - Added test cases for hipGetDriverEntryPoint api * SWDEV-546351 - Added test cases for hipGetDriverEntryPoint api * SWDEV-546351 - Added test cases for hipGetDriverEntryPoint api * SWDEV-546351 : Added test cases for hipGetDriverEntryPoint api * addressed review comments Added non-zero check [rocm-systems] ROCm/rocm-systems#525 (commit 3a9bf2e)
Contributor
|
Stress test passed for PSDB build Linux# 2979, Windows# 875 |
ammallya
pushed a commit
that referenced
this pull request
Nov 17, 2025
Added the following API's to amdsmi_interface.py. amdsmi_get_cpu_handle() amdsmi_get_esmi_err_msg() amdsmi_get_gpu_event_notification() amdsmi_get_processor_count_from_handles() amdsmi_get_processor_handles_by_type() amdsmi_gpu_validate_ras_eeprom() amdsmi_init_gpu_event_notification() amdsmi_set_gpu_event_notification_mask() amdsmi_stop_gpu_event_notification() amdsmi_get_gpu_busy_percent() Added additional return value to API amdsmi_get_xgmi_plpd(). The entry policies is added to the end of the dictionary to match API definition. The entry plpds is marked for deprecation as it has the same information as policies. --------- Signed-off-by: josnarlo <Joseph.Narlo@amd.com> Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
ammallya
pushed a commit
that referenced
this pull request
Nov 18, 2025
Added the following API's to amdsmi_interface.py. amdsmi_get_cpu_handle() amdsmi_get_esmi_err_msg() amdsmi_get_gpu_event_notification() amdsmi_get_processor_count_from_handles() amdsmi_get_processor_handles_by_type() amdsmi_gpu_validate_ras_eeprom() amdsmi_init_gpu_event_notification() amdsmi_set_gpu_event_notification_mask() amdsmi_stop_gpu_event_notification() amdsmi_get_gpu_busy_percent() Added additional return value to API amdsmi_get_xgmi_plpd(). The entry policies is added to the end of the dictionary to match API definition. The entry plpds is marked for deprecation as it has the same information as policies. --------- Signed-off-by: josnarlo <Joseph.Narlo@amd.com> Signed-off-by: Maisam Arif <Maisam.Arif@amd.com> [ROCm/amdsmi commit: 7decbc6]
ammallya
pushed a commit
that referenced
this pull request
Nov 21, 2025
Added the following API's to amdsmi_interface.py. amdsmi_get_cpu_handle() amdsmi_get_esmi_err_msg() amdsmi_get_gpu_event_notification() amdsmi_get_processor_count_from_handles() amdsmi_get_processor_handles_by_type() amdsmi_gpu_validate_ras_eeprom() amdsmi_init_gpu_event_notification() amdsmi_set_gpu_event_notification_mask() amdsmi_stop_gpu_event_notification() amdsmi_get_gpu_busy_percent() Added additional return value to API amdsmi_get_xgmi_plpd(). The entry policies is added to the end of the dictionary to match API definition. The entry plpds is marked for deprecation as it has the same information as policies. --------- Signed-off-by: josnarlo <Joseph.Narlo@amd.com> Signed-off-by: Maisam Arif <Maisam.Arif@amd.com> [ROCm/amdsmi commit: 7decbc6]
ammallya
pushed a commit
that referenced
this pull request
Jan 30, 2026
…pted streams. (#525) * * rocDecode/Error resilience: Added HEVC slice syntax error handle for some corrupted streams. - Detect out of range total reference numbers. * * rocDecode/Error resilience: Added additional checks for HEVC reference parameters. * * rocDecode/Error resilence: Corrected checked range.
ammallya
pushed a commit
that referenced
this pull request
Jan 30, 2026
…pted streams. (#525) * * rocDecode/Error resilience: Added HEVC slice syntax error handle for some corrupted streams. - Detect out of range total reference numbers. * * rocDecode/Error resilience: Added additional checks for HEVC reference parameters. * * rocDecode/Error resilence: Corrected checked range. [ROCm/rocdecode commit: 27adeb8]
dayatsin-amd
pushed a commit
that referenced
this pull request
Apr 7, 2026
Fixing missed merge conflict at clr
1 task done
kcossett-amd
added a commit
that referenced
this pull request
Jul 20, 2026
## Motivation <!-- Explain the purpose of this PR and the goals it aims to achieve. --> `ROCprofiler-SDK`'s #6276 has made a CI warning that would previously crash some `selective-region` tests non-fatal. Now we can re-enable the remaining tests. ## Technical Details Remove the following from the common TheRock exclusion list on `gfx950` workflow AND `test_categories.yaml`: ``` selective-region-region-1-filter.* selective-region-region-2-and-3.* selective-region-no-marker-region-1-filter.* ``` <!-- Explain the changes along with any relevant GitHub links. --> ## Issue Tracking <!-- Include a GitHub Issue and/or JIRA ID. Do not post any full JIRA links here. --> <!-- GitHub issue: #1234 --> <!-- JIRA ID: EXAMPLECOMPONENT-1234 --> Jira ID: AIPROFSYST-521 ## Test Plan <!-- Explain any relevant testing done to verify this PR. --> Workflows + TheRock CI ## Test Result <!-- Briefly summarize test outcomes. --> `gfx950` tests pass: https://github.com/ROCm/rocm-systems/actions/runs/29582264277/job/87890685718?pr=8759 TheRock CI tests pass: https://github.com/ROCm/rocm-systems/actions/runs/29584647543/job/87915973657?pr=8759 ``` Start 488: selective-region-no-filter-start-stop-sys-run 355/473 Test #488: selective-region-no-filter-start-stop-sys-run ................................................................................................................................... Passed 6.85 sec Start 489: selective-region-no-filter-start-stop-sampling 356/473 Test #489: selective-region-no-filter-start-stop-sampling .................................................................................................................................. Passed 6.80 sec Start 490: selective-region-no-filter-push-pop-sys-run 357/473 Test #490: selective-region-no-filter-push-pop-sys-run ..................................................................................................................................... Passed 6.82 sec Start 491: selective-region-no-filter-push-pop-sampling 358/473 Test #491: selective-region-no-filter-push-pop-sampling .................................................................................................................................... Passed 6.82 sec Start 492: selective-region-region-1-filter-start-stop-sys-run 359/473 Test #492: selective-region-region-1-filter-start-stop-sys-run ............................................................................................................................. Passed 6.09 sec Start 493: selective-region-region-1-filter-start-stop-sampling 360/473 Test #493: selective-region-region-1-filter-start-stop-sampling ............................................................................................................................ Passed 6.11 sec Start 494: selective-region-region-1-filter-push-pop-sys-run 361/473 Test #494: selective-region-region-1-filter-push-pop-sys-run ............................................................................................................................... Passed 6.12 sec Start 495: selective-region-region-1-filter-push-pop-sampling 362/473 Test #495: selective-region-region-1-filter-push-pop-sampling .............................................................................................................................. Passed 6.12 sec Start 496: selective-region-region-2-and-3-filter-start-stop-sys-run 363/473 Test #496: selective-region-region-2-and-3-filter-start-stop-sys-run ....................................................................................................................... Passed 5.93 sec Start 497: selective-region-region-2-and-3-filter-start-stop-sampling 364/473 Test #497: selective-region-region-2-and-3-filter-start-stop-sampling ...................................................................................................................... Passed 5.94 sec Start 498: selective-region-region-2-and-3-filter-push-pop-sys-run 365/473 Test #498: selective-region-region-2-and-3-filter-push-pop-sys-run ......................................................................................................................... Passed 5.93 sec Start 499: selective-region-region-2-and-3-filter-push-pop-sampling 366/473 Test #499: selective-region-region-2-and-3-filter-push-pop-sampling ........................................................................................................................ Passed 5.95 sec Start 500: selective-region-pause-no-filter-inside-start-stop-sys-run 367/473 Test #500: selective-region-pause-no-filter-inside-start-stop-sys-run ...................................................................................................................... Passed 4.79 sec Start 501: selective-region-pause-no-filter-inside-start-stop-sampling 368/473 Test #501: selective-region-pause-no-filter-inside-start-stop-sampling ..................................................................................................................... Passed 4.76 sec Start 502: selective-region-pause-no-filter-inside-push-pop-sys-run 369/473 Test #502: selective-region-pause-no-filter-inside-push-pop-sys-run ........................................................................................................................ Passed 4.80 sec Start 503: selective-region-pause-no-filter-inside-push-pop-sampling 370/473 Test #503: selective-region-pause-no-filter-inside-push-pop-sampling ....................................................................................................................... Passed 4.80 sec Start 504: selective-region-pause-no-filter-before-start-stop-sys-run 371/473 Test #504: selective-region-pause-no-filter-before-start-stop-sys-run ...................................................................................................................... Passed 4.80 sec Start 505: selective-region-pause-no-filter-before-start-stop-sampling 372/473 Test #505: selective-region-pause-no-filter-before-start-stop-sampling ..................................................................................................................... Passed 4.81 sec Start 506: selective-region-pause-no-filter-before-push-pop-sys-run 373/473 Test #506: selective-region-pause-no-filter-before-push-pop-sys-run ........................................................................................................................ Passed 4.79 sec Start 507: selective-region-pause-no-filter-before-push-pop-sampling 374/473 Test #507: selective-region-pause-no-filter-before-push-pop-sampling ....................................................................................................................... Passed 4.79 sec Start 508: selective-region-pause-no-filter-outside-start-stop-sys-run 375/473 Test #508: selective-region-pause-no-filter-outside-start-stop-sys-run ..................................................................................................................... Passed 4.81 sec Start 509: selective-region-pause-no-filter-outside-start-stop-sampling 376/473 Test #509: selective-region-pause-no-filter-outside-start-stop-sampling .................................................................................................................... Passed 4.77 sec Start 510: selective-region-pause-no-filter-outside-push-pop-sys-run 377/473 Test #510: selective-region-pause-no-filter-outside-push-pop-sys-run ....................................................................................................................... Passed 4.82 sec Start 511: selective-region-pause-no-filter-outside-push-pop-sampling 378/473 Test #511: selective-region-pause-no-filter-outside-push-pop-sampling ...................................................................................................................... Passed 4.81 sec Start 512: selective-region-pause-filtered-inside-start-stop-sys-run 379/473 Test #512: selective-region-pause-filtered-inside-start-stop-sys-run ....................................................................................................................... Passed 4.55 sec Start 513: selective-region-pause-filtered-inside-start-stop-sampling 380/473 Test #513: selective-region-pause-filtered-inside-start-stop-sampling ...................................................................................................................... Passed 4.67 sec Start 514: selective-region-pause-filtered-inside-push-pop-sys-run 381/473 Test #514: selective-region-pause-filtered-inside-push-pop-sys-run ......................................................................................................................... Passed 4.55 sec Start 515: selective-region-pause-filtered-inside-push-pop-sampling 382/473 Test #515: selective-region-pause-filtered-inside-push-pop-sampling ........................................................................................................................ Passed 4.54 sec Start 516: selective-region-pause-filtered-before-start-stop-sys-run 383/473 Test #516: selective-region-pause-filtered-before-start-stop-sys-run ....................................................................................................................... Passed 4.53 sec Start 517: selective-region-pause-filtered-before-start-stop-sampling 384/473 Test #517: selective-region-pause-filtered-before-start-stop-sampling ...................................................................................................................... Passed 4.57 sec Start 518: selective-region-pause-filtered-before-push-pop-sys-run 385/473 Test #518: selective-region-pause-filtered-before-push-pop-sys-run ......................................................................................................................... Passed 4.53 sec Start 519: selective-region-pause-filtered-before-push-pop-sampling 386/473 Test #519: selective-region-pause-filtered-before-push-pop-sampling ........................................................................................................................ Passed 4.68 sec Start 520: selective-region-pause-filtered-outside-start-stop-sys-run 387/473 Test #520: selective-region-pause-filtered-outside-start-stop-sys-run ...................................................................................................................... Passed 4.53 sec Start 521: selective-region-pause-filtered-outside-start-stop-sampling 388/473 Test #521: selective-region-pause-filtered-outside-start-stop-sampling ..................................................................................................................... Passed 4.56 sec Start 522: selective-region-pause-filtered-outside-push-pop-sys-run 389/473 Test #522: selective-region-pause-filtered-outside-push-pop-sys-run ........................................................................................................................ Passed 4.55 sec Start 523: selective-region-pause-filtered-outside-push-pop-sampling 390/473 Test #523: selective-region-pause-filtered-outside-push-pop-sampling ....................................................................................................................... Passed 4.52 sec Start 524: selective-region-pause-no-marker-inside-start-stop-sys-run 391/473 Test #524: selective-region-pause-no-marker-inside-start-stop-sys-run ...................................................................................................................... Passed 3.37 sec Start 525: selective-region-pause-no-marker-inside-start-stop-sampling 392/473 Test #525: selective-region-pause-no-marker-inside-start-stop-sampling ..................................................................................................................... Passed 3.46 sec Start 526: selective-region-pause-no-marker-inside-push-pop-sys-run 393/473 Test #526: selective-region-pause-no-marker-inside-push-pop-sys-run ........................................................................................................................ Passed 3.35 sec Start 527: selective-region-pause-no-marker-inside-push-pop-sampling 394/473 Test #527: selective-region-pause-no-marker-inside-push-pop-sampling ....................................................................................................................... Passed 3.52 sec Start 528: selective-region-pause-no-marker-before-start-stop-sys-run 395/473 Test #528: selective-region-pause-no-marker-before-start-stop-sys-run ...................................................................................................................... Passed 3.40 sec Start 529: selective-region-pause-no-marker-before-start-stop-sampling 396/473 Test #529: selective-region-pause-no-marker-before-start-stop-sampling ..................................................................................................................... Passed 3.36 sec Start 530: selective-region-pause-no-marker-before-push-pop-sys-run 397/473 Test #530: selective-region-pause-no-marker-before-push-pop-sys-run ........................................................................................................................ Passed 3.37 sec Start 531: selective-region-pause-no-marker-before-push-pop-sampling 398/473 Test #531: selective-region-pause-no-marker-before-push-pop-sampling ....................................................................................................................... Passed 3.36 sec Start 532: selective-region-pause-no-marker-outside-start-stop-sys-run 399/473 Test #532: selective-region-pause-no-marker-outside-start-stop-sys-run ..................................................................................................................... Passed 3.35 sec Start 533: selective-region-pause-no-marker-outside-start-stop-sampling 400/473 Test #533: selective-region-pause-no-marker-outside-start-stop-sampling .................................................................................................................... Passed 3.39 sec Start 534: selective-region-pause-no-marker-outside-push-pop-sys-run 401/473 Test #534: selective-region-pause-no-marker-outside-push-pop-sys-run ....................................................................................................................... Passed 3.49 sec Start 535: selective-region-pause-no-marker-outside-push-pop-sampling 402/473 Test #535: selective-region-pause-no-marker-outside-push-pop-sampling ...................................................................................................................... Passed 3.51 sec Start 536: selective-region-no-marker-region-1-filter-start-stop-sys-run 403/473 Test #536: selective-region-no-marker-region-1-filter-start-stop-sys-run ................................................................................................................... Passed 4.81 sec Start 537: selective-region-no-marker-region-1-filter-start-stop-sampling 404/473 Test #537: selective-region-no-marker-region-1-filter-start-stop-sampling .................................................................................................................. Passed 4.82 sec ``` ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated JIRA ticket number/Github issue number
SWDEV-546351
What type of PR is this? (check all applicable)
What were the changes?
Unit test case development for hipGetDriverEntryPoint api
Why are these changes needed?
validate functionality of hipGetDriverEntryPoint api and perform the unit test
Updated CHANGELOG?
Added/Updated documentation?
Additional Checks
🔁 Imported from ROCm/hip-tests#487
🧑💻 Originally authored by @rocm-devops