Repository navigation
SWDEV-546346 - [catch2][dtest] Additional tests for hipStremGetId - #522
Closed
systems-assistant[bot] wants to merge 2 commits into
Closed
systems-assistant[bot] wants to merge 2 commits into
systems-assistant[bot] wants to merge 2 commits into
Conversation
ammallya
pushed a commit
that referenced
this pull request
Jan 30, 2026
…on. (#522) - During stream type evaluation, when we have a high confidence score, we stop and finalize, to avoid unnecessary exhaustive type search.
Contributor
|
This pull request has been inactive for 25 days and will be marked as stale. If you would like to keep this PR open, please:
This PR will be automatically closed in 5 days if no further activity occurs. |
Contributor
|
This pull request has been automatically closed due to inactivity (30 days with no updates). If you'd like to continue working on this, feel free to reopen the PR or create a new one. |
kcossett-amd
added a commit
that referenced
this pull request
Jul 20, 2026
## Motivation <!-- Explain the purpose of this PR and the goals it aims to achieve. --> `ROCprofiler-SDK`'s #6276 has made a CI warning that would previously crash some `selective-region` tests non-fatal. Now we can re-enable the remaining tests. ## Technical Details Remove the following from the common TheRock exclusion list on `gfx950` workflow AND `test_categories.yaml`: ``` selective-region-region-1-filter.* selective-region-region-2-and-3.* selective-region-no-marker-region-1-filter.* ``` <!-- Explain the changes along with any relevant GitHub links. --> ## Issue Tracking <!-- Include a GitHub Issue and/or JIRA ID. Do not post any full JIRA links here. --> <!-- GitHub issue: #1234 --> <!-- JIRA ID: EXAMPLECOMPONENT-1234 --> Jira ID: AIPROFSYST-521 ## Test Plan <!-- Explain any relevant testing done to verify this PR. --> Workflows + TheRock CI ## Test Result <!-- Briefly summarize test outcomes. --> `gfx950` tests pass: https://github.com/ROCm/rocm-systems/actions/runs/29582264277/job/87890685718?pr=8759 TheRock CI tests pass: https://github.com/ROCm/rocm-systems/actions/runs/29584647543/job/87915973657?pr=8759 ``` Start 488: selective-region-no-filter-start-stop-sys-run 355/473 Test #488: selective-region-no-filter-start-stop-sys-run ................................................................................................................................... Passed 6.85 sec Start 489: selective-region-no-filter-start-stop-sampling 356/473 Test #489: selective-region-no-filter-start-stop-sampling .................................................................................................................................. Passed 6.80 sec Start 490: selective-region-no-filter-push-pop-sys-run 357/473 Test #490: selective-region-no-filter-push-pop-sys-run ..................................................................................................................................... Passed 6.82 sec Start 491: selective-region-no-filter-push-pop-sampling 358/473 Test #491: selective-region-no-filter-push-pop-sampling .................................................................................................................................... Passed 6.82 sec Start 492: selective-region-region-1-filter-start-stop-sys-run 359/473 Test #492: selective-region-region-1-filter-start-stop-sys-run ............................................................................................................................. Passed 6.09 sec Start 493: selective-region-region-1-filter-start-stop-sampling 360/473 Test #493: selective-region-region-1-filter-start-stop-sampling ............................................................................................................................ Passed 6.11 sec Start 494: selective-region-region-1-filter-push-pop-sys-run 361/473 Test #494: selective-region-region-1-filter-push-pop-sys-run ............................................................................................................................... Passed 6.12 sec Start 495: selective-region-region-1-filter-push-pop-sampling 362/473 Test #495: selective-region-region-1-filter-push-pop-sampling .............................................................................................................................. Passed 6.12 sec Start 496: selective-region-region-2-and-3-filter-start-stop-sys-run 363/473 Test #496: selective-region-region-2-and-3-filter-start-stop-sys-run ....................................................................................................................... Passed 5.93 sec Start 497: selective-region-region-2-and-3-filter-start-stop-sampling 364/473 Test #497: selective-region-region-2-and-3-filter-start-stop-sampling ...................................................................................................................... Passed 5.94 sec Start 498: selective-region-region-2-and-3-filter-push-pop-sys-run 365/473 Test #498: selective-region-region-2-and-3-filter-push-pop-sys-run ......................................................................................................................... Passed 5.93 sec Start 499: selective-region-region-2-and-3-filter-push-pop-sampling 366/473 Test #499: selective-region-region-2-and-3-filter-push-pop-sampling ........................................................................................................................ Passed 5.95 sec Start 500: selective-region-pause-no-filter-inside-start-stop-sys-run 367/473 Test #500: selective-region-pause-no-filter-inside-start-stop-sys-run ...................................................................................................................... Passed 4.79 sec Start 501: selective-region-pause-no-filter-inside-start-stop-sampling 368/473 Test #501: selective-region-pause-no-filter-inside-start-stop-sampling ..................................................................................................................... Passed 4.76 sec Start 502: selective-region-pause-no-filter-inside-push-pop-sys-run 369/473 Test #502: selective-region-pause-no-filter-inside-push-pop-sys-run ........................................................................................................................ Passed 4.80 sec Start 503: selective-region-pause-no-filter-inside-push-pop-sampling 370/473 Test #503: selective-region-pause-no-filter-inside-push-pop-sampling ....................................................................................................................... Passed 4.80 sec Start 504: selective-region-pause-no-filter-before-start-stop-sys-run 371/473 Test #504: selective-region-pause-no-filter-before-start-stop-sys-run ...................................................................................................................... Passed 4.80 sec Start 505: selective-region-pause-no-filter-before-start-stop-sampling 372/473 Test #505: selective-region-pause-no-filter-before-start-stop-sampling ..................................................................................................................... Passed 4.81 sec Start 506: selective-region-pause-no-filter-before-push-pop-sys-run 373/473 Test #506: selective-region-pause-no-filter-before-push-pop-sys-run ........................................................................................................................ Passed 4.79 sec Start 507: selective-region-pause-no-filter-before-push-pop-sampling 374/473 Test #507: selective-region-pause-no-filter-before-push-pop-sampling ....................................................................................................................... Passed 4.79 sec Start 508: selective-region-pause-no-filter-outside-start-stop-sys-run 375/473 Test #508: selective-region-pause-no-filter-outside-start-stop-sys-run ..................................................................................................................... Passed 4.81 sec Start 509: selective-region-pause-no-filter-outside-start-stop-sampling 376/473 Test #509: selective-region-pause-no-filter-outside-start-stop-sampling .................................................................................................................... Passed 4.77 sec Start 510: selective-region-pause-no-filter-outside-push-pop-sys-run 377/473 Test #510: selective-region-pause-no-filter-outside-push-pop-sys-run ....................................................................................................................... Passed 4.82 sec Start 511: selective-region-pause-no-filter-outside-push-pop-sampling 378/473 Test #511: selective-region-pause-no-filter-outside-push-pop-sampling ...................................................................................................................... Passed 4.81 sec Start 512: selective-region-pause-filtered-inside-start-stop-sys-run 379/473 Test #512: selective-region-pause-filtered-inside-start-stop-sys-run ....................................................................................................................... Passed 4.55 sec Start 513: selective-region-pause-filtered-inside-start-stop-sampling 380/473 Test #513: selective-region-pause-filtered-inside-start-stop-sampling ...................................................................................................................... Passed 4.67 sec Start 514: selective-region-pause-filtered-inside-push-pop-sys-run 381/473 Test #514: selective-region-pause-filtered-inside-push-pop-sys-run ......................................................................................................................... Passed 4.55 sec Start 515: selective-region-pause-filtered-inside-push-pop-sampling 382/473 Test #515: selective-region-pause-filtered-inside-push-pop-sampling ........................................................................................................................ Passed 4.54 sec Start 516: selective-region-pause-filtered-before-start-stop-sys-run 383/473 Test #516: selective-region-pause-filtered-before-start-stop-sys-run ....................................................................................................................... Passed 4.53 sec Start 517: selective-region-pause-filtered-before-start-stop-sampling 384/473 Test #517: selective-region-pause-filtered-before-start-stop-sampling ...................................................................................................................... Passed 4.57 sec Start 518: selective-region-pause-filtered-before-push-pop-sys-run 385/473 Test #518: selective-region-pause-filtered-before-push-pop-sys-run ......................................................................................................................... Passed 4.53 sec Start 519: selective-region-pause-filtered-before-push-pop-sampling 386/473 Test #519: selective-region-pause-filtered-before-push-pop-sampling ........................................................................................................................ Passed 4.68 sec Start 520: selective-region-pause-filtered-outside-start-stop-sys-run 387/473 Test #520: selective-region-pause-filtered-outside-start-stop-sys-run ...................................................................................................................... Passed 4.53 sec Start 521: selective-region-pause-filtered-outside-start-stop-sampling 388/473 Test #521: selective-region-pause-filtered-outside-start-stop-sampling ..................................................................................................................... Passed 4.56 sec Start 522: selective-region-pause-filtered-outside-push-pop-sys-run 389/473 Test #522: selective-region-pause-filtered-outside-push-pop-sys-run ........................................................................................................................ Passed 4.55 sec Start 523: selective-region-pause-filtered-outside-push-pop-sampling 390/473 Test #523: selective-region-pause-filtered-outside-push-pop-sampling ....................................................................................................................... Passed 4.52 sec Start 524: selective-region-pause-no-marker-inside-start-stop-sys-run 391/473 Test #524: selective-region-pause-no-marker-inside-start-stop-sys-run ...................................................................................................................... Passed 3.37 sec Start 525: selective-region-pause-no-marker-inside-start-stop-sampling 392/473 Test #525: selective-region-pause-no-marker-inside-start-stop-sampling ..................................................................................................................... Passed 3.46 sec Start 526: selective-region-pause-no-marker-inside-push-pop-sys-run 393/473 Test #526: selective-region-pause-no-marker-inside-push-pop-sys-run ........................................................................................................................ Passed 3.35 sec Start 527: selective-region-pause-no-marker-inside-push-pop-sampling 394/473 Test #527: selective-region-pause-no-marker-inside-push-pop-sampling ....................................................................................................................... Passed 3.52 sec Start 528: selective-region-pause-no-marker-before-start-stop-sys-run 395/473 Test #528: selective-region-pause-no-marker-before-start-stop-sys-run ...................................................................................................................... Passed 3.40 sec Start 529: selective-region-pause-no-marker-before-start-stop-sampling 396/473 Test #529: selective-region-pause-no-marker-before-start-stop-sampling ..................................................................................................................... Passed 3.36 sec Start 530: selective-region-pause-no-marker-before-push-pop-sys-run 397/473 Test #530: selective-region-pause-no-marker-before-push-pop-sys-run ........................................................................................................................ Passed 3.37 sec Start 531: selective-region-pause-no-marker-before-push-pop-sampling 398/473 Test #531: selective-region-pause-no-marker-before-push-pop-sampling ....................................................................................................................... Passed 3.36 sec Start 532: selective-region-pause-no-marker-outside-start-stop-sys-run 399/473 Test #532: selective-region-pause-no-marker-outside-start-stop-sys-run ..................................................................................................................... Passed 3.35 sec Start 533: selective-region-pause-no-marker-outside-start-stop-sampling 400/473 Test #533: selective-region-pause-no-marker-outside-start-stop-sampling .................................................................................................................... Passed 3.39 sec Start 534: selective-region-pause-no-marker-outside-push-pop-sys-run 401/473 Test #534: selective-region-pause-no-marker-outside-push-pop-sys-run ....................................................................................................................... Passed 3.49 sec Start 535: selective-region-pause-no-marker-outside-push-pop-sampling 402/473 Test #535: selective-region-pause-no-marker-outside-push-pop-sampling ...................................................................................................................... Passed 3.51 sec Start 536: selective-region-no-marker-region-1-filter-start-stop-sys-run 403/473 Test #536: selective-region-no-marker-region-1-filter-start-stop-sys-run ................................................................................................................... Passed 4.81 sec Start 537: selective-region-no-marker-region-1-filter-start-stop-sampling 404/473 Test #537: selective-region-no-marker-region-1-filter-start-stop-sampling .................................................................................................................. Passed 4.82 sec ``` ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.
dgaliffiAMD
added a commit
that referenced
this pull request
Sep 18, 2026
#10932) ## Motivation Feedback from - #10418 Perfetto trace output was named `perfetto-trace.proto`, but the on-disk content has always been a standard Perfetto binary trace, not a raw `.proto` schema file. This renames the default output to `.pftrace`, matching the convention `rocprofv3` and `rocpd` already use, while keeping `proto` as a permanent alias so existing scripts and configs keep working. Automated review feedback on the initial pytest changes also surfaced a couple of test-helper gaps around that same backward-compatibility guarantee, which are folded into this PR as well. ## Technical Details The extension is data, not a code default: `config::get_perfetto_output_filename()` parses the extension out of the `ROCPROFSYS_PERFETTO_FILE` setting, whose default was literally `perfetto-trace.proto`. Changing that setting default is therefore the single lever that moves both Perfetto pipelines at once — the legacy live SDK session (`get_use_perfetto()`) and the cached replay path (`get_caching_perfetto()`, the default since `ROCPROFSYS_TRACE_LEGACY` defaults to false) — since they share the same filename-composition helpers in `config.cpp`. Scoping the change to only one path was evaluated and rejected: it would have required duplicating ~40 lines of suffix/session-id composition logic. The change touches four areas: - **Core behavior**: `.pftrace` default extension, `pftrace` as the canonical `--output-format` token with `proto` retained as an alias, cached-path merged-trace output renamed to `merged.pftrace`, and `scripts/merge-multiprocess-output.sh` updated to target `merged.pftrace` (still accepting `.proto` inputs for mixed-vintage output directories, and fixing a latent bug where a stale `merged.proto` from a prior run got folded back into the merge as if it were unmerged). - **Tests**: new C++ unit tests cover the `pftrace` token and the `proto`/`pftrace` alias equivalence, without touching the existing `proto_*` tests (their continuing to pass unmodified is the backward-compat guarantee). The pytest harness (`runners.py`, `conftest.py`, `validators.py`) was updated to expect `.pftrace` by default, with cleanup globs deliberately retaining `.proto` patterns so stale artifacts from older builds still get cleaned. Automated review feedback on those pytest changes was then addressed: `TestResult.perfetto_file` now also detects legacy `.proto` traces (since the product still honors an explicitly configured `ROCPROFSYS_PERFETTO_FILE=...proto`), the `validate_perfetto_trace` docstring no longer implies a fixed `.pftrace` filename, and an unescaped `.` in `test_mpi.py`'s `BINARY_REWRITE_FAIL_REGEX` is now escaped to match literally rather than any character. - **User-facing text**: console hints, `--help` text, and preset schema descriptions updated to say `pftrace`. - **Docs**: how-to guides, the output-format overview, and the unified-memory example README updated to reference `.pftrace`. An explicitly configured `ROCPROFSYS_PERFETTO_FILE=....proto` is still honored verbatim — the new default extension only changes what gets written when nothing is explicitly configured. **clang-tidy issues** are addressed in the stacked PR, so it is easier to see the logic changes in this PR. ## Issue Tracking JIRA ID - AIPROFSYST-750 ## Test Plan - [x] Unit tests: full binary (1365 tests / 108 suites) passes; targeted filter on `output_format.*:single_file_sink.*:per_pid_file_sink.*:locked_file_append.*` passes 29/29, including the untouched pre-existing `proto_*` tests - [x] Merge script validated across 5 scenarios including re-run idempotency and the stale-`merged.proto` exclusion fix - [x] CLI help renders `--output-format [ json | pftrace | proto | rocpd | text | txt ]` - [x] End-to-end runs of `rocprof-sys-sample`: `--output-format pftrace` and `--output-format proto` (alias) both produce a `.pftrace` file; an explicit `ROCPROFSYS_PERFETTO_FILE=my-trace.proto` override is honored verbatim alongside `--output-format pftrace` ## Test Result Unit tests, merge script, and CLI/e2e smoke tests all pass on Ubuntu 26.04. No functional regressions found ### E2E Tests ``` Start 522: tool-runner-output-format-pftrace-and-proto-alias-enable-perfetto-run-pftrace 4/10 Test #522: tool-runner-output-format-pftrace-and-proto-alias-enable-perfetto-run-pftrace ....... Passed 4.67 sec Start 523: tool-runner-output-format-pftrace-and-proto-alias-enable-perfetto-run-proto-alias 5/10 Test #523: tool-runner-output-format-pftrace-and-proto-alias-enable-perfetto-run-proto-alias ... Passed 4.64 sec ``` ### Unit Tests ``` 588: [ RUN ] output_format.proto_enables_only_perfetto 588: [ OK ] output_format.proto_enables_only_perfetto (0 ms) 588: [ RUN ] output_format.pftrace_enables_only_perfetto 588: [ OK ] output_format.pftrace_enables_only_perfetto (0 ms) 588: [ RUN ] output_format.proto_aliases_pftrace 588: [ OK ] output_format.proto_aliases_pftrace (0 ms) ``` ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md. --------- Signed-off-by: David Galiffi <David.Galiffi@amd.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated JIRA ticket number/Github issue number
SWDEV-546346
What type of PR is this? (check all applicable)
What were the changes?
Additional test cases for hipStremGetId API
Why are these changes needed?
To check the hipStremGetId API behavior
Updated CHANGELOG?
Added/Updated documentation?
Additional Checks
🔁 Imported from ROCm/hip-tests#484
🧑💻 Originally authored by @rocm-devops