Repository navigation
SWDEV-546351 : Added test cases for hipGetDriverEntryPoint api #525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1c92039
SWDEV-546351 - Added test cases for hipGetDriverEntryPoint api
venkatesh-amd dbbb4f1
SWDEV-546351 - Added test cases for hipGetDriverEntryPoint api
venkatesh-amd 66193fe
SWDEV-546351 - Added test cases for hipGetDriverEntryPoint api
venkatesh-amd 09c9977
SWDEV-546351 : Added test cases for hipGetDriverEntryPoint api
venkatesh-amd fc01b36
addressed review comments Added non-zero check
venkatesh-amd 04f0e36
Merge branch 'develop' into import/develop/ROCm_hip-tests/pr-487
jainprad 6bc93aa
Merge branch 'develop' into import/develop/ROCm_hip-tests/pr-487
jainprad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
208 changes: 208 additions & 0 deletions
208
projects/hip-tests/catch/unit/device/hipGetDriverEntryPoint.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,208 @@ | ||
| /* | ||
| Copyright (c) 2025 Advanced Micro Devices, Inc. All rights reserved. | ||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
| The above copyright notice and this permission notice shall be included in | ||
| all copies or substantial portions of the Software. | ||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANNTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER INN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR INN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| THE SOFTWARE. | ||
| */ | ||
|
|
||
| #include <hip_test_common.hh> | ||
|
|
||
| /** | ||
| * hipError_t hipGetDriverEntryPoint(const char* symbol, void** funcPtr, unsigned long long flags, | ||
| hipDriverEntryPointQueryResult* driverStatus); | ||
| * Gets function pointer of a request HIP API | ||
| * | ||
| * @param [in] symbol The API base name | ||
| * @param [out] funcPtr Pinter to the requested function | ||
| * @param [in] flags Flags for the search | ||
| * @param [out] driverStatus Optional returned status of the search | ||
| * | ||
| * @returns #hipSuccess, #hipErrorInvalidValue | ||
| * | ||
| */ | ||
|
|
||
| /** | ||
| * Test Description | ||
| * ------------------------ | ||
| * - This will perfrom the funtionality testing of hipGetDriverEntryPoint api | ||
| * Test source | ||
| * ------------------------ | ||
| * - unit/device/hipGetDriverEntryPoint.cc | ||
| * Test requirements | ||
| * ------------------------ | ||
| * - HIP_VERSION >= 7.1 | ||
| */ | ||
| TEST_CASE("Unit_hipGetDriverEntryPoint_Positive") { | ||
| void* funcPtr = nullptr; | ||
| hipDriverEntryPointQueryResult status; | ||
|
|
||
| SECTION("hipEnableDefault search flag") { | ||
| HIP_CHECK(hipGetDriverEntryPoint("hipGetDeviceCount", &funcPtr, hipEnableDefault, &status)); | ||
| } | ||
|
|
||
| SECTION("hipEnableLegacyStream search flag") { | ||
| HIP_CHECK( | ||
| hipGetDriverEntryPoint("hipGetDeviceCount", &funcPtr, hipEnableLegacyStream, &status)); | ||
| } | ||
|
|
||
| SECTION("hipEnablePerThreadDefaultStream search flag") { | ||
| HIP_CHECK(hipGetDriverEntryPoint("hipGetDeviceCount", &funcPtr, hipEnablePerThreadDefaultStream, | ||
| &status)); | ||
| } | ||
|
|
||
| REQUIRE(status == hipDriverEntryPointSuccess); | ||
|
|
||
| hipError_t (*hipGetDeviceCount_ptr)(int*) = (hipError_t(*)(int*))funcPtr; | ||
| int countFuncPtr; | ||
| HIP_CHECK(hipGetDeviceCount_ptr(&countFuncPtr)); | ||
|
|
||
| int count; | ||
| HIP_CHECK(hipGetDeviceCount(&count)); | ||
|
|
||
| REQUIRE(count > 0); | ||
| REQUIRE(countFuncPtr == count); | ||
| } | ||
|
|
||
| /** | ||
| * Test Description | ||
| * ------------------------ | ||
| * - This tests checks hipGetDriverEntryPoint api with negative parameters | ||
| * # symbol is empty | ||
| * # funcPtr pointer is null | ||
| * # Invalid flag | ||
| * Test source | ||
| * ------------------------ | ||
| * - unit/device/hipGetDriverEntryPoint.cc | ||
| * Test requirements | ||
| * ------------------------ | ||
| * - HIP_VERSION >= 7.1 | ||
| */ | ||
|
|
||
| TEST_CASE("Unit_hipGetDriverEntryPoint_Negative") { | ||
| void* funcPtr = nullptr; | ||
| hipDriverEntryPointQueryResult status; | ||
|
|
||
| SECTION("Empty string as symbol") { | ||
| HIP_CHECK_ERROR(hipGetDriverEntryPoint("", &funcPtr, hipEnableDefault, &status), | ||
| hipErrorInvalidValue); | ||
| } | ||
|
|
||
| SECTION("funtion pointer is nullptr") { | ||
| HIP_CHECK_ERROR(hipGetDriverEntryPoint("hipGetDeviceCount", nullptr, hipEnableDefault, &status), | ||
| hipErrorInvalidValue); | ||
| } | ||
|
|
||
| SECTION("Invalid flag") { | ||
| HIP_CHECK_ERROR(hipGetDriverEntryPoint("hipGetDeviceCount", &funcPtr, -1, &status), | ||
| hipErrorInvalidValue); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * hipError_t hipGetDriverEntryPoint_spt(const char* symbol, void** funcPtr, unsigned long long | ||
| flags, hipDriverEntryPointQueryResult* driverStatus); | ||
| * Gets function pointer of a request HIP API | ||
| * | ||
| * @param [in] symbol The API base name | ||
| * @param [out] funcPtr Pinter to the requested function | ||
| * @param [in] flags Flags for the search | ||
| * @param [out] driverStatus Optional returned status of the search | ||
| * | ||
| * @returns #hipSuccess, #hipErrorInvalidValue | ||
| * | ||
| */ | ||
|
|
||
| /** | ||
| * Test Description | ||
| * ------------------------ | ||
| * - This will perfrom the funtionality testing og hipGetDriverEntryPoint_spt api | ||
| * Test source | ||
| * ------------------------ | ||
| * - unit/device/hipGetDriverEntryPoint.cc | ||
| * Test requirements | ||
| * ------------------------ | ||
| * - HIP_VERSION >= 7.1 | ||
| */ | ||
|
|
||
| TEST_CASE("Unit_hipGetDriverEntryPoint_spt_Positive") { | ||
| void* funcPtr = nullptr; | ||
| hipDriverEntryPointQueryResult status; | ||
|
|
||
| SECTION("hipEnableDefault search flag") { | ||
| HIP_CHECK(hipGetDriverEntryPoint_spt("hipGetDeviceCount", &funcPtr, hipEnableDefault, &status)); | ||
| } | ||
|
|
||
| SECTION("hipEnableLegacyStream search flag") { | ||
| HIP_CHECK( | ||
| hipGetDriverEntryPoint_spt("hipGetDeviceCount", &funcPtr, hipEnableLegacyStream, &status)); | ||
| } | ||
|
|
||
| SECTION("hipEnablePerThreadDefaultStream search flag") { | ||
| HIP_CHECK(hipGetDriverEntryPoint_spt("hipGetDeviceCount", &funcPtr, | ||
| hipEnablePerThreadDefaultStream, &status)); | ||
| } | ||
|
|
||
| REQUIRE(status == hipDriverEntryPointSuccess); | ||
|
|
||
| hipError_t (*hipGetDeviceCount_ptr)(int*) = (hipError_t(*)(int*))funcPtr; | ||
| int countFuncPtr; | ||
| HIP_CHECK(hipGetDeviceCount_ptr(&countFuncPtr)); | ||
|
|
||
| int count; | ||
| HIP_CHECK(hipGetDeviceCount(&count)); | ||
|
|
||
| REQUIRE(count > 0); | ||
| REQUIRE(countFuncPtr == count); | ||
|
venkatesh-amd marked this conversation as resolved.
Resolved
|
||
| } | ||
|
|
||
| /** | ||
| * Test Description | ||
| * ------------------------ | ||
| * - This tests checks hipGetDriverEntryPoint_spt api with negative parameters | ||
| * # symbol is empty | ||
| * # funcPtr pointer is null | ||
| * # Invalid flag | ||
| * Test source | ||
| * ------------------------ | ||
| * - unit/device/hipGetDriverEntryPoint.cc | ||
| * Test requirements | ||
| * ------------------------ | ||
| * - HIP_VERSION >= 7.1 | ||
| */ | ||
|
|
||
| TEST_CASE("Unit_hipGetDriverEntryPoint_spt_Negative") { | ||
| void* funcPtr = nullptr; | ||
| hipDriverEntryPointQueryResult status; | ||
|
|
||
| SECTION("Empty string as symbol") { | ||
| HIP_CHECK_ERROR(hipGetDriverEntryPoint_spt("", &funcPtr, hipEnableDefault, &status), | ||
| hipErrorInvalidValue); | ||
| } | ||
|
|
||
| SECTION("funtion pointer is nullptr") { | ||
| HIP_CHECK_ERROR( | ||
| hipGetDriverEntryPoint_spt("hipGetDeviceCount", nullptr, hipEnableDefault, &status), | ||
| hipErrorInvalidValue); | ||
| } | ||
|
|
||
| SECTION("Invalid flag") { | ||
| HIP_CHECK_ERROR(hipGetDriverEntryPoint_spt("hipGetDeviceCount", &funcPtr, -1, &status), | ||
| hipErrorInvalidValue); | ||
| } | ||
| } | ||
| /** | ||
| * End doxygen group DeviceTest. | ||
| * @} | ||
| */ | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add one non zero check as well?
For some reason if it fails, they both will compare against failed values and it will pass.
Something like
REQUIRE(count > 0)should help us.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed comments.