Skip to content

SWDEV-493792 - add split barriers for grid_group - #508

Merged
ammallya merged 7 commits into
developfrom
import/develop/ROCm_clr/pr-224
Jan 19, 2026
Merged

ammallya merged 7 commits into
developfrom
import/develop/ROCm_clr/pr-224

Conversation

@systems-assistant

Copy link
Copy Markdown
Contributor

Associated JIRA ticket number/Github issue number

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Continuous Integration

What were the changes?

Add split barriers for thread_block and grid_group

Updated CHANGELOG?

  • Yes
  • No, Does not apply to this PR.

Added/Updated documentation?

  • Yes
  • No, Does not apply to this PR.

Additional Checks

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally.
  • Any dependent changes have been merged.

🔁 Imported from ROCm/clr#224
🧑‍💻 Originally authored by @rocm-devops

Comment thread projects/clr/CHANGELOG.md Resolved
@cjatin
cjatin requested a review from a team as a code owner September 24, 2025 09:32
@github-actions github-actions Bot added documentation Improvements or additions to documentation project: hip labels Sep 24, 2025
@cjatin
cjatin force-pushed the import/develop/ROCm_clr/pr-224 branch from 41b4b44 to bb8bcec Compare October 31, 2025 15:51
@cjatin
cjatin force-pushed the import/develop/ROCm_clr/pr-224 branch from bb8bcec to 218057e Compare November 10, 2025 18:23
@cjatin

cjatin commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

Its failing CI because device libs changes are not present in the build thats being used to compile/run the CI jobs.
https://github.com/ROCm/llvm-project/blob/12daccd960c2f67a1604704e43193440f40a2db5/amd/device-libs/ockl/src/cg.cl#L115

@cjatin
cjatin force-pushed the import/develop/ROCm_clr/pr-224 branch 2 times, most recently from 44bc634 to a489db1 Compare December 1, 2025 15:39
@cjatin
cjatin force-pushed the import/develop/ROCm_clr/pr-224 branch from a489db1 to 399fe58 Compare December 5, 2025 13:18
@cjatin
cjatin force-pushed the import/develop/ROCm_clr/pr-224 branch from 897458b to 3bab9a9 Compare December 15, 2025 13:10
@cjatin
cjatin force-pushed the import/develop/ROCm_clr/pr-224 branch 2 times, most recently from acc9487 to 5299bb0 Compare January 12, 2026 09:22
@litvaOo
litvaOo force-pushed the import/develop/ROCm_clr/pr-224 branch 2 times, most recently from aa5d262 to 02d30fc Compare January 14, 2026 08:20
@cjatin
cjatin force-pushed the import/develop/ROCm_clr/pr-224 branch from 02d30fc to b44ecc7 Compare January 16, 2026 00:00
@mangupta
mangupta force-pushed the import/develop/ROCm_clr/pr-224 branch from b44ecc7 to 3657f6a Compare January 19, 2026 08:26
@ammallya
ammallya merged commit 88f07ba into develop Jan 19, 2026
18 of 20 checks passed
@ammallya
ammallya deleted the import/develop/ROCm_clr/pr-224 branch January 19, 2026 17:17
systems-assistant Bot pushed a commit to ROCm/clr that referenced this pull request Jan 19, 2026
* SWDEV-493792 - add split barriers for grid_group

* add tests

* Update change log

* Add Navi4 split barrier

* Update docs

* Use new Catch2 Approx macro

* Update split_barrier.cc to check for coop groups
[rocm-systems] ROCm/rocm-systems#508 (commit 88f07ba)
systems-assistant Bot pushed a commit to ROCm/hip that referenced this pull request Jan 19, 2026
* SWDEV-493792 - add split barriers for grid_group

* add tests

* Update change log

* Add Navi4 split barrier

* Update docs

* Use new Catch2 Approx macro

* Update split_barrier.cc to check for coop groups
[rocm-systems] ROCm/rocm-systems#508 (commit 88f07ba)
systems-assistant Bot pushed a commit to ROCm/hip-tests that referenced this pull request Jan 19, 2026
* SWDEV-493792 - add split barriers for grid_group

* add tests

* Update change log

* Add Navi4 split barrier

* Update docs

* Use new Catch2 Approx macro

* Update split_barrier.cc to check for coop groups
[rocm-systems] ROCm/rocm-systems#508 (commit 88f07ba)
ammallya pushed a commit that referenced this pull request Jan 30, 2026
…es. (#508)

* * rocDecode/VP9: Added support for video size change (scaling down) on inter frames.
 - A new reconfigure mode is added, where we keep the existing VAAPI surfaces and context, and work on the smaller images and store the images in the surfaces.

* * rocDecode/VP9 resize: Added changes based on review comments.
ammallya pushed a commit that referenced this pull request Jan 30, 2026
…es. (#508)

* * rocDecode/VP9: Added support for video size change (scaling down) on inter frames.
 - A new reconfigure mode is added, where we keep the existing VAAPI surfaces and context, and work on the smaller images and store the images in the surfaces.

* * rocDecode/VP9 resize: Added changes based on review comments.

[ROCm/rocdecode commit: 2af7bbf]
dayatsin-amd pushed a commit that referenced this pull request Apr 7, 2026
…508)

* Fix PSDB trigger: use pull_request_target with re-trigger detection

* Change pull_request_target to pull_request event

* Refactor input parameters for CI workflow
kcossett-amd added a commit that referenced this pull request Jul 20, 2026
## Motivation

<!-- Explain the purpose of this PR and the goals it aims to achieve.
-->

`ROCprofiler-SDK`'s #6276 has made a CI warning that would previously
crash some `selective-region` tests non-fatal.
Now we can re-enable the remaining tests.

## Technical Details

Remove the following from the common TheRock exclusion list on `gfx950`
workflow AND `test_categories.yaml`:
```
selective-region-region-1-filter.*
selective-region-region-2-and-3.*
selective-region-no-marker-region-1-filter.*
```

<!-- Explain the changes along with any relevant GitHub links. -->

## Issue Tracking

<!-- Include a GitHub Issue and/or JIRA ID. Do not post any full JIRA
links here. -->
<!-- GitHub issue: #1234 -->
<!-- JIRA ID: EXAMPLECOMPONENT-1234 -->

Jira ID: AIPROFSYST-521

## Test Plan

<!-- Explain any relevant testing done to verify this PR. -->

Workflows + TheRock CI

## Test Result

<!-- Briefly summarize test outcomes. -->

`gfx950` tests pass:
https://github.com/ROCm/rocm-systems/actions/runs/29582264277/job/87890685718?pr=8759

TheRock CI tests pass:
https://github.com/ROCm/rocm-systems/actions/runs/29584647543/job/87915973657?pr=8759
```
        Start 488: selective-region-no-filter-start-stop-sys-run
355/473 Test #488: selective-region-no-filter-start-stop-sys-run ...................................................................................................................................   Passed    6.85 sec
        Start 489: selective-region-no-filter-start-stop-sampling
356/473 Test #489: selective-region-no-filter-start-stop-sampling ..................................................................................................................................   Passed    6.80 sec
        Start 490: selective-region-no-filter-push-pop-sys-run
357/473 Test #490: selective-region-no-filter-push-pop-sys-run .....................................................................................................................................   Passed    6.82 sec
        Start 491: selective-region-no-filter-push-pop-sampling
358/473 Test #491: selective-region-no-filter-push-pop-sampling ....................................................................................................................................   Passed    6.82 sec
        Start 492: selective-region-region-1-filter-start-stop-sys-run
359/473 Test #492: selective-region-region-1-filter-start-stop-sys-run .............................................................................................................................   Passed    6.09 sec
        Start 493: selective-region-region-1-filter-start-stop-sampling
360/473 Test #493: selective-region-region-1-filter-start-stop-sampling ............................................................................................................................   Passed    6.11 sec
        Start 494: selective-region-region-1-filter-push-pop-sys-run
361/473 Test #494: selective-region-region-1-filter-push-pop-sys-run ...............................................................................................................................   Passed    6.12 sec
        Start 495: selective-region-region-1-filter-push-pop-sampling
362/473 Test #495: selective-region-region-1-filter-push-pop-sampling ..............................................................................................................................   Passed    6.12 sec
        Start 496: selective-region-region-2-and-3-filter-start-stop-sys-run
363/473 Test #496: selective-region-region-2-and-3-filter-start-stop-sys-run .......................................................................................................................   Passed    5.93 sec
        Start 497: selective-region-region-2-and-3-filter-start-stop-sampling
364/473 Test #497: selective-region-region-2-and-3-filter-start-stop-sampling ......................................................................................................................   Passed    5.94 sec
        Start 498: selective-region-region-2-and-3-filter-push-pop-sys-run
365/473 Test #498: selective-region-region-2-and-3-filter-push-pop-sys-run .........................................................................................................................   Passed    5.93 sec
        Start 499: selective-region-region-2-and-3-filter-push-pop-sampling
366/473 Test #499: selective-region-region-2-and-3-filter-push-pop-sampling ........................................................................................................................   Passed    5.95 sec
        Start 500: selective-region-pause-no-filter-inside-start-stop-sys-run
367/473 Test #500: selective-region-pause-no-filter-inside-start-stop-sys-run ......................................................................................................................   Passed    4.79 sec
        Start 501: selective-region-pause-no-filter-inside-start-stop-sampling
368/473 Test #501: selective-region-pause-no-filter-inside-start-stop-sampling .....................................................................................................................   Passed    4.76 sec
        Start 502: selective-region-pause-no-filter-inside-push-pop-sys-run
369/473 Test #502: selective-region-pause-no-filter-inside-push-pop-sys-run ........................................................................................................................   Passed    4.80 sec
        Start 503: selective-region-pause-no-filter-inside-push-pop-sampling
370/473 Test #503: selective-region-pause-no-filter-inside-push-pop-sampling .......................................................................................................................   Passed    4.80 sec
        Start 504: selective-region-pause-no-filter-before-start-stop-sys-run
371/473 Test #504: selective-region-pause-no-filter-before-start-stop-sys-run ......................................................................................................................   Passed    4.80 sec
        Start 505: selective-region-pause-no-filter-before-start-stop-sampling
372/473 Test #505: selective-region-pause-no-filter-before-start-stop-sampling .....................................................................................................................   Passed    4.81 sec
        Start 506: selective-region-pause-no-filter-before-push-pop-sys-run
373/473 Test #506: selective-region-pause-no-filter-before-push-pop-sys-run ........................................................................................................................   Passed    4.79 sec
        Start 507: selective-region-pause-no-filter-before-push-pop-sampling
374/473 Test #507: selective-region-pause-no-filter-before-push-pop-sampling .......................................................................................................................   Passed    4.79 sec
        Start 508: selective-region-pause-no-filter-outside-start-stop-sys-run
375/473 Test #508: selective-region-pause-no-filter-outside-start-stop-sys-run .....................................................................................................................   Passed    4.81 sec
        Start 509: selective-region-pause-no-filter-outside-start-stop-sampling
376/473 Test #509: selective-region-pause-no-filter-outside-start-stop-sampling ....................................................................................................................   Passed    4.77 sec
        Start 510: selective-region-pause-no-filter-outside-push-pop-sys-run
377/473 Test #510: selective-region-pause-no-filter-outside-push-pop-sys-run .......................................................................................................................   Passed    4.82 sec
        Start 511: selective-region-pause-no-filter-outside-push-pop-sampling
378/473 Test #511: selective-region-pause-no-filter-outside-push-pop-sampling ......................................................................................................................   Passed    4.81 sec
        Start 512: selective-region-pause-filtered-inside-start-stop-sys-run
379/473 Test #512: selective-region-pause-filtered-inside-start-stop-sys-run .......................................................................................................................   Passed    4.55 sec
        Start 513: selective-region-pause-filtered-inside-start-stop-sampling
380/473 Test #513: selective-region-pause-filtered-inside-start-stop-sampling ......................................................................................................................   Passed    4.67 sec
        Start 514: selective-region-pause-filtered-inside-push-pop-sys-run
381/473 Test #514: selective-region-pause-filtered-inside-push-pop-sys-run .........................................................................................................................   Passed    4.55 sec
        Start 515: selective-region-pause-filtered-inside-push-pop-sampling
382/473 Test #515: selective-region-pause-filtered-inside-push-pop-sampling ........................................................................................................................   Passed    4.54 sec
        Start 516: selective-region-pause-filtered-before-start-stop-sys-run
383/473 Test #516: selective-region-pause-filtered-before-start-stop-sys-run .......................................................................................................................   Passed    4.53 sec
        Start 517: selective-region-pause-filtered-before-start-stop-sampling
384/473 Test #517: selective-region-pause-filtered-before-start-stop-sampling ......................................................................................................................   Passed    4.57 sec
        Start 518: selective-region-pause-filtered-before-push-pop-sys-run
385/473 Test #518: selective-region-pause-filtered-before-push-pop-sys-run .........................................................................................................................   Passed    4.53 sec
        Start 519: selective-region-pause-filtered-before-push-pop-sampling
386/473 Test #519: selective-region-pause-filtered-before-push-pop-sampling ........................................................................................................................   Passed    4.68 sec
        Start 520: selective-region-pause-filtered-outside-start-stop-sys-run
387/473 Test #520: selective-region-pause-filtered-outside-start-stop-sys-run ......................................................................................................................   Passed    4.53 sec
        Start 521: selective-region-pause-filtered-outside-start-stop-sampling
388/473 Test #521: selective-region-pause-filtered-outside-start-stop-sampling .....................................................................................................................   Passed    4.56 sec
        Start 522: selective-region-pause-filtered-outside-push-pop-sys-run
389/473 Test #522: selective-region-pause-filtered-outside-push-pop-sys-run ........................................................................................................................   Passed    4.55 sec
        Start 523: selective-region-pause-filtered-outside-push-pop-sampling
390/473 Test #523: selective-region-pause-filtered-outside-push-pop-sampling .......................................................................................................................   Passed    4.52 sec
        Start 524: selective-region-pause-no-marker-inside-start-stop-sys-run
391/473 Test #524: selective-region-pause-no-marker-inside-start-stop-sys-run ......................................................................................................................   Passed    3.37 sec
        Start 525: selective-region-pause-no-marker-inside-start-stop-sampling
392/473 Test #525: selective-region-pause-no-marker-inside-start-stop-sampling .....................................................................................................................   Passed    3.46 sec
        Start 526: selective-region-pause-no-marker-inside-push-pop-sys-run
393/473 Test #526: selective-region-pause-no-marker-inside-push-pop-sys-run ........................................................................................................................   Passed    3.35 sec
        Start 527: selective-region-pause-no-marker-inside-push-pop-sampling
394/473 Test #527: selective-region-pause-no-marker-inside-push-pop-sampling .......................................................................................................................   Passed    3.52 sec
        Start 528: selective-region-pause-no-marker-before-start-stop-sys-run
395/473 Test #528: selective-region-pause-no-marker-before-start-stop-sys-run ......................................................................................................................   Passed    3.40 sec
        Start 529: selective-region-pause-no-marker-before-start-stop-sampling
396/473 Test #529: selective-region-pause-no-marker-before-start-stop-sampling .....................................................................................................................   Passed    3.36 sec
        Start 530: selective-region-pause-no-marker-before-push-pop-sys-run
397/473 Test #530: selective-region-pause-no-marker-before-push-pop-sys-run ........................................................................................................................   Passed    3.37 sec
        Start 531: selective-region-pause-no-marker-before-push-pop-sampling
398/473 Test #531: selective-region-pause-no-marker-before-push-pop-sampling .......................................................................................................................   Passed    3.36 sec
        Start 532: selective-region-pause-no-marker-outside-start-stop-sys-run
399/473 Test #532: selective-region-pause-no-marker-outside-start-stop-sys-run .....................................................................................................................   Passed    3.35 sec
        Start 533: selective-region-pause-no-marker-outside-start-stop-sampling
400/473 Test #533: selective-region-pause-no-marker-outside-start-stop-sampling ....................................................................................................................   Passed    3.39 sec
        Start 534: selective-region-pause-no-marker-outside-push-pop-sys-run
401/473 Test #534: selective-region-pause-no-marker-outside-push-pop-sys-run .......................................................................................................................   Passed    3.49 sec
        Start 535: selective-region-pause-no-marker-outside-push-pop-sampling
402/473 Test #535: selective-region-pause-no-marker-outside-push-pop-sampling ......................................................................................................................   Passed    3.51 sec
        Start 536: selective-region-no-marker-region-1-filter-start-stop-sys-run
403/473 Test #536: selective-region-no-marker-region-1-filter-start-stop-sys-run ...................................................................................................................   Passed    4.81 sec
        Start 537: selective-region-no-marker-region-1-filter-start-stop-sampling
404/473 Test #537: selective-region-no-marker-region-1-filter-start-stop-sampling ..................................................................................................................   Passed    4.82 sec
```

## Submission Checklist

- [x] Look over the contributing guidelines at
https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants