[SWDEV-552020/SWDEV-563971] Fail memory partition tests if ASIC supports memory partitions & kmod not installed#2695
Merged
JeniferC99 merged 2 commits intoFeb 6, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances memory partition testing in AMD SMI by adding proper validation for kernel module (kmod) availability and improving test assertions based on driver reload success. The changes ensure that memory partition tests fail gracefully when kmod is not installed on systems that support memory partitions, rather than allowing tests to pass incorrectly.
Changes:
- Added kmod installation detection to fail tests early when required tooling is missing
- Enhanced test assertions to differentiate between successful driver reloads with/without NPS mode changes
- Improved verbose logging to track memory partition state transitions throughout testing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
charis-poag-amd
force-pushed
the
users/charis-poag-amd/SWDEV-552020_MemoryPartitionFailureIfKmodNotInstalled
branch
2 times, most recently
from
9d542f6 to
1f74229
Compare
charis-poag-amd
changed the title
charis-poag-amd
changed the title
charis-poag-amd
changed the title
charis-poag-amd
changed the title
eble-amd
reviewed
Jan 20, 2026
charis-poag-amd
force-pushed
the
users/charis-poag-amd/SWDEV-552020_MemoryPartitionFailureIfKmodNotInstalled
branch
from
1f74229 to
3ca6081
Compare
charis-poag-amd
force-pushed
the
users/charis-poag-amd/SWDEV-552020_MemoryPartitionFailureIfKmodNotInstalled
branch
3 times, most recently
from
f05a9c6 to
c4ce624
Compare
charis-poag-amd
force-pushed
the
users/charis-poag-amd/SWDEV-552020_MemoryPartitionFailureIfKmodNotInstalled
branch
from
c4ce624 to
c698e65
Compare
marifamd
approved these changes
Feb 3, 2026
charis-poag-amd
force-pushed
the
users/charis-poag-amd/SWDEV-552020_MemoryPartitionFailureIfKmodNotInstalled
branch
3 times, most recently
from
11ae0ec to
3322829
Compare
Contributor
Author
|
/AzurePipelines run rocm-ci-caller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
charis-poag-amd
force-pushed
the
users/charis-poag-amd/SWDEV-552020_MemoryPartitionFailureIfKmodNotInstalled
branch
3 times, most recently
from
d4372d7 to
3ab5024
Compare
…rts memory partitions Updates: - Now provide more details on kmod being missing and how to install. - Cleaned up comparison logic, regardless if memory partition set was successful or not.
charis-poag-amd
force-pushed
the
users/charis-poag-amd/SWDEV-552020_MemoryPartitionFailureIfKmodNotInstalled
branch
from
3ab5024 to
613fccf
Compare
Collaborator
|
http://rocm-ci.amd.com/job/rocm-tests/39494/ - overrode, good to merge |
JeniferC99
deleted the
users/charis-poag-amd/SWDEV-552020_MemoryPartitionFailureIfKmodNotInstalled
branch
amd-josnarlo
pushed a commit
that referenced
this pull request
Feb 9, 2026
…rts memory partitions & kmod not installed (#2695) * [SWDEV-552020/SWDEV-563971] Fail memory partition tests if ASIC supports memory partitions Updates: - Now provide more details on kmod being missing and how to install. - Cleaned up comparison logic, regardless if memory partition set was successful or not. * Change kmod install check to be a one-time check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[SWDEV-552020/SWDEV-563971] Fail memory partition tests if ASIC supports memory partitions & kmod not installed
Updates:
successful or not.