[hipblsalt] Fix leaky hip::device dependency#855
Merged
Conversation
Contributor
Author
|
This only changes next-cmake dir - merging. |
assistant-librarian Bot
pushed a commit
to ROCm/hipBLASLt
that referenced
this pull request
Jul 26, 2025
[hipblsalt] Fix leaky hip::device dependency - Do note use PUBLIC linkage for hip::device - Add logic to project config to catch when hip::device is added to interface link libraries - Fixes the regression noted in ROCm/rocm-libraries#650 (comment) - Root cause diagnosis of the issue: https://chatgpt.com/share/68841788-4564-800d-a6a1-e000c668c0fb
ScottTodd
added a commit
to ROCm/TheRock
that referenced
this pull request
Jul 26, 2025
Cherry-pick of ROCm/rocm-libraries#855 for testing, with conflicts resolved manually. Patches did not apply cleanly on a roll-up, as ROCm/rocm-libraries#702 is still under review and has conflicts too. Testing at: * Linux gfx942: https://github.com/ROCm/TheRock/actions/runs/16535937296 * Windows gfx110X-dgpu: https://github.com/ROCm/TheRock/actions/runs/16535942310
dsaffars
pushed a commit
to dsaffars/rocm-libraries
that referenced
this pull request
Jul 28, 2025
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.8.1 to 1.8.2. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.8.2/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.8.1...v1.8.2) --- updated-dependencies: - dependency-name: rocm-docs-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> [ROCm/rocSPARSEcommit: 0015150]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.