Skip to content

[hipblsalt] Fix leaky hip::device dependency #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidd-amd merged 1 commit into from
Jul 26, 2025
Merged

[hipblsalt] Fix leaky hip::device dependency #855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion projects/hipblaslt/next-cmake/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@ if(TENSILELITE_ENABLE_HOST OR HIPBLASLT_ENABLE_HOST)
target_link_libraries(tensilelite-host
PUBLIC
rocisa::rocisa-cpp
PRIVATE
hip::device
)

Expand All @@ -291,8 +292,8 @@ if(HIPBLASLT_ENABLE_HOST)
target_link_libraries(hipblaslt
PUBLIC
roc::${hipblas_target}
hip::device
PRIVATE
hip::device
tensilelite-host
${CMAKE_DL_LIBS}
${rocTracer}
Expand Down Expand Up @@ -386,6 +387,12 @@ if(HIPBLASLT_ENABLE_HOST)
NAMESPACE roc::
)

configure_file(
"${CMAKE_CURRENT_SOURCE_DIR}/cmake/hipblaslt-config.cmake.in"
"${CMAKE_CURRENT_BINARY_DIR}/hipblaslt-config.cmake"
COPYONLY
)

if( LEGACY_HIPBLAS_DIRECT )
rocm_package_add_dependencies(DEPENDS "hipblas >= 0.50.0")
else()
Expand Down
15 changes: 14 additions & 1 deletion projects/hipblaslt/next-cmake/cmake/hipblaslt-config.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,22 @@
# THE SOFTWARE.
#
# ########################################################################

include(CMakeFindDependencyMacro)
list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/../../../share/cmake/hipblaslt")
find_dependency(hip)

find_dependency(hipblas-common)

include("${CMAKE_CURRENT_LIST_DIR}/hipblaslt-targets.cmake")

block(SCOPE_FOR VARIABLES)
if(NOT TARGET roc::hipblaslt)
message(FATAL_ERROR "roc::hipblaslt target is missing")
endif()

get_target_property(link_libraries roc::hipblaslt INTERFACE_LINK_LIBRARIES)

if(link_libraries AND "hip::device" IN_LIST link_libraries)
message(FATAL_ERROR "Do not export targets with hip::device as an interface link library")
endif()
endblock()