Cherry-pick hipBLASLt fix for hip::device dep.#1132
Conversation
|
If ci says good, lgtm. That cherrypick has an additional assert that should now fail the CI if this ever regressed. |
|
Windows PyTorch wheel builds succeeded: https://github.com/ROCm/TheRock/actions/runs/16536876692 Linux got successful builds but failed in workflow scripting code we changed recently. Looks easy enough to fix. cc @marbre @araravik-psd TheRock/.github/workflows/build_portable_linux_pytorch_wheels.yml Lines 138 to 149 in 4b1ccff TheRock/build_tools/github_actions/write_torch_version.py Lines 11 to 15 in 4b1ccff
I also had some ideas for how to continue expanding on that script in #1110 (comment) |
|
I'm working on fixing the script. I added more logging in https://github.com/ROCm/TheRock/tree/users/scotttodd/write-torch-versions and triggered a test job at https://github.com/ROCm/TheRock/actions/runs/16542014324/job/46784536594 Logs: actions/checkout#785 has some clues, looks like a difference between |
|
Script fixes: #1133. Could scope that down a bit to make it easier to land. |
Cherry-pick of ROCm/rocm-libraries#855 for testing, with conflicts resolved manually. Patches did not apply cleanly on a roll-up, as ROCm/rocm-libraries#702 is still under review and has conflicts too.
Testing at: