Fix linkage for tensilelite-host target and bump mxdatagen#702
Closed
davidd-amd wants to merge 3 commits into
Closed
Fix linkage for tensilelite-host target and bump mxdatagen#702davidd-amd wants to merge 3 commits into
davidd-amd wants to merge 3 commits into
Conversation
davidd-amd
requested review from
a team,
AlexBrownAMD,
Jinp800125,
KKyang,
Serge45,
TonyYHsieh,
aazz44ss,
babakpst,
bnemanich,
hcman2,
imcarsonliao,
jichangjichang,
msujon-AMD,
solaslin and
vin-huang
as code owners
ibrahimw1
previously approved these changes
Jul 16, 2025
bstefanuk
reviewed
Jul 16, 2025
bstefanuk
reviewed
Jul 16, 2025
marbre
requested changes
Jul 16, 2025
davidd-amd
force-pushed
the
users/ellosel/hipblaslt-hotfix-for-therock
branch
from
f7a99b7 to
72e1db5
Compare
davidd-amd
changed the title
davidd-amd
changed the title
marbre
reviewed
Jul 17, 2025
Member
marbre
left a comment
marbre
left a comment
There was a problem hiding this comment.
This fixes most of the failures I've been hitting when compiling via TheRock. What remains is
5.7 /TheRock/math-libs/BLAS/hipBLASLt/next-cmake/../library/src/amd_detail/rocblaslt/src/include/rocroller_host_internal.hpp:36:10: fatal error: 'Tensile/analytical/Utils.hp
p' file not found
5.7 36 | #include <Tensile/analytical/Utils.hpp>
5.7 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
5.7 1 error generated.
ScottTodd
added a commit
to ROCm/TheRock
that referenced
this pull request
Jul 26, 2025
Cherry-pick of ROCm/rocm-libraries#855 for testing, with conflicts resolved manually. Patches did not apply cleanly on a roll-up, as ROCm/rocm-libraries#702 is still under review and has conflicts too. Testing at: * Linux gfx942: https://github.com/ROCm/TheRock/actions/runs/16535937296 * Windows gfx110X-dgpu: https://github.com/ROCm/TheRock/actions/runs/16535942310
marbre
reviewed
Jul 29, 2025
Member
marbre
left a comment
marbre
left a comment
There was a problem hiding this comment.
I rebase this for the use in TheRock on a more recent hipBLASLt commit (still tracking the ROCm/hipBLASLt repo): https://github.com/ROCm/TheRock/blob/7b4a3fdcc7fd32a46f4a3bf1891d4a91b1b88a8e/patches/amd-mainline/hipBLASLt/0001-Fix-linkage-for-tensilelite-host-target-and-bump-mxd.patch
This resolved the build failures we were previously facing. Thus, rebasing and merging this would be much apprechiated.
Member
|
Link to the rebased patch applied in TheRock to rocm-libraries: https://github.com/ROCm/TheRock/blob/ddbf0acb10f63e9c6dfe586da132505fe9231eef/patches/amd-mainline/rocm-libraries/0002-Fix-linkage-for-tensilelite-host-target-and-bump-mxd.patch |
lamikr
pushed a commit
that referenced
this pull request
Aug 19, 2025
- Updates linkage for tensilelite-host msgpack dependency because it is a build and usage requirement. - Add tensilelite-host to rocroller host target Adopted from #702.
HPC-Ken
pushed a commit
to HPC-Ken/rocm-libraries
that referenced
this pull request
Aug 22, 2025
- Updates linkage for tensilelite-host msgpack dependency because it is a build and usage requirement. - Add tensilelite-host to rocroller host target Adopted from ROCm#702.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.