refactor(tensilelite): move package to lowercase namespace by Alex-Vasile · Pull Request #12150 · ROCm/rocm-libraries

Alex-Vasile · 2026-09-15T23:43:30Z

JIRA ID : AIHPBLAS-3989

DO NOT REVERT. Any breakages caused by this PR should be fixed forward due to the difficulty associated in getting this through CI before another merge conflict arises.

Motivation

The Python implementation is called TensileLite but is stored and imported as Tensile. This PR performs the physical package move while keeping existing Python callers operational through a temporary compatibility namespace.

Technical Details

Move the complete Tensile/ implementation and test tree to tensilelite/.
Make tensilelite the canonical package and activate the one-way Tensile → tensilelite shim.
Update package discovery, source manifests, CMake code-generation paths, test discovery, coverage paths, and required resource locations.
Keep tests, legacy launchers, and external Python consumers on Tensile imports for migration in later PRs.
Depends on 03-inactive-compat-bridge.

Test Plan

Verify source and wheel imports through both namespace spellings, package resources, python -m, legacy launchers, and representative unit tests.

Test Result

Compatibility wheel check passed: Tensile.resources and tensilelite.resources resolve to one module object with lowercase canonical metadata.
Focused package/import validation passed on the compatibility stack.
Automated GitHub checks pass.

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/GOVERNANCE.md#pull-requests.

Risk level

High (4/5): this moves the complete Python package and changes build and packaging paths, while the temporary shim preserves the old import interface.

therock-pr-bot · 2026-09-16T14:17:11Z

✅ All Checks Passed — Ready for Review

Check	Status	Details
📝 PR Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	✅ Pass	—
🔎 pre-commit	✅ Pass	—
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—
🤖 therock-pr-bot	✅ Pass	—

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

therock-pr-bot · 2026-09-16T14:17:45Z

Pre-commit check failed

⛔ pre-commit failed

Please run locally:

python -m pip install pre-commit
pre-commit install
pre-commit run --all-files --show-diff-on-failure

This repo uses .pre-commit-config.yaml.

JIRA ID : AIHPBLAS-3989 ## Motivation The pre-commit workflow computes changed paths to select sparse-checkout directories and determine whether a project needs optional hook dependencies. [PR #12150](#12150) changes 1,484 files and produces a 148,368-byte path list. When the workflow copied that list into the `CHANGED_FILES` environment variable, the Linux runner could not start Bash and reported `Argument list too long`. ## Technical Details - Write the sorted changed paths already computed by `pre_commit_helper.py` to a temporary file under `RUNNER_TEMP`. - Expose only the temporary file's pathname as a GitHub Actions step output. - Read that file when deciding whether a project needs optional dependencies. - Preserve the existing resolved three-dot diff base, checked Git execution, timeout, and sparse-checkout behavior. - Fail the project-detection step if the changed-files file cannot be read instead of treating the project as unchanged. ## Test Plan Exercise the helper with a changed-path list larger than Linux's per-environment-entry limit, run the complete `.github/scripts` test suite, run the repository pre-commit hooks for the changed files, and check project detection against the actual 1,484-file namespace diff. ## Test Result - Original failure: [pre-commit run 35121163236](https://github.com/ROCm/rocm-libraries/actions/runs/35121163236/job/104879231064) failed before Bash started with `Argument list too long`. - `python -m pytest .github/scripts/tests -q`: `136 passed`, `8 xfailed`, and `34 subtests passed`. - Targeted repository pre-commit hooks passed for the helper, its tests, and the workflow. - The actual 1,484-path, 148,368-byte diff produced `hipblaslt_changed=true` and `hipdnn_changed=false`; an unreadable file exited with status `2`. - Automated GitHub checks are pending for the updated commit. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/GOVERNANCE.md#pull-requests. ## Risk level Medium (3/5): this changes dependency detection in the repository's pre-commit validation path. It does not change product or GPU behavior.

newling

LGTM, I assume you've checked that these files can be removed safely!

Alex-Vasile · 2026-09-21T16:42:25Z

LGTM, I assume you've checked that these files can be removed safely!

No. Let me rebase again. It's continual conflicts from rebases as develop keeps changing under me. One moment.

Move every active test and coverage path with the package tree, including files added on develop after the migration was authored. Keep moved source blobs byte-identical where no namespace edit is required, and align the pre-commit selector, test categories, and package metadata expectations with the lowercase location.

When an aliased package import loads canonical descendants, register those descendants under the alias before Python imports them again. This prevents a legacy submodule import from replacing an exported class on the shared canonical parent package.

#12150 moved the TensileLite tree from Tensile/ to tensilelite/. Move this branch's two new harness unit tests with it, point the rocjitsu job at tensilelite/Tests/common/test_config.py in the installed tree, and rekey the recorded test durations to the new test ids. The durations now take the latest per-PR run's values (run 37913200805) over the older ones. Co-Authored-By: Claude <noreply@anthropic.com>

JIRA ID : AIHPBLAS-3989 ## Motivation PR #12150 moved TensileLite's Python package to `tensilelite/`. Some CI commands and source references still use the old `Tensile/` path. ## Technical Details Update those paths in component CI, the snapshot guard workflow, tests, and documentation. ## Test Result The 29 changed-subtree tests and 44 snapshot-guard tests passed. The snapshot guard also ran against this diff. Automated GitHub checks are pending. ## Risk level Low (2/5): path-only changes; CI selection and the snapshot check are affected.

assistant-librarian · 2026-10-12T14:17:02Z

TheRock Submodule Bump Activity

Newest first

2026-10-12 — Included in TheRock via ROCm/TheRock#8933.

Develop's #12150 moved tensilelite/Tensile/ to tensilelite/tensilelite/; git's rename detection carries this branch's edits to Architectures.py, GSU.py, KernelWriterAssembly.py, MatrixInstruction.py and memory_gfx.h over to the new paths. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

…13278) JIRA ID : AIHPBLAS-3989 ## Motivation #12150 moves the Python implementation from `Tensile` to `tensilelite` while keeping `Tensile` importable through a temporary compatibility package. New imports using the old name would add references that must be removed before that package can go away. ## Technical Details - Add a root pre-commit hook that checks newly added or modified import statements in Python files under both package roots. It rejects absolute imports beginning with `Tensile` or `tensilelite`, so internal modules use package-relative imports. - Check changed lines only, allowing existing imports to remain during the migration. The checker ignores strings, comments, and files under `Tests/`. - Allow the one absolute import needed by `Tensile/__init__.py` to install the compatibility alias. This exception will be removed in [#12162](#12162) when that PR removes the bridge. This PR depends on [#12150](#12150). ## Test Plan Run the checker's Python unit tests, which exercise staged and PR-range changes, both package roots, the bridge exception, and existing imports. Run the repository's pre-commit checks in PR CI. GPU testing is unnecessary because this change only examines Python source. ## Test Result - Checker unit tests: 34 passed. - `git diff --check`: passed. - PR CI: pending. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/GOVERNANCE.md#pull-requests. ## Risk level Medium (3/5): the new check can reject TensileLite Python changes in pre-commit CI. It does not change packaged code or GPU behavior.

…d scripts (#13729) Resolves #13727 ## Summary Adds a `github-ci-pr-quality` overlay on the `rocm-pr-quality` base skill for changes under `.github/`. It tells authors and reviewers where CI tests belong (extend an existing lane, not a new workflow per test), how to size runners and checkout, how to treat shared state in `ci-env`, and to read each affected project's TESTING.md before changing a lane or gate. It also covers what a CI job checks out (the PR merge ref, `refs/pull/<N>/merge`, so every lane tests the same tree) and requires CI references to be updated when files move or are deleted. A matching Copilot review instructions file loads it for `.github/**`. This is the second of two PRs; it is stacked on the root AGENTS.md PR (#13728), so its base is that branch until #13728 merges. ## Risk Assessment 1/5. Guidance for reviewers and AI assistants only. No workflow, script, or build changes, and the guidance is advisory. One behavior change: Copilot code review will start applying this guidance to PRs that touch `.github/**`. ## Related - Work tracking: #13727 - Depends on: #13728 (the root AGENTS.md PR, tracked in #13726) - Cases it is designed to catch: #12185, #13623 (reverted in #13698), and the stale paths left by #12150 (fixed in #13399) - Review input: a skill-forge review of the PR-quality skills (findings R2, R3, R4, R8, M4/R7 applied here; the helper findings M1, M2, M3, and R5 are fixed in ROCm/TheRock#6653; the rest of the base-skill findings are still open) - Base skill: `skills/rocm-pr-quality/` in ROCm/TheRock ## Testing Summary - `pre-commit` on the changed files passed. Every workflow, script, action value, and path the skill cites was checked against `origin/develop`. ## Testing Checklist - [x] pre-commit on the changed files - Status: Passed - [x] Cited paths and facts checked against `develop` - Status: Passed - [ ] PR CI - GitHub PR checks - Status: Pending ## Flags / Guardrails None. The guidance is advisory. ## Adjacent Tests Considered None apply; no code changes. ## Technical Changes - New `skills/github-ci-pr-quality/SKILL.md` with the TESTING.md cross-read, five CI change classes, and test-placement, runner-sizing, trigger-scope, tested-tree, and shared-state rules. Trigger scope includes checks that path filters match real files and that moves and deletes update CI in the same PR. It tightens stale-base and approvals, adds a review checklist, three worked examples, and a completed retrospective review of #12185 as a model of the required output. - Review contract: the overlay keeps review read-only (pre-commit runs in a throwaway checkout), and requires caller edits only for breaking workflow interface changes. - New `.github/instructions/github-ci-pr-quality.instructions.md` (`applyTo: ".github/**"`). - `AGENTS.md`: the planned catalog row now links to the skill, and the new instructions file is listed. ## Risk Acceptance / Waivers `W-DOC`: guidance only; no product or CI behavior changes. --------- Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions Bot added documentation project: hipblaslt project: hipsparselt github actions ci:hipsparselt-fast labels Sep 15, 2026

Alex-Vasile added this pull request to stack #12163 September 15, 2026 23:44

assistant-librarian Bot added the organization: ROCm label Sep 16, 2026

Alex-Vasile force-pushed the users/alvasile/AIHPBLAS-3989-namespace-split/04-move-and-enable-compat branch from 8b0facf to a3977ce Compare September 16, 2026 14:12

Alex-Vasile force-pushed the users/alvasile/AIHPBLAS-3989-namespace-split/03-inactive-compat-bridge branch from 47ee03b to d0dad98 Compare September 16, 2026 16:18

Alex-Vasile force-pushed the users/alvasile/AIHPBLAS-3989-namespace-split/04-move-and-enable-compat branch 2 times, most recently from 1699173 to 41e5abe Compare September 16, 2026 16:53

Alex-Vasile force-pushed the users/alvasile/AIHPBLAS-3989-namespace-split/03-inactive-compat-bridge branch from d0dad98 to 1dbde8c Compare September 16, 2026 16:53

Alex-Vasile removed this pull request from stack #12163 September 16, 2026 16:53

Alex-Vasile added this pull request to stack #12193 September 16, 2026 16:53

Alex-Vasile mentioned this pull request Sep 16, 2026

ci: avoid oversized pre-commit changed-file environment #12192

Merged

1 task

Alex-Vasile force-pushed the users/alvasile/AIHPBLAS-3989-namespace-split/04-move-and-enable-compat branch from 41e5abe to e361913 Compare September 16, 2026 17:46

Alex-Vasile force-pushed the users/alvasile/AIHPBLAS-3989-namespace-split/03-inactive-compat-bridge branch from 1dbde8c to ef85183 Compare September 16, 2026 17:46

Alex-Vasile force-pushed the users/alvasile/AIHPBLAS-3989-namespace-split/04-move-and-enable-compat branch from e361913 to a761a29 Compare September 16, 2026 18:40

Alex-Vasile force-pushed the users/alvasile/AIHPBLAS-3989-namespace-split/03-inactive-compat-bridge branch from ef85183 to 9c14e13 Compare September 16, 2026 18:40

Alex-Vasile force-pushed the users/alvasile/AIHPBLAS-3989-namespace-split/03-inactive-compat-bridge branch from 9c14e13 to bfee1f2 Compare September 17, 2026 18:21

Alex-Vasile force-pushed the users/alvasile/AIHPBLAS-3989-namespace-split/04-move-and-enable-compat branch 2 times, most recently from 95fbded to 2601ff2 Compare September 21, 2026 16:16

Alex-Vasile force-pushed the users/alvasile/AIHPBLAS-3989-namespace-split/03-inactive-compat-bridge branch from bfee1f2 to 61e0393 Compare September 21, 2026 16:16

newling approved these changes Sep 21, 2026

View reviewed changes

Alex-Vasile requested a review from newling September 21, 2026 16:41

Alex-Vasile force-pushed the users/alvasile/AIHPBLAS-3989-namespace-split/04-move-and-enable-compat branch from 2601ff2 to a493e67 Compare September 21, 2026 17:06

Alex-Vasile added 11 commits October 9, 2026 14:45

fix(hipblaslt): use moved TensileLite driver in race check

c902955

fix(hipblaslt): follow moved characterization docs in CODEOWNERS

88655e4

build(tensilelite): drop nonexistent cmake package data

f16c567

docs(tensilelite): update mutation skill package paths

24191ba

test(geko): use moved TensileLite launcher path

6d7cecd

style(tensilelite): preserve spacing through package move

1a13b58

docs(tensilelite): correct characterization source references

f75e738

fix(tensilelite): move new rocBLAS custom kernels with package

96761d6

fix(tensilelite): move new Solution UID tool with package

468a2d4

Alex-Vasile force-pushed the users/alvasile/AIHPBLAS-3989-namespace-split/04-move-and-enable-compat branch from 8366658 to 468a2d4 Compare October 9, 2026 14:46

talumbau disabled auto-merge October 9, 2026 15:15

talumbau merged commit 11d0433 into develop Oct 9, 2026
61 of 72 checks passed

talumbau deleted the users/alvasile/AIHPBLAS-3989-namespace-split/04-move-and-enable-compat branch October 9, 2026 15:16

Alex-Vasile mentioned this pull request Oct 9, 2026

fix(tensilelite): correct paths missed in #12150 #13399

Merged

Alex-Vasile mentioned this pull request Oct 9, 2026

fix(tensilelite): address AIHPBLAS-3989 path feedback #13409

Merged

1 task done

talumbau mentioned this pull request Oct 9, 2026

feat(hipblaslt): Add mesh-based solution selection for BF16 and TF32 #12199

Open

1 task

tony-davis mentioned this pull request Oct 9, 2026

docs(hipblaslt): record tactical testing gaps as the first step of a testing redesign #12997

Merged

1 task done

archana-ramalingam mentioned this pull request Oct 10, 2026

ci(gfx1250): self-build gfx1250-strict per PR #12983

Merged

1 task done

geotseng-amd mentioned this pull request Oct 12, 2026

fix(tensilelite): gfx1250 codegen fixes for e2e yamls #13488

Merged

1 task

fjankovi mentioned this pull request Oct 15, 2026

[Issue] Windows gfx110X-all: hipblaslt test fails — matmul_hipblaslt_h2f_1x1x64_TT NO solution found! #13480

Closed

tony-davis mentioned this pull request Oct 19, 2026

docs(ci): add github-ci-pr-quality overlay for workflows, actions, and scripts #13729

Merged

2 of 3 tasks

tony-davis mentioned this pull request Oct 30, 2026

test: adds tensilelite sia0 pgr2 characterization testing #8788

Open

2 of 3 tasks

Navigation Menu

Repository navigation

refactor(tensilelite): move package to lowercase namespace - #12150

refactor(tensilelite): move package to lowercase namespace#12150
talumbau merged 36 commits into
developfrom
users/alvasile/AIHPBLAS-3989-namespace-split/04-move-and-enable-compat

Alex-Vasile commented Sep 15, 2026 •

edited

Loading

Uh oh!

therock-pr-bot Bot commented Sep 16, 2026 •

edited

Loading

Uh oh!

therock-pr-bot Bot commented Sep 16, 2026

Uh oh!

newling left a comment

Uh oh!

Alex-Vasile commented Sep 21, 2026

Uh oh!

Uh oh!

assistant-librarian Bot commented Oct 12, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Alex-Vasile commented Sep 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Risk level

Uh oh!

therock-pr-bot Bot commented Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ All Checks Passed — Ready for Review

Uh oh!

therock-pr-bot Bot commented Sep 16, 2026

Pre-commit check failed

Uh oh!

newling left a comment

Choose a reason for hiding this comment

Uh oh!

Alex-Vasile commented Sep 21, 2026

Uh oh!

Uh oh!

assistant-librarian Bot commented Oct 12, 2026

TheRock Submodule Bump Activity

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Alex-Vasile commented Sep 15, 2026 •

edited

Loading

therock-pr-bot Bot commented Sep 16, 2026 •

edited

Loading