You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Verdict: hold. This bump adds new CI red beyond what's tracked in Project 231. MIOpen's hipBLASLt FP8/BFP8 GEMM tests fail deterministically on gfx942 (reproduced on rerun, and green in the nightlies on either side of this PR's base), and rocgdb-corefile breaks on a CLI flag mismatch. Code-owner review is also still required.
TheRock 7440cb8 to 8b46a27 (14 commits). Submodules that moved:
Submodule
Repo
Commits
Notable changes
rocm-systems
ROCm/rocm-systems
52
clr batch-copy kernarg fix (ROCm/rocm-systems#11650, the only HIP runtime change and the lead suspect for the FP8 miss), new rocddi systems layer, rccl test and perf work, hip-tests test-level discovery
debug-tools/rocgdb/source
ROCm/rocgdb
7
adds --gpu-corefile-tests to test_rocgdb.py, gcore test renames
math-libs/libhipcxx
ROCm/libhipcxx
2
Windows headertest path shortening, test requirements file
third-party/sysdeps/common/mesa-fork
ROCm/mesa-fork
340
upstream Mesa sync (radv/radeonsi/panvk), not on the compute path
rocm-libraries
ROCm/rocm-libraries
5
TheRock's own pointer; this repo's CI builds from the PR source, so it doesn't matter here
TheRock itself also adds the --gpu-corefile-tests CI switch (ROCm/TheRock#8563), an ASAN-debug nightly for gfx90a, and a ci:run-multi-gpu opt-in label.
Superseded by #12826 (TheRock c9bde5b), which includes everything here. The two reds from this one are clean there: MIOpen gfx94X FP8/BFP8 passes (I think it was a hipBLASLt race fixed by #12615, not the bump; details on #11116), and rocgdb-corefile passes now that rocgdb moved to f5e5294. I'd close this one and review #12826 instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated all pinned TheRock workflow and source refs to
8b46a27due to submodule bumpBaseline run ID: 36390205996