fix(rocprofiler-compute): wire test-compression for TheRock install-mode CI by jamessiddeley-amd · Pull Request #7421 · ROCm/TheRock

jamessiddeley-amd · 2026-08-17T15:33:12Z

Motivation

Added a test-compression gtest in #9711 of rocprofiler-compute,, but TheRock CI can't run it in install mode yet:

The post-hook sets install RPATH for the other gtests under libexec/rocprofiler-compute/tests/ but not test-compression
The subproject pulls bundled elfutils/libdrm/sqlite3 but not zlib, so pkg_check_modules(zlib) can link system libz instead of bundled sysdeps

The follow-up in rocm-systems repo is to add test-compression to test_categories.yaml after this merges.

Technical Details

Add test-compression to the RPATH post-hook foreach in profiler/post_hook_rocprofiler-compute.cmake.
Add ${THEROCK_BUNDLED_ZLIB} to rocprofiler-compute RUNTIME_DEPS in profiler/CMakeLists.txt.

Test Plan

Build with rocprofiler-compute + tests enabled.
Confirm test-compression installs under libexec/rocprofiler-compute/tests/ with correct RPATH.
Run ctest -R test-compression.

Test Result

Pending CI.

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/CONTRIBUTING.md.

…b runtime dep

therock-pr-bot · 2026-08-17T15:33:57Z

❌ PR Check — Action Required

Check	Status	Details
📝 PR Description	❌ Fail	Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword. Expected: include a `JIRA ID` / `ISSUE ID` line (separator `:` or `-`, or omitted; value may be a JIRA key, a number with/without `#`, or a link), OR a closing keyword + issue reference. Accepted examples: • `JIRA ID : TESTAUTO-6039` • `JIRA ID - #330` • `JIRA ID #330` • `JIRA ID` (on separate line) `ROCM-25757` • `ISSUE ID : TESTUTO-3334` • `ISSUE ID #3334` • `ISSUE ID - TESTAUTO-3433` • `ISSUE ID` (on separate line) `AIRUNTIME-2352` • `ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234` • `Closes #10` • `Fixes octo-org/octo-repo#100` • `Resolves: #123` • `#123` • `https://github.com/<org_name>/<repo_name>/issues/123` Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	✅ Pass	PR does not contain code files — Unit Test auto-passed
🔎 pre-commit	⏳ Pending	⏳ Still running…
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

therock-pr-bot · 2026-08-17T15:33:59Z

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

Copilot

Pull request overview

This PR updates TheRock’s rocprofiler-compute integration so install-mode CI can run the newly added test-compression gtest by ensuring it receives the correct install RPATH handling and that bundled zlib is treated as a runtime dependency when sysdeps bundling is enabled.

Changes:

Include test-compression in the rocprofiler-compute post-hook loop that sets THEROCK_INSTALL_RPATH_ORIGIN for installed gtests.
Add ${THEROCK_BUNDLED_ZLIB} to rocprofiler-compute’s RUNTIME_DEPS so install-mode runs prefer bundled zlib over a system libz when applicable.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
profiler/post_hook_rocprofiler-compute.cmake	Extends the RPATH-origin post-hook to cover the new `test-compression` test target when present.
profiler/CMakeLists.txt	Adds bundled zlib to rocprofiler-compute runtime deps to align install-mode behavior with sysdeps bundling.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

vedithal-amd · 2026-08-17T22:04:57Z

gfx942 linux tests pass - merging

…ode CI (#7421) ## Motivation Added a `test-compression` gtest in [#9711 of rocprofiler-compute,](ROCm/rocm-systems#9711), but TheRock CI can't run it in install mode yet: - The post-hook sets install RPATH for the other gtests under `libexec/rocprofiler-compute/tests/` but not `test-compression` - The subproject pulls bundled elfutils/libdrm/sqlite3 but not zlib, so `pkg_check_modules(zlib)` can link system `libz` instead of bundled sysdeps The follow-up in rocm-systems repo is to add `test-compression` to `test_categories.yaml` after this merges. ## Technical Details - Add `test-compression` to the RPATH post-hook foreach in `profiler/post_hook_rocprofiler-compute.cmake`. - Add `${THEROCK_BUNDLED_ZLIB}` to `rocprofiler-compute` `RUNTIME_DEPS` in `profiler/CMakeLists.txt`. ## Test Plan - Build with rocprofiler-compute + tests enabled. - Confirm `test-compression` installs under `libexec/rocprofiler-compute/tests/` with correct RPATH. - Run `ctest -R test-compression`. ## Test Result - Pending CI. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/CONTRIBUTING.md.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Adam Van Sickle <adam.vansickle@amd.com> ## Motivation `rocprofiler-compute` gained a `THEROCK_BUNDLED_ZLIB` runtime dep in #7421, but the committed consumer graph was never regenerated. The drift check compares the whole file, so any PR touching a graph-affecting path either fails it or has to carry this line in an unrelated diff. Same class as #7298 / #7297. ## Technical Details Regenerated `test_tools/therock_consumer_graph.json` with `check_consumer_graph_drift.py --write` from a full-tree `THEROCK_ENABLE_ALL=ON` `gfx94X-dcgpu` configure. No other files change. The diff is one line: `rocprofiler-compute` added to `therock-zlib`'s consumers. `rocprofiler-compute` has a key in `fetch_test_configurations.py`, so changes to `therock-zlib` can now schedule its tests. That follows from the dependency #7421 added. ## Test Plan - Regenerated locally, then confirmed the result matches what CI independently computed on #7376. ## Test Result - Consumer graph drift check: pass. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/CONTRIBUTING.md.

fix(rocprofiler-compute): wire test-compression RPATH and bundled zli…

32e587a

…b runtime dep

github-project-automation Bot moved this to TODO in TheRock Triage Aug 17, 2026

github-project-automation Bot added this to TheRock Triage Aug 17, 2026

therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Aug 17, 2026

therock-pr-bot Bot removed the Not ready to Review PR has unresolved policy failures — reviews blocked label Aug 17, 2026

jamessiddeley-amd mentioned this pull request Aug 17, 2026

test(rocprofiler-compute): add test-compression to CI test categories ROCm/rocm-systems#10236

Merged

3 tasks

therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Aug 17, 2026

vedithal-amd approved these changes Aug 17, 2026

View reviewed changes

vedithal-amd marked this pull request as ready for review August 17, 2026 20:24

Copilot AI lite review requested due to automatic review settings August 17, 2026 20:24

Copilot started reviewing on behalf of vedithal-amd August 17, 2026 20:25

View session

Copilot AI reviewed Aug 17, 2026

View reviewed changes

feizheng10 approved these changes Aug 17, 2026

View reviewed changes

vedithal-amd merged commit 0961399 into main Aug 17, 2026
233 of 270 checks passed

vedithal-amd deleted the users/jamessiddeley-amd/rocprofiler-compute-compression-gtest branch August 17, 2026 22:05

github-project-automation Bot moved this from TODO to Done in TheRock Triage Aug 17, 2026

vedithal-amd mentioned this pull request Aug 18, 2026

feat(ci): Update TheRock hash to 7c4f91f (2026-08-18) ROCm/rocm-systems#10317

Closed

avansick-amd mentioned this pull request Aug 18, 2026

fix(ci): regenerate stale committed consumer graph #7440

Merged

1 task done

Navigation Menu

Repository navigation

fix(rocprofiler-compute): wire test-compression for TheRock install-mode CI - #7421

fix(rocprofiler-compute): wire test-compression for TheRock install-mode CI#7421
vedithal-amd merged 1 commit into
mainfrom
users/jamessiddeley-amd/rocprofiler-compute-compression-gtest

jamessiddeley-amd commented Aug 17, 2026 •

edited

Loading

Uh oh!

therock-pr-bot Bot commented Aug 17, 2026 •

edited

Loading

Uh oh!

therock-pr-bot Bot commented Aug 17, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

vedithal-amd commented Aug 17, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jamessiddeley-amd commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Uh oh!

therock-pr-bot Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ PR Check — Action Required

Uh oh!

therock-pr-bot Bot commented Aug 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

vedithal-amd commented Aug 17, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jamessiddeley-amd commented Aug 17, 2026 •

edited

Loading

therock-pr-bot Bot commented Aug 17, 2026 •

edited

Loading