Repository navigation
fix(ci): regenerate stale committed consumer graph - #7440
Conversation
test_tools/therock_consumer_graph.json was missing rocprofiler-compute from one consumer list. Regenerated with the repo's own tool from a full ENABLE_ALL / gfx94X-dcgpu configure; no CMake change sits behind it. The Consumer Graph Drift Check is pull_request-only with no push trigger, so nothing regenerates the file after a merge and main can drift silently. The next PR touching any **/CMakeLists.txt then inherits the failure. JIRA ID: ROCPDSNA-73
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
|
That's a very long AI generated PR description for what could be summarized in one sentence as:
The one additional detail that is useful in the current description is the lack of a Please read https://github.com/ROCm/TheRock/blob/main/CONTRIBUTING.md#ai-tool-use-policy for future PRs. |
|
For reference, here's another PR updating the committed graph: #7297. Still verbose, but about half as much text. |
Thanks! I was just looking through that one actually. I was about to update with a new description more or less lifted from it. |
ScottTodd
left a comment
There was a problem hiding this comment.
Passing here: https://github.com/ROCm/TheRock/actions/runs/32096784259/job/95589599898, lgtm.
I think we should also add a push trigger to https://github.com/ROCm/TheRock/blob/main/.github/workflows/test_consumer_graph_drift.yml to make it easier to spot when it started failing (it takes ~10 minutes to run on github-hosted runners so running on only pushes affecting the relevant files is a nice optimization instead of running on push for all file changes)
Co-authored-by: Claude Opus 5 noreply@anthropic.com
Signed-off-by: Adam Van Sickle adam.vansickle@amd.com
Motivation
rocprofiler-computegained aTHEROCK_BUNDLED_ZLIBruntime dep in #7421, but thecommitted consumer graph was never regenerated. The drift check compares the whole
file, so any PR touching a graph-affecting path either fails it or has to carry this
line in an unrelated diff. Same class as #7298 / #7297.
Technical Details
Regenerated
test_tools/therock_consumer_graph.jsonwithcheck_consumer_graph_drift.py --writefrom a full-treeTHEROCK_ENABLE_ALL=ONgfx94X-dcgpuconfigure. No other files change.The diff is one line:
rocprofiler-computeadded totherock-zlib's consumers.rocprofiler-computehas a key infetch_test_configurations.py,so changes to
therock-zlibcan now schedule its tests.That follows from the dependency #7421 added.
Test Plan
computed on [profiler] Add profiler-hub as a TheRock subproject and artifact #7376.
Test Result
Submission Checklist