Skip to content

fix(ci): regenerate stale committed consumer graph - #7440

Merged
avansick-amd merged 1 commit into
mainfrom
users/avansick-amd/consumer-graph-drift-fix
Aug 18, 2026
Merged

avansick-amd merged 1 commit into
mainfrom
users/avansick-amd/consumer-graph-drift-fix

Conversation

@avansick-amd

@avansick-amd avansick-amd commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

Co-authored-by: Claude Opus 5 noreply@anthropic.com
Signed-off-by: Adam Van Sickle adam.vansickle@amd.com

Motivation

rocprofiler-compute gained a THEROCK_BUNDLED_ZLIB runtime dep in #7421, but the
committed consumer graph was never regenerated. The drift check compares the whole
file, so any PR touching a graph-affecting path either fails it or has to carry this
line in an unrelated diff. Same class as #7298 / #7297.

Technical Details

Regenerated test_tools/therock_consumer_graph.json with
check_consumer_graph_drift.py --write from a full-tree THEROCK_ENABLE_ALL=ON
gfx94X-dcgpu configure. No other files change.

The diff is one line: rocprofiler-compute added to therock-zlib's consumers.

rocprofiler-compute has a key in fetch_test_configurations.py,
so changes to therock-zlib can now schedule its tests.
That follows from the dependency #7421 added.

Test Plan

Test Result

  • Consumer graph drift check: pass.

Submission Checklist

test_tools/therock_consumer_graph.json was missing rocprofiler-compute
from one consumer list. Regenerated with the repo's own tool from a full
ENABLE_ALL / gfx94X-dcgpu configure; no CMake change sits behind it.

The Consumer Graph Drift Check is pull_request-only with no push trigger,
so nothing regenerates the file after a merge and main can drift silently.
The next PR touching any **/CMakeLists.txt then inherits the failure.

JIRA ID: ROCPDSNA-73
@therock-pr-bot

therock-pr-bot Bot commented Aug 18, 2026 •

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@ScottTodd

ScottTodd commented Aug 18, 2026 •

Copy link
Copy Markdown
Member

That's a very long AI generated PR description for what could be summarized in one sentence as:

Commit <> did not update test_tools/therock_consumer_graph.json, this fixes it.

The one additional detail that is useful in the current description is the lack of a push trigger in the workflow for post-merge coverage that would make this easier to track through the history. We will not "regenerate the committed graph after a merge" automatically though, as that would require granting automation commit access.

Please read https://github.com/ROCm/TheRock/blob/main/CONTRIBUTING.md#ai-tool-use-policy for future PRs.

@ScottTodd

Copy link
Copy Markdown
Member

For reference, here's another PR updating the committed graph: #7297. Still verbose, but about half as much text.

@avansick-amd

Copy link
Copy Markdown
Contributor Author

For reference, here's another PR updating the committed graph: #7297. Still verbose, but about half as much text.

Thanks! I was just looking through that one actually. I was about to update with a new description more or less lifted from it.

@ScottTodd ScottTodd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing here: https://github.com/ROCm/TheRock/actions/runs/32096784259/job/95589599898, lgtm.

I think we should also add a push trigger to https://github.com/ROCm/TheRock/blob/main/.github/workflows/test_consumer_graph_drift.yml to make it easier to spot when it started failing (it takes ~10 minutes to run on github-hosted runners so running on only pushes affecting the relevant files is a nice optimization instead of running on push for all file changes)

@avansick-amd
avansick-amd merged commit f0d2080 into main Aug 18, 2026
164 of 175 checks passed
@avansick-amd
avansick-amd deleted the users/avansick-amd/consumer-graph-drift-fix branch August 18, 2026 19:46
@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants