Repository navigation
Bump rocm-libraries from c91cf58 to 29e5b0a - #9711
Closed
assistant-librarian[bot] wants to merge 1 commit into
Closed
assistant-librarian[bot] wants to merge 1 commit into
assistant-librarian[bot] wants to merge 1 commit into
Conversation
assistant-librarian
Bot
added
ci:asan
|
🤖 Bump PR detected (author |
This was referenced Nov 3, 2026
Contributor
Author
|
Closing stale PR. |
bgopesh
pushed a commit
to bwelton/TheRock
that referenced
this pull request
Nov 7, 2026
…ode CI (ROCm#7421) ## Motivation Added a `test-compression` gtest in [ROCm#9711 of rocprofiler-compute,](ROCm/rocm-systems#9711), but TheRock CI can't run it in install mode yet: - The post-hook sets install RPATH for the other gtests under `libexec/rocprofiler-compute/tests/` but not `test-compression` - The subproject pulls bundled elfutils/libdrm/sqlite3 but not zlib, so `pkg_check_modules(zlib)` can link system `libz` instead of bundled sysdeps The follow-up in rocm-systems repo is to add `test-compression` to `test_categories.yaml` after this merges. ## Technical Details - Add `test-compression` to the RPATH post-hook foreach in `profiler/post_hook_rocprofiler-compute.cmake`. - Add `${THEROCK_BUNDLED_ZLIB}` to `rocprofiler-compute` `RUNTIME_DEPS` in `profiler/CMakeLists.txt`. ## Test Plan - Build with rocprofiler-compute + tests enabled. - Confirm `test-compression` installs under `libexec/rocprofiler-compute/tests/` with correct RPATH. - Run `ctest -R test-compression`. ## Test Result - Pending CI. ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps ROCm/rocm-libraries from ROCm/rocm-libraries@c91cf58 to ROCm/rocm-libraries@29e5b0a.
See full comparison here: ROCm/rocm-libraries@c91cf58...29e5b0a