Skip to content

feat(ci): Update TheRock hash to 7c4f91f (2026-08-18) - #10317

Closed
vedithal-amd wants to merge 1 commit into
developfrom
users/vedithal-amd/update-hash-7c4f91f
Closed

vedithal-amd wants to merge 1 commit into
developfrom
users/vedithal-amd/update-hash-7c4f91f

Conversation

@vedithal-amd

Copy link
Copy Markdown
Contributor

Update TheRock hash to 7c4f91f (2026-08-18)

Picks up the rocprofiler-compute changes merged in TheRock since 48ec94d:

Picks up the rocprofiler-compute changes merged in TheRock since 48ec94d:
ROCm/TheRock#7425, ROCm/TheRock#7421, ROCm/TheRock#7427.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 18, 2026 15:05
@vedithal-amd
vedithal-amd requested a review from a team as a code owner August 18, 2026 15:05
@github-actions github-actions Bot added the github actions Pull requests that update GitHub Actions code label Aug 18, 2026
@therock-pr-bot

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the pinned ROCm/TheRock commit SHA used by several GitHub Actions workflows in rocm-systems, bringing CI runs in sync with TheRock commit 7c4f91f (2026-08-18) and the upstream fixes listed in the PR description.

Changes:

  • Bump ROCm/TheRock checkout ref from 48ec94d… to 7c4f91f… across affected CI workflows.
  • Align the in-file annotated date comments on the pinned SHA to 2026-08-18.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/workflows/therock-test-packages.yml Update pinned TheRock checkout SHA used by the packages test workflow.
.github/workflows/therock-test-component.yml Update pinned TheRock checkout SHA used by the component test workflow.
.github/workflows/therock-rccl-test-pytorch-distributed.yml Update pinned TheRock checkout SHA used by the RCCL PyTorch distributed test workflow.
.github/workflows/therock-rccl-test-packages-single-node.yml Update pinned TheRock checkout SHA used by the single-node RCCL package tests.
.github/workflows/therock-rccl-test-packages-multi-node.yml Update pinned TheRock checkout SHA used by the multi-node RCCL package tests.
.github/workflows/therock-rccl-ci-linux.yml Update pinned TheRock checkout SHA used by RCCL CI on Linux.
.github/workflows/therock-ci.yml Update pinned TheRock checkout SHA used by the main TheRock CI workflow.
.github/workflows/therock-ci-windows.yml Update pinned TheRock checkout SHA used by TheRock CI on Windows.
.github/workflows/therock-ci-linux.yml Update pinned TheRock checkout SHA used by TheRock CI on Linux.
.github/workflows/therock-build-linux.yml Update pinned TheRock checkout SHA used by the Linux build workflow.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@jbonnell-amd jbonnell-amd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming all CI checks pass and no regressions present

@vedithal-amd

Copy link
Copy Markdown
Contributor Author

This got superseded - closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github actions Pull requests that update GitHub Actions code Not ready to Review organization: ROCm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants