Skip to content

test(rocprofiler-compute): add test-compression to CI test categories - #10236

Merged
vedithal-amd merged 2 commits into
rocprofiler-compute-developfrom
users/jamessiddeley-amd/compression-gtest
Aug 19, 2026
Merged

vedithal-amd merged 2 commits into
rocprofiler-compute-developfrom
users/jamessiddeley-amd/compression-gtest

Conversation

@jamessiddeley-amd

@jamessiddeley-amd jamessiddeley-amd commented Aug 17, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

Added the native test-compression gtest in (#9711) added but it was left out of test_categories.yaml until TheRock could build and run it in install mode.

Blocked on ROCm/TheRock#7421, which fixes the RPATH post-hook and bundled zlib runtime dep. We need to merge that first.

Technical Details

Add test-compression to test_patterns in quick, standard, comprehensive, full, and sanitizer — alongside test-rocprofiler-compute-tool and test-pc-sampling-collector.

Test Plan

  • Merge TheRock #7421
  • TheRock CI: ctest -R test-compression passes in install mode
  • rocprofiler-compute CI quick tier includes and runs test-compression

Test Result

Submission Checklist

[x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.

@vedithal-amd vedithal-amd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking for TheRock PR to be merged and TheRock SHA bumped in rocm-sysems

@vedithal-amd
vedithal-amd marked this pull request as ready for review August 17, 2026 20:25
@vedithal-amd
vedithal-amd requested a review from a team as a code owner August 17, 2026 20:25
Copilot AI lite review requested due to automatic review settings August 17, 2026 20:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the newly introduced native test-compression CTest/GTest to rocprofiler-compute’s tiered CI test categorization so it will be selected by the same tiers that already run other native tool tests.

Changes:

  • Add test-compression to test_patterns for the quick, standard, comprehensive, full, and sanitizer categories in test_categories.yaml.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@vedithal-amd vedithal-amd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TheRock has been adjusted so we can enable unit test for src/lib/utils/compressiongzip_output_stream.cpp

@vedithal-amd

Copy link
Copy Markdown
Contributor

override merging due to green signal from CI workflows which have passed.
Other CI failures are unrelated.

@vedithal-amd
vedithal-amd merged commit 5026d82 into rocprofiler-compute-develop Aug 19, 2026
114 of 119 checks passed
@vedithal-amd
vedithal-amd deleted the users/jamessiddeley-amd/compression-gtest branch August 19, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants