Repository navigation
test(rocprofiler-compute): add test-compression to CI test categories - #10236
Merged
vedithal-amd merged 2 commits intoAug 19, 2026
Merged
vedithal-amd merged 2 commits into
vedithal-amd merged 2 commits into
Conversation
vedithal-amd
approved these changes
Aug 17, 2026
vedithal-amd
approved these changes
Aug 17, 2026
vedithal-amd
requested changes
Aug 17, 2026
vedithal-amd
left a comment
Contributor
There was a problem hiding this comment.
Blocking for TheRock PR to be merged and TheRock SHA bumped in rocm-sysems
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the newly introduced native test-compression CTest/GTest to rocprofiler-compute’s tiered CI test categorization so it will be selected by the same tiers that already run other native tool tests.
Changes:
- Add
test-compressiontotest_patternsfor thequick,standard,comprehensive,full, andsanitizercategories intest_categories.yaml.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
feizheng10
approved these changes
Aug 17, 2026
vedithal-amd
approved these changes
Aug 19, 2026
vedithal-amd
left a comment
Contributor
There was a problem hiding this comment.
TheRock has been adjusted so we can enable unit test for src/lib/utils/compressiongzip_output_stream.cpp
…md/compression-gtest
Contributor
|
override merging due to green signal from CI workflows which have passed. |
vedithal-amd
merged commit Aug 19, 2026
5026d82
into
rocprofiler-compute-develop
114 of 119 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Added the native
test-compressiongtest in (#9711) added but it was left out oftest_categories.yamluntil TheRock could build and run it in install mode.Blocked on ROCm/TheRock#7421, which fixes the RPATH post-hook and bundled zlib runtime dep. We need to merge that first.
Technical Details
Add
test-compressiontotest_patternsin quick, standard, comprehensive, full, and sanitizer — alongsidetest-rocprofiler-compute-toolandtest-pc-sampling-collector.Test Plan
ctest -R test-compressionpasses in install modetest-compressionTest Result
Submission Checklist
[x] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.