[2] Merge with upstream#46
Merged
Merged
Conversation
The original draft spec for RedJubjub did not include key prefixing, and both this reference implementation and the Rust implementation were implemented following that spec. Then when key prefixing was added, the Rust code was updated at its call sites instead of inside the RedJubjub implementation. Now that we are migrating to the `redjubjub` crate which correctly builds in key prefixing, the old test vectors can no longer be used.
Add key prefixing to RedJubjub
Add ZIP 32 Seed Fingerprint encoding to test vectors
This PR is intended to fix the mirror+file 404s that started [showing up in CI](https://github.com/zcash/zcash-test-vectors/actions/runs/17371436288/job/49407384424#step:3:94). `apt-get update` seemed the simplest place to start. Open to other ideas!
Co-authored-by: Kris Nuttycombe <kris@nutty.land>
…nstall CI: `apt-get update` before `apt-get install gnome-keyring`
This reverts commit dcdb844.
Add NSM transaction test vectors
…g in TransactionBase
PaulLaux
previously approved these changes
Dec 29, 2025
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
please update the target branch to zsa1 and make sure the newly generated vectors work before merging. (do no squash)
PaulLaux
approved these changes
Dec 30, 2025
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
looks good, please do a final check before creating the merge commit.
vivek-arte
added a commit
to QED-it/librustzcash
that referenced
this pull request
Feb 13, 2026
…for the OrchardZSA review (#207) This adds fixes for compilation under the --features zip-233 option. The test vectors are also updated to match the updates from the zcash-test-vectors repository (QED-it/zcash-test-vectors#46 and QED-it/zcash-test-vectors#47). These add support for the ZIP 233 addition to the transaction format, as well as some regeneration that occurs due to changes in the randomness while generating the test vectors. --------- Co-authored-by: Paul <3682187+PaulLaux@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges in the updates from
upstream/masterto the target branch.This should be changed to target
zsa1after the merging of #45.