Add key prefixing to RedJubjub#95
Merged
Merged
Conversation
The original draft spec for RedJubjub did not include key prefixing, and both this reference implementation and the Rust implementation were implemented following that spec. Then when key prefixing was added, the Rust code was updated at its call sites instead of inside the RedJubjub implementation. Now that we are migrating to the `redjubjub` crate which correctly builds in key prefixing, the old test vectors can no longer be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original draft spec for RedJubjub did not include key prefixing, and both this reference implementation and the Rust implementation were implemented following that spec. Then when key prefixing was added, the Rust code was updated at its call sites instead of inside the RedJubjub implementation.
Now that we are migrating to the
redjubjubcrate which correctly builds in key prefixing, the old test vectors can no longer be used.