Fixes for ZIP 233 transaction format change support, and updates to test vectors#184
Closed
vivek-arte wants to merge 8 commits into
Closed
Fixes for ZIP 233 transaction format change support, and updates to test vectors#184vivek-arte wants to merge 8 commits into
vivek-arte wants to merge 8 commits into
Conversation
vivek-arte
changed the title
vivek-arte
force-pushed
the
zip233-fix-with-test-vectors
branch
from
3786447 to
a71d14e
Compare
Closed
vivek-arte
force-pushed
the
zip233-fix-with-test-vectors
branch
from
d90236b to
0782c0c
Compare
Author
|
Closed in favour of #207 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds fixes for compilation under the
--features zip-233option (subsuming #183).The test vectors are also updated to match the updates from the
zcash-test-vectorsrepository (QED-it/zcash-test-vectors#46). These add support for the ZIP 233 addition to the transaction format, as well as some regeneration that occurs due to changes in the randomness while generating the test vectors.