Expand the sample set of Unicode code points#47
Merged
Conversation
vivek-arte
changed the base branch from
pr108_review_fixes_orchardzsa
to
zsa1
…ction to be the entire set of Unicode code points
vivek-arte
force-pushed
the
expand_unicode_code_points
branch
from
0626d5a to
587b33e
Compare
PaulLaux
previously approved these changes
Feb 2, 2026
PaulLaux
approved these changes
Feb 2, 2026
This was referenced Feb 2, 2026
vivek-arte
added a commit
to QED-it/librustzcash
that referenced
this pull request
Feb 13, 2026
…for the OrchardZSA review (#207) This adds fixes for compilation under the --features zip-233 option. The test vectors are also updated to match the updates from the zcash-test-vectors repository (QED-it/zcash-test-vectors#46 and QED-it/zcash-test-vectors#47). These add support for the ZIP 233 addition to the transaction format, as well as some regeneration that occurs due to changes in the randomness while generating the test vectors. --------- Co-authored-by: Paul <3682187+PaulLaux@users.noreply.github.com>
vivek-arte
added a commit
to QED-it/orchard
that referenced
this pull request
Feb 17, 2026
…ors` (#238) QED-it/zcash-test-vectors#47 expands the sample set of Unicode code points, which leads to a different random selection of asset description strings, and therefore different asset base values in `src/test_vectors/asset_base.rs`. This PR copies those changes in, along with some CI locking for tests to pass. --------- Co-authored-by: Dmitry Demin <dmitry@qed-it.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR expands the sampled code points for the
get_random_unicode_bytesfunction to include all allowed Unicode code points.This changes the random values of the
descriptionof the Assets, and therefore changes theorchard_zsa_digests.rsandorchard_zsa_asset_base.rsfiles, which would need to be copied into thelibrustzcashandorchardrepositories respectively.