[1] Preparation changes for merging with upstream#45
Merged
Conversation
Merged
PaulLaux
reviewed
Dec 29, 2025
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
Will these changes affect the actual test vectors generated?
PaulLaux
approved these changes
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR performs some code refactoring to make the upstream merge in the next step less complicated.
The refactoring is cosmetic in that it doesn't affect the generated test vectors.
It mainly splits out the initialization and byte serialization of the transaction (in
TransactionBase) to differing functions forheader,transparentandsaplingparts of the transaction.The Orchard parts are in the child classes (TransactionV5 and TransactionV6) and are not separated out into functions.