[ZIP-233] Network Sustainability Mechanism: Burning#88
Merged
Conversation
Instead the PCZT is parsed into its protocol-specific types, and getters on those are used. The remaining getters are used for sighash derivation, the one part of the stack that is not currently modular.
Changes required for Keystone firmware support
Update changelogs with dependency bumps from Keystone PR
…protocol` This fixes a few errors that have been introduced over time since `zcash_extensions` is not regularly built, and migrates `zcash_extensions` to eliminate the use of deprecated `zcash_primitives` APIs.
As of `nonempty 0.11`, `nonempty` is `no-std` compatible and therefore the `nonempty` dependency no longer needs to be optional.
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
`zcash_primitives`: Add `no_std` support
This commit on its own doesn't expand the public API, as such `WalletDb`s cannot be constructed.
This requires `C: Borrow<rusqlite::Connection>` to ensure that at least `WalletRead` is accessible. It enables construction of the following additional types: - `WalletDb<&rusqlite::Connection, _>` - `WalletDb<&mut rusqlite::Connection, _>`
zcash_client_sqlite: Enable constructing `WalletDb` around references to `rusqlite::Connection`
Remove `devtools` crate
zcash_client_sqlite: Allow `init_wallet_db` with `&mut` connections
Update to `incrementalmerkletree 0.8`, `shardtree 0.6`
CI: Check workflows and actions with zizmor
pczt: Add `Prover::{requires_sapling_proofs, requires_orchard_proof}`
zcash_client_backend: Allow disabling Tor directory permissions tightening
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.28.0 to 3.28.9. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@48ab28a...9e8d078) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Release zcash_address 0.7.1
…e_zcash_address_backports
Merge zcash_address backports
This fixes a missing feature flag in the `zcash_primitives` dependencies.
Add CHANGELOG entry
Define `TargetValue` to select spendable notes
…0.19.1 Release zcash_primitives 0.19.1
…0.20.1 Release zcash_primitives 0.20.1
…ckports Merge zcash_primitives backports
…" flag, added NU7
mariopil
force-pushed
the
nsm
branch
4 times, most recently
from
3201291 to
2630263
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the
librustzcashchanges required for ZIP-233 (NSM - Burning), which adds a transaction field forburnAmount. This is essentially a copy of zcash#1567 that I'm posting here for convenience. Unfortunately this also includes a diff with upstream. I briefly tried rebasing on thezsa1branch, but it looks like it could be messy. However, I can take some time to do this if you'd rather not merge with upstreamlibrustzcashat this time?