Skip to content

Merge zcash_address backports#1793

Merged
nuttycom merged 10 commits into
mainfrom
merge_zcash_address_backports
May 7, 2025
Merged

Merge zcash_address backports#1793
nuttycom merged 10 commits into
mainfrom
merge_zcash_address_backports

Conversation

@nuttycom
Copy link
Copy Markdown
Collaborator

@nuttycom nuttycom commented May 7, 2025

No description provided.

nuttycom added 5 commits May 7, 2025 10:28
This adds a trait that permits contextual conversions from
`ZcashAddress` into a target type. Where `TryFromAddress` permits
context-less conversions, this trait allows implementers to inspect the
contents of an address in the context of other data or operations.
zcash_address: Add `Converter` trait and `ZcashAddress::convert_with`
@nuttycom nuttycom marked this pull request as draft May 7, 2025 16:56
@nuttycom nuttycom force-pushed the merge_zcash_address_backports branch from 7df36a0 to 5503589 Compare May 7, 2025 17:23
@nuttycom nuttycom marked this pull request as ready for review May 7, 2025 17:23
str4d
str4d previously approved these changes May 7, 2025
Copy link
Copy Markdown
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 5503589

@nuttycom nuttycom merged commit 25d24c1 into main May 7, 2025
43 checks passed
@nuttycom nuttycom deleted the merge_zcash_address_backports branch May 7, 2025 18:24
@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 57.81%. Comparing base (d0b4717) to head (d802eaa).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
components/zcash_address/src/convert.rs 0.00% 21 Missing ⚠️
components/zcash_address/src/lib.rs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1793      +/-   ##
==========================================
- Coverage   57.89%   57.81%   -0.08%     
==========================================
  Files         181      181              
  Lines       21993    22022      +29     
==========================================
  Hits        12732    12732              
- Misses       9261     9290      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants