Update to incrementalmerkletree 0.8, shardtree 0.6#1692
Conversation
| orchard = { git = "https://github.com/zcash/orchard.git", rev = "b1c22c07300db22239235d16dab096e23369948f" } | ||
| redjubjub = { git = "https://github.com/ZcashFoundation/redjubjub", rev = "eae848c5c14d9c795d000dd9f4c4762d1aee7ee1" } | ||
| sapling = { package = "sapling-crypto", git = "https://github.com/zcash/sapling-crypto.git", rev = "e607c52d13bb7ade66293f9ab8d07e311f4ad868" } | ||
| sapling = { package = "sapling-crypto", git = "https://github.com/zcash/sapling-crypto.git", rev = "6ca338532912adcd82369220faeea31aab4720c5" } | ||
| incrementalmerkletree = { git = "https://github.com/zcash/incrementalmerkletree.git", rev = "44065917a399a921a2151bd14d399a192eb61960" } | ||
| incrementalmerkletree-testing = { git = "https://github.com/zcash/incrementalmerkletree.git", rev = "44065917a399a921a2151bd14d399a192eb61960" } | ||
| shardtree = { git = "https://github.com/zcash/incrementalmerkletree.git", rev = "44065917a399a921a2151bd14d399a192eb61960" } |
There was a problem hiding this comment.
I have not checked these commit hashes.
nuttycom
force-pushed
the
incrementalmerkletree_update
branch
from
34616c0 to
2de9260
Compare
|
Not reviewing because it's still failing tests. |
nuttycom
force-pushed
the
incrementalmerkletree_update
branch
from
2de9260 to
6cf0806
Compare
nuttycom
force-pushed
the
incrementalmerkletree_update
branch
from
6cf0806 to
c19f8cd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1692 +/- ##
==========================================
- Coverage 54.36% 54.33% -0.03%
==========================================
Files 173 173
Lines 20274 20282 +8
==========================================
Hits 11021 11021
- Misses 9253 9261 +8 ☔ View full report in Codecov by Sentry. |
nuttycom
force-pushed
the
incrementalmerkletree_update
branch
from
c19f8cd to
fc306e9
Compare
nuttycom
force-pushed
the
incrementalmerkletree_update
branch
from
fc306e9 to
1b2dab2
Compare
| let ceildiv = |num: usize, den: usize| num.div_ceil(den); | ||
|
|
||
| let logical_actions = max( | ||
| ceildiv(t_in_total_size, self.p2pkh_standard_input_size), |
There was a problem hiding this comment.
This could be just t_in_total_size.div_ceil(self.p2pkh_standard_input_size), and similarly on the next line, deleting the closure definition. It doesn't really matter, but a good clean-up if you have time.
There was a problem hiding this comment.
Oh, ceildiv only existed in the first place because it wasn't supported in the standard library at the MSRV we were on; bumping to 1.81 made this change possible and I just didn't notice.
daira
left a comment
daira
left a comment
There was a problem hiding this comment.
Post-hoc ACK with minor comment.
3 participants
No description provided.