zcash_client_backend: Allow disabling Tor directory permissions tightening#1697
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1697 +/- ##
=======================================
Coverage 54.33% 54.33%
=======================================
Files 173 173
Lines 20282 20282
=======================================
Hits 11021 11021
Misses 9261 9261 ☔ View full report in Codecov by Sentry. |
daira
reviewed
Feb 7, 2025
| /// If `with_permissions` is `None`, the default from [`arti_client`] will be used | ||
| /// (enable permissions checks unless the `ARTI_FS_DISABLE_PERMISSION_CHECKS` env | ||
| /// variable is set). | ||
| /// |
Contributor
There was a problem hiding this comment.
Perhaps include an example of using with_permissions other than None, and/or reference the docs for MistrustBuilder.
Contributor
Author
There was a problem hiding this comment.
The type's methods have decent documentation, which is accessible through rust-analyzer in IDEs, so I think this should be fine as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1686.