`zcash_primitives`: Add `no_std` support by nuttycom · Pull Request #1688 · zcash/librustzcash

nuttycom · 2025-01-28T05:03:18Z

This depends upon zcash/orchard#453 and zcash/sapling-crypto#152

Subsumes #1683

codecov · 2025-01-28T06:34:40Z

Codecov Report

Attention: Patch coverage is 72.95082% with 33 lines in your changes missing coverage. Please review.

Project coverage is 52.00%. Comparing base (1b09741) to head (d352b93).
Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
zcash_primitives/src/merkle_tree.rs	33.33%	16 Missing ⚠️
...h_primitives/src/transaction/components/orchard.rs	70.00%	3 Missing ⚠️
zcash_primitives/src/transaction/components/tze.rs	0.00%	3 Missing ⚠️
zcash_primitives/src/encoding.rs	93.54%	2 Missing ⚠️
zcash_primitives/src/transaction/builder.rs	50.00%	2 Missing ⚠️
...sh_primitives/src/transaction/components/sprout.rs	0.00%	2 Missing ⚠️
...imitives/src/transaction/components/tze/builder.rs	0.00%	2 Missing ⚠️
...h_primitives/src/transaction/components/sapling.rs	66.66%	1 Missing ⚠️
zcash_primitives/src/transaction/fees/zip317.rs	0.00%	1 Missing ⚠️
zcash_primitives/src/transaction/mod.rs	93.75%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1688      +/-   ##
==========================================
+ Coverage   51.89%   52.00%   +0.10%     
==========================================
  Files         180      181       +1     
  Lines       21169    21192      +23     
==========================================
+ Hits        10986    11021      +35     
+ Misses      10183    10171      -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

daira

utACK with non-blocking comments.

nuttycom · 2025-01-29T03:32:27Z

force-pushed to use versions of orchard and sapling-crypto that have been merged to their respective main branches.

daira

utACK with non-blocking suggestion (but there are conflicts).

…protocol` This fixes a few errors that have been introduced over time since `zcash_extensions` is not regularly built, and migrates `zcash_extensions` to eliminate the use of deprecated `zcash_primitives` APIs.

As of `nonempty 0.11`, `nonempty` is `no-std` compatible and therefore the `nonempty` dependency no longer needs to be optional.

Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>

nuttycom · 2025-01-29T15:23:50Z

force-pushed to resolve conflicts and fix warnings.

daira

utACK d352b93

nuttycom force-pushed the zcash_primitives_no_std branch 4 times, most recently from 52dcfd4 to c78d482 Compare January 28, 2025 23:27

nuttycom marked this pull request as ready for review January 29, 2025 00:32

nuttycom force-pushed the zcash_primitives_no_std branch from 2290f58 to 4d0ce78 Compare January 29, 2025 00:33