fix(registry): add vertex to PROVIDER_REGISTRY so auxiliary clients can use ADC

[xxiaoxiong]

Summary

Fixes #66674.

The auxiliary client (title_generation, context_compression, memory_flush) cannot use Vertex AI over ADC, even when the main chat agent works fine. Setting auxiliary.<task>.provider: vertex always falls back to OpenRouter/Nous with the spurious error:

Provider 'vertex' is set in config.yaml but no API key was found. Set the VERTEX_API_KEY environment variable

Root cause

resolve_provider_client() (agent/auxiliary_client.py, ~L4849) guards with:

pconfig = PROVIDER_REGISTRY.get(provider)
if pconfig is None:
    return None, None

There is a correct Vertex/ADC branch a bit further down (agent/auxiliary_client.py:5215), but it is dead code because vertex is never in PROVIDER_REGISTRY:

• vertex exists only as a plugin (plugins/model-providers/vertex/) with auth_type="vertex" and env_vars=().
• The auto-extend loop at hermes_cli/auth.py:~L452 skips non-api_key providers:

  if _pp.auth_type != "api_key" or not _pp.env_vars:
      continue

  So vertex is skipped.

Contrast bedrock (auth_type="aws_sdk", api_key_env_vars=()) — it is hardcoded into the static PROVIDER_REGISTRY at hermes_cli/auth.py:429, so its analogous aux branch is reachable.

Fix

Mirror bedrock: add a static vertex entry to PROVIDER_REGISTRY with auth_type="vertex" and empty api_key_env_vars. The existing elif pconfig.auth_type == "vertex": branch at agent/auxiliary_client.py:5215 then becomes reachable and uses get_vertex_config() to mint an ADC token, identical to the main agent's path.

Verification

>>> from hermes_cli.auth import PROVIDER_REGISTRY
>>> v = PROVIDER_REGISTRY.get('vertex')
>>> v.id, v.auth_type, v.api_key_env_vars
('vertex', 'vertex', ())

The auto-extend loop does not overwrite the static entry (it only adds new plugin providers, not replaces).

Checklist

• Reproduces the issue on current origin/main
• Static registry entry mirrors bedrock exactly (same ProviderConfig shape)
• No behavior change for non-vertex providers
• vertex plugin's own aliases are still auto-extended via the _PROVIDER_ALIASES loop

Notes

This is a low-risk 8-line change to a single dict. No new tests added because exercising resolve_provider_client(vertex) end-to-end requires GCP ADC, which CI cannot provide. Manual verification above confirms the unblocking.

Maintainer consideration: vertex is the third non-api_key provider (after bedrock and copilot-acp-style OAuth). If more ADC providers appear, a follow-up could relax the auto-extend predicate to include auth_type in {"vertex", "aws_sdk"} and remove the need for static entries — but that is a larger refactor and out of scope for this defect.

[tonydwb]

Code Review Summary

Verdict: Comment

+8/-0 adds vertex to PROVIDER_REGISTRY so auxiliary clients can use ADC (Application Default Credentials). Small registry addition. No concerns.

Reviewed by Hermes Agent

[tonydwb]

LGTM

[teknium1]

Thanks for tracing this to the auxiliary registry boundary. The current-main premise is confirmed: agent/auxiliary_client.py:5146-5153 returns before its existing Vertex branch at agent/auxiliary_client.py:5300-5334, and hermes_cli/auth.py:451-456 excludes Vertex's non-API-key, empty-env-vars profile from auto-registration.

Problems

• The PR has no regression test for the auxiliary route. tests/hermes_cli/test_vertex_provider.py verifies primary runtime resolution, but does not call resolve_provider_client("vertex"); a future registry change could make this branch unreachable again.

Suggested changes

• Add a no-network test that mocks has_vertex_credentials, get_vertex_config, and openai.OpenAI, then asserts the auxiliary resolver builds a client with the minted token and computed base URL. This does not require live ADC.

This is an automated hermes-sweeper review.

[GottZ]

This was generated by AI during triage.

Summary

Twenty-three PRs address or reference the Vertex integration complex, spanning auxiliary ADC reachability, misleading credential errors, model normalization, doctor validation, picker visibility, and CLI overlay resolution. For #66707's reported cause, the relevant diffs either register Vertex so the existing auxiliary OAuth/ADC branch becomes reachable or provide alternative profile/direct dispatch mechanisms; the same registry repair is recorded as integrated from #56688 through #70282.

Related pull requests

• fix(vertex,moa): register vertex in PROVIDER_REGISTRY and HERMES_OVERLAYS #56688 [closed] best fix — (+134/-0) — n/a: Registers Vertex in PROVIDER_REGISTRY and HERMES_OVERLAYS and adds auxiliary token refresh, directly covering fix(registry): add vertex to PROVIDER_REGISTRY so auxiliary clients can use ADC #66707's dead registry-gated ADC path; although closed, it remains the merged reference because contributor follow-up says it was cherry-picked through fix(moa): config/CLI plumbing — doctor, non-interactive presets, lossless saves, slot hygiene, vertex registration (cluster salvage) #70282 at commit 9b868f6.
• fix(cli): add google/ publisher prefix normalization for Vertex AI #56805 [closed] partial — (+66/-0) — n/a: Adds Vertex model-prefix normalization rather than auxiliary registry reachability; it remains relevant after closure as the superseded variant that could malformedly double-prefix explicit non-Google publishers, and was closed in favor of fix(vertex): prepend mandatory google/ publisher prefix to bare model names #56809.
• fix(vertex): prefix google publisher for Gemini models #56806 [closed] fixes — (+40/-0) — n/a: Adds bounded google/ normalization for bare Gemini/Gemma IDs while preserving qualified publishers, addressing bug(providers): Vertex AI provider fails with HTTP 400 due to missing mandatory 'google/' publisher prefix #56778 rather than fix(registry): add vertex to PROVIDER_REGISTRY so auxiliary clients can use ADC #66707; it is closed and superseded by the more complete fix(vertex): prepend mandatory google/ publisher prefix to bare model names #56809 normalization lane.
• fix(vertex): prepend mandatory google/ publisher prefix to bare model names #56809 best fix — (+84/-0) — n/a: Adds the focused Vertex normalization branch for bare names and aliases while preserving explicit publishers, but does not modify PROVIDER_REGISTRY or auxiliary dispatch; its keep_open review supports retaining it as a salvage path for bug(providers): Vertex AI provider fails with HTTP 400 due to missing mandatory 'google/' publisher prefix #56778.
• fix(agent): clarify auxiliary provider auth failures #56842 [closed] fixes — (+86/-11) — n/a: Replaces the misleading sync/async API-key errors with auth-type-aware guidance but does not make the Vertex ADC handler reachable; although closed, it remains the earlier message-only implementation for Misleading "API key was found" RuntimeError for non-API-key OAuth/ADC providers in auxiliary tasks #56810.
• Fix auxiliary Vertex provider resolution #56861 best fix — (+164/-6) — n/a: Makes Vertex auxiliary resolution reachable through ProviderProfile fallback, adds aliases, and corrects sync/async OAuth/ADC guidance; its keep_open review supports salvage onto current main rather than unchanged use of the stale branch.
• fix(agent): clarify auxiliary OAuth provider credential errors #56863 [closed] fixes — (+111/-10) — n/a: Changes the same sync/async failure sites to credential-type-aware guidance without repairing the registry miss; it is closed as a duplicate of the earlier message-only fix(agent): clarify auxiliary provider auth failures #56842.
• fix(doctor): recognize plugin-registered providers like vertex #56930 fixes — (+30/-0) — n/a: Addresses doctor false positives through plugin-provider discovery and a Vertex slug exemption, not fix(registry): add vertex to PROVIDER_REGISTRY so auxiliary clients can use ADC #66707's auxiliary registry gate; its keep_open review requires fixing the transport/API-mode mismatch, alias coverage, and warning assertion.
• fix(doctor): stop false positives on vertex configs #56939 best fix — (+93/-9) — n/a: Provides a narrow doctor-only fix covering canonical Vertex, all four aliases, and google/... slugs without changing auxiliary dispatch; its keep_open review requires keeping the closing claim narrower than [Bug]: hermes doctor fails when using the new vertex provider #56906's separate title-generation symptom.
• fix(doctor): recognize Vertex provider profiles #56962 [closed] partial — (+54/-0) — n/a: Adds ProviderProfile names to doctor validation but neither fixes the vendor-slug warning nor auxiliary reachability; it remains relevant after closure as an incomplete doctor-path alternative.
• fix(doctor): recognize vertex provider config #57154 best fix — (+10/-5) — n/a: Extends doctor's known providers and allows Vertex google/... model IDs, leaving the auxiliary registry path unchanged; its keep_open review supports doctor-lane salvage after narrowing the overbroad [Bug]: hermes doctor fails when using the new vertex provider #56906 closing claim.
• fix(vertex): register in PROVIDER_REGISTRY and surface as authenticated in desktop picker #57399 best fix — (+121/-0) — n/a: Adds Vertex registry metadata plus picker credential/model handling, overlapping fix(registry): add vertex to PROVIDER_REGISTRY so auxiliary clients can use ADC #66707's prerequisite but targeting picker visibility; its keep_open review blocks unchanged use because ordinary picker listing can trigger lazy dependency installation or ADC probing.
• fix(cli): add vertex provider to HERMES_OVERLAYS for /model command #57541 [closed] partial — (+48/-0) — n/a: Adds the Vertex CLI overlay and aliases without touching auxiliary ADC dispatch; it remains relevant after closure as an overlay-only subset explicitly superseded by broader fix(vertex,moa): register vertex in PROVIDER_REGISTRY and HERMES_OVERLAYS #56688.
• fix(cli): add vertex provider to HERMES_OVERLAYS for /model resolution #57559 best fix — (+68/-0) — n/a: Adds the Vertex overlay, aliases, credential variables, label, and lookup tests for /model, but not auxiliary reachability or model normalization; its keep_open review requires combining this salvage with the normalization behavior represented by fix(vertex): prepend mandatory google/ publisher prefix to bare model names #56809.
• fix(doctor): recognize provider-profile-only providers like vertex #59679 fixes — (+184/-1) — n/a: Makes doctor consult provider profiles and credential-path variables and permits publisher-prefixed profile models, without modifying fix(registry): add vertex to PROVIDER_REGISTRY so auxiliary clients can use ADC #66707's registry gate; its keep_open review requires adding the runtime-valid vertexai alias.
• fix(auxiliary_client): route vertex through the auth_type dispatch #61853 fixes — (+546/-6) — n/a: Uses a Vertex-scoped profile fallback to reach auxiliary dispatch and adds token refresh plus global/regional route inference, but substantially overlaps the earlier Fix auxiliary Vertex provider resolution #56861 resolution mechanism; its keep_open review's original generic-dispatch and refresh concerns are addressed in the shown revised diff.
• fix(auth): register vertex in PROVIDER_REGISTRY for auxiliary clients #61933 duplicate — (+95/-0) — n/a: The shown diff adds auxiliary aliases and registry-dependent resolver tests, but does not itself show the static PROVIDER_REGISTRY production entry described by its title; despite its keep_open review and later rebase, it is not a standalone replacement for the registry implementation already landed from fix(vertex,moa): register vertex in PROVIDER_REGISTRY and HERMES_OVERLAYS #56688.
• fix(aux): resolve Vertex AI provider for auxiliary tasks #62440 [closed] fixes — (+54/-0) — n/a: Adds a direct pre-registry Vertex client branch and aliases, bypassing the dead gate while duplicating the existing auth_type="vertex" client construction; it is closed under an implemented-on-main verdict and remains relevant as an alternative routing design.
• register vertex in PROVIDER_REGISTRY to enable auxiliary tasks #62444 best fix — (+47/-2) — n/a: Dynamically admits auth_type="vertex" profiles into PROVIDER_REGISTRY, adds aliases, and tests the now-reachable resolver, matching a recorded best fix for [Bug]: Every auxiliary task silently fails on provider: vertex #61852/Auxiliary client cannot use Vertex AI — the auth_type="vertex" ADC branch is unreachable (vertex missing from PROVIDER_REGISTRY) #66674; its keep_open review requested the route regression that the shown updated diff now includes, but the registry outcome overlaps landed fix(vertex,moa): register vertex in PROVIDER_REGISTRY and HERMES_OVERLAYS #56688.
• fix(aux): register vertex in PROVIDER_REGISTRY and add vertex aliases (#61852) #62700 [closed] fixes — (+11/-0) — n/a: Statically registers Vertex and adds the same four auxiliary aliases, directly fixing the early registry return but without regression tests; it is closed as a duplicate of the better-tested fix(auth): register vertex in PROVIDER_REGISTRY for auxiliary clients #61933.
• fix(doctor): register vertex provider so hermes doctor recognizes Google Vertex AI (#65949) #65962 [closed] partial — (+21/-0) — n/a: Attempts doctor/provider registration using unsupported auth_type="gcp_sdk" and adds no doctor regression, so it does not implement the canonical Vertex dispatch contract; it was closed after a contributor reported merge conflicts.
• fix(registry): add vertex to PROVIDER_REGISTRY so auxiliary clients can use ADC #66707 fixes — (+8/-0) — n/a: Adds the minimal static auth_type="vertex" registry row that makes the existing ADC auxiliary branch reachable, exactly matching the reported cause; despite its keep_open review, which requested a no-network resolver regression, the same registry mechanism is recorded as already integrated from fix(vertex,moa): register vertex in PROVIDER_REGISTRY and HERMES_OVERLAYS #56688 through fix(moa): config/CLI plumbing — doctor, non-interactive presets, lossless saves, slot hygiene, vertex registration (cluster salvage) #70282 commit 9b868f6.
• fix: register vertex provider in CLI menus #68249 [closed] fixes — (+19/-1) — n/a: Repeats Vertex registry/overlay wiring and aliases, including duplicate dictionary entries in the shown diff; it is closed as a duplicate of the broader, tested fix(vertex,moa): register vertex in PROVIDER_REGISTRY and HERMES_OVERLAYS #56688.

Duplicates

Registry/reachability cluster: #66707, #61933, #62444, and closed #62700 overlap the landed registry outcome of #56688, while #56861/#61853 use the competing ProviderProfile-fallback mechanism and closed #62440 uses a direct branch. Normalization: #56805/#56806 overlap #56809; message-only errors: #56863 duplicates #56842; overlays: closed #57541 overlaps #57559 and #56688; closed #68249 duplicates #56688.

Suggested consolidation

Close #66707 as already implemented on main: contributor follow-up on #56688 identifies cluster PR #70282 commit 9b868f6 as the integration of the same auth_type="vertex" registry repair, so #66707's +8-line diff no longer adds a distinct fix. This departs from the keep_open review on #66707 only because that review evaluated the missing-regression-test PR in isolation before accounting for the recorded landed implementation; close overlapping registry alternatives #61933 and #62444 as duplicates of the landed #56688 outcome, while preserving #62444's recorded best-fix status as evidence that its mechanism correctly addresses #61852/#66674, and keep the distinct #56809, #56861, #56939/#57154/#59679, #57399, #57559, and #61853 salvage paths open for their separately reviewed deltas.

Complex graph

flowchart LR
    classDef open fill:#dbeafe,stroke:#1d4ed8,color:#1e3a8a
    classDef merged fill:#dcfce7,stroke:#15803d,color:#14532d
    classDef closed fill:#e5e7eb,stroke:#6b7280,color:#1f2937
    classDef unverified fill:#f3f4f6,stroke:#9ca3af,color:#374151
    classDef best stroke-width:3px,stroke:#b45309
    classDef target stroke-width:3px,stroke:#4338ca
    I56687(["issue #56687 (closed)"])
    I56810(["issue #56810 (open)"])
    I61852(["issue #61852 (open)"])
    I66674(["issue #66674 (open)"])
    subgraph Dup61933 ["PRs duplicating each other"]
        P61933["PR #61933 (open)"]
        P62700["PR #62700 (closed)"]
        P66707["PR #66707 (open)"]
    end
    P66707 -.->|partial| I56687
    P66707 -.->|partial| I56810
    P66707 -->|fixes| I61852
    P66707 -->|fixes| I66674
    class I56687 closed
    class I56810 open
    class I61852 open
    class I66674 open
    class P61933 open
    class P62700 closed
    class P66707 open
    class P66707 target
    click I56687 "https://github.com/NousResearch/hermes-agent/issues/56687"
    click I56810 "https://github.com/NousResearch/hermes-agent/issues/56810"
    click I61852 "https://github.com/NousResearch/hermes-agent/issues/61852"
    click I66674 "https://github.com/NousResearch/hermes-agent/issues/66674"
    click P61933 "https://github.com/NousResearch/hermes-agent/pull/61933"
    click P62700 "https://github.com/NousResearch/hermes-agent/pull/62700"
    click P66707 "https://github.com/NousResearch/hermes-agent/pull/66707"

Loading

Graph: solid arrow = fixes / best fix, dashed arrow = partial or unverified (see edge label); boxed group = PRs duplicating each other; amber border = best fix; indigo border = target; gray node = closed (state tag in the node label).

Cross-PR triage: Reviewed 23 pull requests and 10 issues in this complex. Each diff was read against this issue; Assessment working set: 134 kB of PR diffs, 100 kB of issue/PR text, 40 kB of discussion (60 comments), 86 verify verdicts. verdicts reflect diff content, not PR titles. Part of an automated triage batch.

[xxiaoxiong]

Closing stale PR — superseded by upstream work / no longer relevant.