You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes hermes doctor diagnostics for the Vertex provider. Doctor now recognizes provider IDs from the model/provider catalog in addition to API-key auth providers, so model.provider: vertex is not reported as unknown.
It also allows Vertex's recommended google/gemini-* model IDs through the vendor-slug check, matching the Vertex setup flow and runtime path.
Competing-PR cluster for #56906 (hermes doctor false-positives on Vertex). Four open PRs now fix this via distinct mechanisms: #56930 (plugin-registry fallback in providers.py::get_provider, earliest), #56939 (normalize_provider + expanded known set), #56962 (ProviderProfile enumeration in doctor), and this one (#57154, catalog _KNOWN_PROVIDER_NAMES + vendor-slug allow). Related, not duplicates — different code paths. Flagging for a maintainer to pick one (earliest = #56930).
Thanks for the narrow doctor-path fix. Current main still rejects a configured provider whenever catalog_provider is None in hermes_cli/doctor.py:818-833, and still warns on Vertex's documented google/... model IDs because vertex is absent from providers_accepting_vendor_slugs in hermes_cli/doctor.py:841-858. The setup flow writes provider: vertex at hermes_cli/model_setup_flows.py:2455, while the documentation specifies google/gemini-3-flash-preview at website/docs/integrations/providers.md:398-403.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
area/install-updateInstaller, updater, packaging, wheels, doctorcomp/cliCLI entry point, hermes_cli/, setup wizardP3Low — cosmetic, nice to haveprovider/geminiGoogle Gemini (AI Studio, Cloud Code)sweeper:blast-moderateSweeper blast radius: moderate — a subsystem or single platformsweeper:risk-compatibilitySweeper risk: may break existing users, config, migrations, defaults, or upgradestype/bugSomething isn't working
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
hermes doctordiagnostics for the Vertex provider. Doctor now recognizes provider IDs from the model/provider catalog in addition to API-key auth providers, somodel.provider: vertexis not reported as unknown.It also allows Vertex's recommended
google/gemini-*model IDs through the vendor-slug check, matching the Vertex setup flow and runtime path.Related Issue
Fixes #56906
Type of Change
Changes
hermes_cli.models._KNOWN_PROVIDER_NAMES.resolve_provider_full()has no catalog object for them.vertexto the vendor-slug-accepting provider policy.provider: vertexwithdefault: google/gemini-3-flash-preview.How to Test
.venv/bin/python -m pytest tests/hermes_cli/test_doctor.py -q -k "provider_ids_that_catalog_aliases or vertex".venv/bin/python -m pytest tests/hermes_cli/test_doctor.py -q.venv/bin/python -m ruff check hermes_cli/doctor.py tests/hermes_cli/test_doctor.pyscripts/run_tests.sh tests/hermes_cli/test_doctor.py -qpytest tests/ -qPlatform: macOS, Python 3.13, local
.venv.