Skip to content

fix(doctor): recognize vertex provider config - #57154

Open
tianma-if wants to merge 1 commit into
NousResearch:mainfrom
tianma-if:codex/fix-doctor-vertex-provider
Open

fix(doctor): recognize vertex provider config#57154
tianma-if wants to merge 1 commit into
NousResearch:mainfrom
tianma-if:codex/fix-doctor-vertex-provider

Conversation

@tianma-if

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes hermes doctor diagnostics for the Vertex provider. Doctor now recognizes provider IDs from the model/provider catalog in addition to API-key auth providers, so model.provider: vertex is not reported as unknown.

It also allows Vertex's recommended google/gemini-* model IDs through the vendor-slug check, matching the Vertex setup flow and runtime path.

Related Issue

Fixes #56906

Type of Change

  • Bug fix
  • Tests
  • New feature
  • Documentation
  • Refactor

Changes

  • Extends doctor provider validation with hermes_cli.models._KNOWN_PROVIDER_NAMES.
  • Treats catalog-known provider IDs as valid even when resolve_provider_full() has no catalog object for them.
  • Adds vertex to the vendor-slug-accepting provider policy.
  • Adds a regression case for provider: vertex with default: google/gemini-3-flash-preview.

How to Test

  • .venv/bin/python -m pytest tests/hermes_cli/test_doctor.py -q -k "provider_ids_that_catalog_aliases or vertex"
  • .venv/bin/python -m pytest tests/hermes_cli/test_doctor.py -q
  • .venv/bin/python -m ruff check hermes_cli/doctor.py tests/hermes_cli/test_doctor.py
  • scripts/run_tests.sh tests/hermes_cli/test_doctor.py -q
  • pytest tests/ -q

Platform: macOS, Python 3.13, local .venv.

@alt-glitch alt-glitch added type/bug Something isn't working comp/cli CLI entry point, hermes_cli/, setup wizard provider/gemini Google Gemini (AI Studio, Cloud Code) P3 Low — cosmetic, nice to have labels Jul 2, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

This was generated by AI during triage.

Competing-PR cluster for #56906 (hermes doctor false-positives on Vertex). Four open PRs now fix this via distinct mechanisms: #56930 (plugin-registry fallback in providers.py::get_provider, earliest), #56939 (normalize_provider + expanded known set), #56962 (ProviderProfile enumeration in doctor), and this one (#57154, catalog _KNOWN_PROVIDER_NAMES + vendor-slug allow). Related, not duplicates — different code paths. Flagging for a maintainer to pick one (earliest = #56930).

@teknium1 teknium1 added sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform labels Jul 15, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the narrow doctor-path fix. Current main still rejects a configured provider whenever catalog_provider is None in hermes_cli/doctor.py:818-833, and still warns on Vertex's documented google/... model IDs because vertex is absent from providers_accepting_vendor_slugs in hermes_cli/doctor.py:841-858. The setup flow writes provider: vertex at hermes_cli/model_setup_flows.py:2455, while the documentation specifies google/gemini-3-flash-preview at website/docs/integrations/providers.md:398-403.

Problems

Suggested changes

  • Use Related to #56906 instead, or address the title-generation symptom separately.

Automated hermes-sweeper review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/install-update Installer, updater, packaging, wheels, doctor comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have provider/gemini Google Gemini (AI Studio, Cloud Code) sweeper:blast-moderate Sweeper blast radius: moderate — a subsystem or single platform sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: hermes doctor fails when using the new vertex provider

3 participants