fix(vertex): prefix google publisher for Gemini models - #56806
Closed
kyssta-exe wants to merge 1 commit into
Closed
Conversation
19 tasks
harjothkhara
reviewed
Jul 2, 2026
harjothkhara
left a comment
Contributor
There was a problem hiding this comment.
Recommendation: treat #56806 as the stronger lane for #56778, and let #56805 either adopt this normalization shape or close as a duplicate.
Cluster disposition:
- #56806: strongest / merge-candidate lane. It fixes bare Gemini/Gemma Vertex IDs while preserving already publisher-qualified IDs (
custom-publisher/model-id) and unknown private model IDs, and it covers thegoogle-vertexalias. - #56805: duplicate / needs-improvement. Its current Vertex block unconditionally prefixes every non-
google/value after strippingvertex/, socustom-publisher/model-idbecomesgoogle/custom-publisher/model-id.
That distinction matters because the Vertex error in #56778 says the endpoint expects <publisher>/<model>, not that every publisher-qualified model should be rewritten to Google's publisher namespace. Preserving slash-qualified IDs keeps the fix bounded to the reported bare Google-model case without breaking other Vertex publisher namespaces.
Proof I checked:
- exact duplicate search for
56778found #56805 and #56806; broaderVertex AI google publisher prefix Geminisearch found historical #16010/#21480 only. - On #56805:
normalize_model_for_provider("custom-publisher/model-id", "vertex")returnsgoogle/custom-publisher/model-id. - On this branch: the same call returns
custom-publisher/model-id; baregemini-3.1-flash-liteand aliasgoogle-vertexboth normalize togoogle/gemini-3.1-flash-lite. scripts/run_tests.sh tests/hermes_cli/test_vertex_provider.py tests/hermes_cli/test_model_normalize.py-> 100 passed.
This was referenced Jul 2, 2026
Contributor
Author
|
Stale — 12-13 days without merge activity. |
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56778.\n\n## Summary\n- normalize bare Gemini/Gemma model IDs for the Vertex AI provider to the required google/ publisher-qualified form\n- preserve already-qualified and custom publisher model IDs\n\n## Tests\n- scripts/run_tests.sh tests/hermes_cli/test_vertex_provider.py tests/hermes_cli/test_model_normalize.py