fix(doctor): register vertex provider so hermes doctor recognizes Google Vertex AI (#65949) - #65962
Closed
kyssta-exe wants to merge 1 commit into
Closed
fix(doctor): register vertex provider so hermes doctor recognizes Google Vertex AI (#65949)#65962kyssta-exe wants to merge 1 commit into
kyssta-exe wants to merge 1 commit into
Conversation
…_OVERLAYS so hermes doctor recognizes Google Vertex AI (NousResearch#65949) Google Vertex AI is a valid provider configured via GCP ADC/service accounts, but it was missing from PROVIDER_REGISTRY (auth provider list) and HERMES_OVERLAYS (provider metadata). This caused 'hermes doctor' to report: model.provider 'vertex' is not a recognised provider Root cause: doctor.py builds its known-provider list from PROVIDER_REGISTRY.keys(), and vertex was never added there because it uses GCP SDK auth rather than a static API key. Fix: - Add vertex to PROVIDER_REGISTRY in auth.py (gcp_sdk auth type, like bedrock uses aws_sdk) so resolve_provider() and doctor recognize it. - Add vertex to HERMES_OVERLAYS in providers.py so get_provider() and resolve_provider_full() return proper metadata. - Add vertex aliases (google-vertex, vertex-ai, gcp-vertex, vertexai) to ALIASES in both providers.py and auth.py's _PROVIDER_ALIASES.
tonydwb
reviewed
Jul 16, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Looks good. No obvious issues found.
Reviewed by Hermes Agent
Contributor
|
Thanks for tracing the doctor validation path; the reported false positive is present on current main. Problems
Suggested changes
Automated hermes-sweeper review. |
Contributor
Author
|
This PR has merge conflicts with the base branch and cannot be merged in its current state. Closing as part of automated PR maintenance — please rebase and re-open if the fix is still needed. |
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using
model.provider: vertexfor Google Vertex AI, runninghermes doctorfails with:Vertex AI is a valid provider that works correctly at runtime (via
runtime_provider.py→agent.vertex_adapter), but it was missing from bothPROVIDER_REGISTRYandHERMES_OVERLAYS.Root Cause
doctor.pybuilds its known-provider list fromPROVIDER_REGISTRY.keys()+{"openrouter", "custom", "auto"}. Sincevertexwas never added to either:PROVIDER_REGISTRY(auth.py) — soresolve_provider("vertex")raisedAuthErrorHERMES_OVERLAYS(providers.py) — soget_provider("vertex")returnedNoneFix
vertexentry toPROVIDER_REGISTRYwithauth_type="gcp_sdk"(parallel tobedrockusingauth_type="aws_sdk"). Emptyapi_key_env_varsandbase_url_env_varsince Vertex uses GCP ADC / service account files, not static keys.vertextoHERMES_OVERLAYS(transport="openai_chat",auth_type="gcp_sdk") so provider metadata resolves properly.google-vertex,vertex-ai,gcp-vertex,vertexai→vertex) toALIASES.resolve_provider's_PROVIDER_ALIASESdict."vertex": "Google Vertex AI"to_LABEL_OVERRIDES.Testing
normalize_providerandresolve_providerget_provider("vertex")returns a properProviderDefwithid="vertex"vertexis now visible inprovider_catalog()Fixes #65949